Address comment: stop widen type when checking for spread any;

Kanchalai Tanglertsampan · Kanchalai Tanglertsampan · commit 6ce31d7dfe14 · 2017-01-19T09:49:33.000-08:00
Address comment: using ternary operator, fix comments
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload2.js b/tests/baselines/reference/tsxStatelessFunctionComponentOverload2.js
@@ -18,7 +18,7 @@ let obj2 = {
     "ignore-prop": "hello"
 }
 
-let defaultObj = undefined;
+let defaultObj: any;
 
 // OK
 const c1 = <OneThing />
@@ -47,7 +47,7 @@ define(["require", "exports", "react"], function (require, exports, React) {
         yy: 500,
         "ignore-prop": "hello"
     };
-    var defaultObj = undefined;
+    var defaultObj;
     // OK
     var c1 = <OneThing />;
     var c2 = <OneThing {...obj}/>;
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload2.symbols b/tests/baselines/reference/tsxStatelessFunctionComponentOverload2.symbols
@@ -42,9 +42,8 @@ let obj2 = {
     "ignore-prop": "hello"
 }
 
-let defaultObj = undefined;
+let defaultObj: any;
 >defaultObj : Symbol(defaultObj, Decl(file.tsx, 19, 3))
->undefined : Symbol(undefined)
 
 // OK
 const c1 = <OneThing />
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload2.types b/tests/baselines/reference/tsxStatelessFunctionComponentOverload2.types
@@ -50,9 +50,8 @@ let obj2 = {
 >"hello" : "hello"
 }
 
-let defaultObj = undefined;
+let defaultObj: any;
 >defaultObj : any
->undefined : undefined
 
 // OK
 const c1 = <OneThing />
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload3.js b/tests/baselines/reference/tsxStatelessFunctionComponentOverload3.js
@@ -6,7 +6,7 @@ interface Context {
 declare function ZeroThingOrTwoThing(): JSX.Element;
 declare function ZeroThingOrTwoThing(l: {yy: number, yy1: string}, context: Context): JSX.Element;
 
-let obj2 = undefined;
+let obj2: any;
 
 // OK
 const two1 = <ZeroThingOrTwoThing />;
@@ -25,7 +25,7 @@ const three2 = <ThreeThing y2="Bye" />;
 const three3 = <ThreeThing {...obj2} y2={10} />;  // it is just any so we allow it to pass through
 
 //// [file.jsx]
-var obj2 = undefined;
+var obj2;
 // OK
 var two1 = <ZeroThingOrTwoThing />;
 var two2 = <ZeroThingOrTwoThing yy={100} yy1="hello"/>;
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload3.symbols b/tests/baselines/reference/tsxStatelessFunctionComponentOverload3.symbols
@@ -21,9 +21,8 @@ declare function ZeroThingOrTwoThing(l: {yy: number, yy1: string}, context: Cont
 >JSX : Symbol(JSX, Decl(react.d.ts, 2352, 1))
 >Element : Symbol(JSX.Element, Decl(react.d.ts, 2355, 27))
 
-let obj2 = undefined;
+let obj2: any;
 >obj2 : Symbol(obj2, Decl(file.tsx, 7, 3))
->undefined : Symbol(undefined)
 
 // OK
 const two1 = <ZeroThingOrTwoThing />;
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload3.types b/tests/baselines/reference/tsxStatelessFunctionComponentOverload3.types
@@ -21,9 +21,8 @@ declare function ZeroThingOrTwoThing(l: {yy: number, yy1: string}, context: Cont
 >JSX : any
 >Element : JSX.Element
 
-let obj2 = undefined;
+let obj2: any;
 >obj2 : any
->undefined : undefined
 
 // OK
 const two1 = <ZeroThingOrTwoThing />;
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload4.errors.txt b/tests/baselines/reference/tsxStatelessFunctionComponentOverload4.errors.txt
@@ -42,7 +42,7 @@ tests/cases/conformance/jsx/file.tsx(34,29): error TS2322: Type '{ y1: "hello";
         yy: 10,
         yy1: "hello"
     }
-    let obj2 = undefined;
+    let obj2: any;
     
     // Error
     const c0 = <OneThing extraProp />;  // extra property;
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload4.js b/tests/baselines/reference/tsxStatelessFunctionComponentOverload4.js
@@ -8,7 +8,7 @@ let obj = {
     yy: 10,
     yy1: "hello"
 }
-let obj2 = undefined;
+let obj2: any;
 
 // Error
 const c0 = <OneThing extraProp />;  // extra property;
@@ -42,7 +42,7 @@ define(["require", "exports", "react"], function (require, exports, React) {
         yy: 10,
         yy1: "hello"
     };
-    var obj2 = undefined;
+    var obj2;
     // Error
     var c0 = <OneThing extraProp/>; // extra property;
     var c1 = <OneThing yy={10}/>; // missing property;
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload5.errors.txt b/tests/baselines/reference/tsxStatelessFunctionComponentOverload5.errors.txt
@@ -52,7 +52,7 @@ tests/cases/conformance/jsx/file.tsx(57,24): error TS2322: Type '{ data-format:
         onClick: ()=>{}
     }
     
-    let obj3 = undefined;
+    let obj3: any;
     
     export function MainButton(buttonProps: ButtonProps): JSX.Element;
     export function MainButton(linkProps: LinkProps): JSX.Element;
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload5.js b/tests/baselines/reference/tsxStatelessFunctionComponentOverload5.js
@@ -32,7 +32,7 @@ let obj2 = {
     onClick: ()=>{}
 }
 
-let obj3 = undefined;
+let obj3: any;
 
 export function MainButton(buttonProps: ButtonProps): JSX.Element;
 export function MainButton(linkProps: LinkProps): JSX.Element;
@@ -70,7 +70,7 @@ define(["require", "exports", "react"], function (require, exports, React) {
     var obj2 = {
         onClick: function () { }
     };
-    var obj3 = undefined;
+    var obj3;
     function MainButton(props) {
         var linkProps = props;
         if (linkProps.to) {
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload6.js b/tests/baselines/reference/tsxStatelessFunctionComponentOverload6.js
@@ -23,7 +23,7 @@ let obj = {
     children: "hi",
     to: "boo"
 }
-let obj1 = undefined;
+let obj1: any;
 let obj2 = {
     onClick: () => {}
 }
@@ -65,7 +65,7 @@ define(["require", "exports", "react"], function (require, exports, React) {
         children: "hi",
         to: "boo"
     };
-    var obj1 = undefined;
+    var obj1;
     var obj2 = {
         onClick: function () { }
     };
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload6.symbols b/tests/baselines/reference/tsxStatelessFunctionComponentOverload6.symbols
@@ -47,9 +47,8 @@ let obj = {
     to: "boo"
 >to : Symbol(to, Decl(file.tsx, 21, 19))
 }
-let obj1 = undefined;
+let obj1: any;
 >obj1 : Symbol(obj1, Decl(file.tsx, 24, 3))
->undefined : Symbol(undefined)
 
 let obj2 = {
 >obj2 : Symbol(obj2, Decl(file.tsx, 25, 3))
diff --git a/tests/baselines/reference/tsxStatelessFunctionComponentOverload6.types b/tests/baselines/reference/tsxStatelessFunctionComponentOverload6.types
@@ -50,9 +50,8 @@ let obj = {
 >to : string
 >"boo" : "boo"
 }
-let obj1 = undefined;
+let obj1: any;
 >obj1 : any
->undefined : undefined
 
 let obj2 = {
 >obj2 : { onClick: () => void; }
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload2.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload2.tsx
@@ -22,7 +22,7 @@ let obj2 = {
     "ignore-prop": "hello"
 }
 
-let defaultObj = undefined;
+let defaultObj: any;
 
 // OK
 const c1 = <OneThing />
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload3.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload3.tsx
@@ -10,7 +10,7 @@ interface Context {
 declare function ZeroThingOrTwoThing(): JSX.Element;
 declare function ZeroThingOrTwoThing(l: {yy: number, yy1: string}, context: Context): JSX.Element;
 
-let obj2 = undefined;
+let obj2: any;
 
 // OK
 const two1 = <ZeroThingOrTwoThing />;
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload4.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload4.tsx
@@ -12,7 +12,7 @@ let obj = {
     yy: 10,
     yy1: "hello"
 }
-let obj2 = undefined;
+let obj2: any;
 
 // Error
 const c0 = <OneThing extraProp />;  // extra property;
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload5.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload5.tsx
@@ -36,7 +36,7 @@ let obj2 = {
     onClick: ()=>{}
 }
 
-let obj3 = undefined;
+let obj3: any;
 
 export function MainButton(buttonProps: ButtonProps): JSX.Element;
 export function MainButton(linkProps: LinkProps): JSX.Element;
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload6.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload6.tsx
@@ -27,7 +27,7 @@ let obj = {
     children: "hi",
     to: "boo"
 }
-let obj1 = undefined;
+let obj1: any;
 let obj2 = {
     onClick: () => {}
 }

Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,8 @@ let obj2 = {`
`42`	`42`	`"ignore-prop": "hello"`
`43`	`43`	`}`
`44`	`44`
`45`		`-let defaultObj = undefined;`
	`45`	`+let defaultObj: any;`
`46`	`46`	`>defaultObj : Symbol(defaultObj, Decl(file.tsx, 19, 3))`
`47`		`->undefined : Symbol(undefined)`
`48`	`47`
`49`	`48`	`// OK`
`50`	`49`	`const c1 = <OneThing />`
Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,8 @@ let obj2 = {`
`50`	`50`	`>"hello" : "hello"`
`51`	`51`	`}`
`52`	`52`
`53`		`-let defaultObj = undefined;`
	`53`	`+let defaultObj: any;`
`54`	`54`	`>defaultObj : any`
`55`		`->undefined : undefined`
`56`	`55`
`57`	`56`	`// OK`
`58`	`57`	`const c1 = <OneThing />`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ tests/cases/conformance/jsx/file.tsx(34,29): error TS2322: Type '{ y1: "hello";`
`42`	`42`	`yy: 10,`
`43`	`43`	`yy1: "hello"`
`44`	`44`	`}`
`45`		`- let obj2 = undefined;`
	`45`	`+ let obj2: any;`
`46`	`46`
`47`	`47`	`// Error`
`48`	`48`	`const c0 = <OneThing extraProp />; // extra property;`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ tests/cases/conformance/jsx/file.tsx(57,24): error TS2322: Type '{ data-format:`
`52`	`52`	`onClick: ()=>{}`
`53`	`53`	`}`
`54`	`54`
`55`		`- let obj3 = undefined;`
	`55`	`+ let obj3: any;`
`56`	`56`
`57`	`57`	`export function MainButton(buttonProps: ButtonProps): JSX.Element;`
`58`	`58`	`export function MainButton(linkProps: LinkProps): JSX.Element;`