Skip to content

Commit 6f6be7e

Browse files
committed
Removed incorrect check of symbolKind determination of undefined symbol
1 parent 3715af1 commit 6f6be7e

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/services/services.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2754,10 +2754,6 @@ module ts {
27542754
if (symbolKind === ScriptElementKind.memberGetAccessorElement || symbolKind === ScriptElementKind.memberSetAccessorElement) {
27552755
symbolKind = ScriptElementKind.memberVariableElement;
27562756
}
2757-
else if (symbol.name === "undefined") {
2758-
// undefined is symbol and not property
2759-
symbolKind = ScriptElementKind.variableElement;
2760-
}
27612757

27622758
var type = typeResolver.getTypeOfSymbol(symbol);
27632759
if (type) {

tests/cases/fourslash/quickInfoOnUndefined.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@
33
////function foo(a: string) {
44
////}
55
////foo(/*1*/undefined);
6+
////var x = {
7+
//// undefined: 10
8+
////};
9+
////x./*2*/undefined = 30;
610

711
goTo.marker('1');
8-
verify.quickInfoIs('(var) undefined');
12+
verify.quickInfoIs('(var) undefined');
13+
14+
goTo.marker('2');
15+
verify.quickInfoIs('(property) undefined: number');

0 commit comments

Comments
 (0)