Skip to content

Commit 71a54fb

Browse files
author
Yui T
committed
Remove default setting of noResolve flag
1 parent dae98be commit 71a54fb

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

src/compiler/emitter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3183,9 +3183,9 @@ module ts {
31833183
var referencedFile = resolveScriptReference(root, fileReference);
31843184

31853185
// All the references that are not going to be part of same file
3186-
if ((referencedFile.flags & NodeFlags.DeclarationFile) || // This is a declare file reference
3186+
if (referencedFile && ((referencedFile.flags & NodeFlags.DeclarationFile) || // This is a declare file reference
31873187
shouldEmitToOwnFile(referencedFile, compilerOptions) || // This is referenced file is emitting its own js file
3188-
!addedGlobalFileReference) { // Or the global out file corresponding to this reference was not added
3188+
!addedGlobalFileReference)) { // Or the global out file corresponding to this reference was not added
31893189

31903190
writeReferencePath(referencedFile);
31913191
if (!isExternalModuleOrDeclarationFile(referencedFile)) {

src/services/shims.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -328,12 +328,6 @@ module ts {
328328
}
329329
var options = compilationSettingsToCompilerOptions(<CompilerOptions>JSON.parse(<any>settingsJson));
330330

331-
/// TODO: this should be pushed into VS.
332-
/// We can not ask the LS instance to resolve, as this will lead to asking the host about files it does not know about,
333-
/// something it is not designed to handle. for now make sure we never get a "noresolve == false".
334-
/// This value should not matter, as the host runs resolution logic independently
335-
options.noResolve = true;
336-
337331
return options;
338332
}
339333

0 commit comments

Comments
 (0)