Remove checks for symbol.declarations

Author: Andy Hanson

src/services/findAllReferences.ts

@@ -108,10 +108,6 @@ namespace ts.FindAllReferences {
             switch (def.type) {
                 case "symbol": {
                     const { symbol, node } = def;
-                    const declarations = symbol.declarations;
-                    if (!declarations || declarations.length === 0) {
-                        return undefined;
-                    }
                     const { displayParts, kind } = getDefinitionKindAndDisplayParts(symbol, node, checker);
                     const name = displayParts.map(p => p.text).join("");
                     return { node, name, kind, displayParts };
@@ -273,7 +269,7 @@ namespace ts.FindAllReferences.Core {
             }
         }
 
-        let symbol = checker.getSymbolAtLocation(node);
+        const symbol = checker.getSymbolAtLocation(node);
 
         // Could not find a symbol e.g. unknown identifier
         if (!symbol) {
@@ -285,14 +281,6 @@ namespace ts.FindAllReferences.Core {
             return undefined;
         }
 
-        // If this property is derived from another one, find references on the original property instead.
-        symbol = (symbol as ts.SymbolLinks).syntheticOrigin || symbol;
-
-        // The symbol was an internal symbol and does not have a declaration e.g. undefined symbol
-        if (!symbol.declarations || !symbol.declarations.length) {
-            return undefined;
-        }
-
         return getReferencedSymbolsForSymbol(symbol, node, sourceFiles, checker, cancellationToken, options);
     }
 

tests/cases/fourslash/findAllRefsMappedType.ts

@@ -7,4 +7,9 @@
 ////declare const u: U;
 ////u.[|a|];
 
-verify.singleReferenceGroup("(property) T.a: number");
+const ranges = test.ranges();
+const [r0, r1, r2] = ranges;
+verify.referenceGroups([r0, r1], [{ definition: "(property) T.a: number", ranges }]);
+verify.referenceGroups(r2, [
+    { definition: "(property) T.a: number", ranges: [r0, r1] },
+    { definition: "(property) a: string", ranges: [r2] }]);