Skip to content

Commit 84e857b

Browse files
committed
use forEachEntry
1 parent de7d68a commit 84e857b

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/services/codefixes/inferFromUsage.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -947,22 +947,19 @@ namespace ts.codefix {
947947

948948
function allPropertiesAreAssignableToUsage(type: Type, usage: Usage) {
949949
if (!usage.properties) return false;
950-
let result = true;
951-
usage.properties.forEach((propUsage, name) => {
950+
return !forEachEntry(usage.properties, (propUsage, name) => {
952951
const source = checker.getTypeOfPropertyOfType(type, name as string);
953952
if (!source) {
954-
result = false;
955-
return;
953+
return true;
956954
}
957955
if (propUsage.calls) {
958956
const sigs = checker.getSignaturesOfType(source, SignatureKind.Call);
959-
result = result && !!sigs.length && checker.isTypeAssignableTo(source, getFunctionFromCalls(propUsage.calls));
957+
return !sigs.length || !checker.isTypeAssignableTo(source, getFunctionFromCalls(propUsage.calls));
960958
}
961959
else {
962-
result = result && checker.isTypeAssignableTo(source, combineFromUsage(propUsage));
960+
return !checker.isTypeAssignableTo(source, combineFromUsage(propUsage));
963961
}
964962
});
965-
return result;
966963
}
967964

968965
/**

0 commit comments

Comments
 (0)