Skip to content

Commit 8728b98

Browse files
committed
Adding comment and removing unnecessary object creation
1 parent c742d16 commit 8728b98

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

src/server/client.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -216,15 +216,17 @@ namespace ts.server {
216216
return {
217217
isMemberCompletion: false,
218218
isNewIdentifierLocation: false,
219-
entries: response.body.map(({ name, kind, kindModifiers, sortText, replacementSpan }) => {
219+
entries: response.body.map(entry => {
220220

221-
let convertedSpan: TextSpan;
222-
if (replacementSpan) {
223-
convertedSpan = createTextSpanFromBounds(this.lineOffsetToPosition(fileName, replacementSpan.start),
221+
if (entry.replacementSpan !== undefined) {
222+
const { name, kind, kindModifiers, sortText, replacementSpan} = entry;
223+
224+
const convertedSpan = createTextSpanFromBounds(this.lineOffsetToPosition(fileName, replacementSpan.start),
224225
this.lineOffsetToPosition(fileName, replacementSpan.end));
226+
return { name, kind, kindModifiers, sortText, replacementSpan: convertedSpan };
225227
}
226228

227-
return { name, kind, kindModifiers, sortText, replacementSpan: convertedSpan };
229+
return entry as { name: string, kind: string, kindModifiers: string, sortText: string };
228230
})
229231
};
230232
}

src/services/services.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1488,6 +1488,11 @@ namespace ts {
14881488
kind: string; // see ScriptElementKind
14891489
kindModifiers: string; // see ScriptElementKindModifier, comma separated
14901490
sortText: string;
1491+
/**
1492+
* An optional span that indicates the text to be replaced by this completion item. It will be
1493+
* set if the required span differs from the one generated by the default replacement behavior and should
1494+
* be used in that case
1495+
*/
14911496
replacementSpan?: TextSpan;
14921497
}
14931498

0 commit comments

Comments
 (0)