change name of the flag to emitBOM

Author: mhegazy

src/compiler/commandLineParser.ts

@@ -24,7 +24,7 @@ module ts {
             type: "boolean",
         },
         {
-            name: "generateBOM", 
+            name: "emitBOM", 
             type: "boolean"
         },
         {

src/compiler/emitter.ts

@@ -1854,7 +1854,7 @@ module ts {
             }
 
             writeLine();
-            writeEmittedFiles(writer.getText(), /*writeByteOrderMark*/ compilerOptions.generateBOM);
+            writeEmittedFiles(writer.getText(), /*writeByteOrderMark*/ compilerOptions.emitBOM);
         }
 
         function emitDeclarations(jsFilePath: string, root?: SourceFile) {
@@ -2448,7 +2448,7 @@ module ts {
             // TODO(shkamat): Should we not write any declaration file if any of them can produce error, 
             // or should we just not write this file like we are doing now
             if (!reportedDeclarationError) {
-                writeFile(getModuleNameFromFilename(jsFilePath) + ".d.ts", referencePathsOutput + writer.getText(), compilerOptions.generateBOM);
+                writeFile(getModuleNameFromFilename(jsFilePath) + ".d.ts", referencePathsOutput + writer.getText(), compilerOptions.emitBOM);
             }
         }
 

src/compiler/sys.ts

@@ -90,7 +90,6 @@ var sys: System = (function () {
                 else {
                     fileStream.Position = 3;
                 }
-                fileStream.Position = 3;
                 fileStream.CopyTo(binaryStream);
                 binaryStream.SaveToFile(fileName, 2 /*overwrite*/);
             }

src/compiler/types.ts

@@ -939,7 +939,7 @@ module ts {
         codepage?: number;
         declaration?: boolean;
         diagnostics?: boolean;
-        generateBOM?: boolean;
+        emitBOM?: boolean;
         help?: boolean;
         locale?: string;
         mapRoot?: string;

src/harness/harness.ts

@@ -712,8 +712,8 @@ module Harness {
                             // Not supported yet
                             break;
 
-                        case 'generatebom':
-                            options.generateBOM = !!setting.value;
+                        case 'emitbom':
+                            options.emitBOM = !!setting.value;
                             break;
 
                         default:
@@ -897,7 +897,7 @@ module Harness {
         var optionRegex = /^[\/]{2}\s*@(\w+)\s*:\s*(\S*)/gm;  // multiple matches on multiple lines
 
         // List of allowed metadata names
-        var fileMetadataNames = ["filename", "comments", "declaration", "module", "nolib", "sourcemap", "target", "out", "outDir", "noimplicitany", "noresolve", "newline", "newlines", "generatebom"];
+        var fileMetadataNames = ["filename", "comments", "declaration", "module", "nolib", "sourcemap", "target", "out", "outDir", "noimplicitany", "noresolve", "newline", "newlines", "emitbom"];
 
         function extractCompilerSettings(content: string): CompilerSetting[] {
 

src/services/shims.ts

@@ -169,7 +169,7 @@ module ts {
         useCaseSensitiveFileResolution?: boolean;
         gatherDiagnostics?: boolean;
         codepage?: number;
-        generateBom?: boolean;
+        emitBOM?: boolean;
     }
 
     function languageVersionToScriptTarget(languageVersion: LanguageVersion): ScriptTarget {
@@ -232,7 +232,7 @@ module ts {
         options.declaration = settings.generateDeclarationFiles;
         //options.useCaseSensitiveFileResolution = settings.useCaseSensitiveFileResolution;
         options.codepage = settings.codepage;
-        options.generateBOM = settings.generateBom;
+        options.emitBOM = settings.emitBOM;
         return options;
     }
 
@@ -253,7 +253,7 @@ module ts {
         settings.generateDeclarationFiles = options.declaration;
         // settings.useCaseSensitiveFileResolution = options.useCaseSensitiveFileResolution;
         settings.codepage = options.codepage;
-        settings.generateBom = options.generateBOM;
+        settings.emitBOM = options.emitBOM;
         return settings;
     }
 

tests/cases/compiler/generateBOM.ts

@@ -1,4 +1,4 @@
-//@generateBOM: true
+//@emitBOM: true
 //@declaration: true
 //@sourcemap: true