Skip to content

Commit 9885e59

Browse files
committed
respond to code review comments
1 parent be2a41c commit 9885e59

File tree

1 file changed

+22
-20
lines changed

1 file changed

+22
-20
lines changed

src/services/services.ts

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3799,35 +3799,37 @@ module ts {
37993799
forEach(signatureHelpItems.items, signature => {
38003800
var signatureInfoString = signature.prefix;
38013801

3802-
var paramters: FormalParameterInfo[] = [];
3803-
for (var i = 0, n = signature.parameters.length; i < n; i++) {
3804-
var paramter = signature.parameters[i];
3802+
var parameters: FormalParameterInfo[] = [];
3803+
if (signature.parameters) {
3804+
for (var i = 0, n = signature.parameters.length; i < n; i++) {
3805+
var parameter = signature.parameters[i];
3806+
3807+
// add the parameter to the string
3808+
if (i) {
3809+
signatureInfoString += signature.separator;
3810+
}
38053811

3806-
// add the parameter to the string
3807-
if (i) {
3808-
signatureInfoString += signature.separator;
3812+
var start = signatureInfoString.length;
3813+
signatureInfoString += parameter.display;
3814+
var end = signatureInfoString.length - 1;
3815+
3816+
// add the parameter to the list
3817+
parameters.push({
3818+
name: parameter.name,
3819+
isVariable: i == n - 1 && signature.isVariadic,
3820+
docComment: parameter.documentation,
3821+
minChar: start,
3822+
limChar: end
3823+
});
38093824
}
3810-
3811-
var start = signatureInfoString.length;
3812-
signatureInfoString += paramter.display;
3813-
var end = signatureInfoString.length - 1;
3814-
3815-
// add the parameter to the list
3816-
paramters.push({
3817-
name: paramter.name,
3818-
isVariable: i == n -1 && signature.isVariadic,
3819-
docComment: paramter.documentation,
3820-
minChar: start,
3821-
limChar: end
3822-
});
38233825
}
38243826

38253827
signatureInfoString += signature.suffix;
38263828

38273829
formalSignatures.push({
38283830
signatureInfo: signatureInfoString,
38293831
docComment: signature.documentation,
3830-
parameters: paramters,
3832+
parameters: parameters,
38313833
typeParameters: [],
38323834
docComments: signature.documentation
38333835
});

0 commit comments

Comments
 (0)