Correct permitted jumps check

amcasey · amcasey · commit 9d11fbb9b9c4 · 2017-09-07T16:13:26.000-07:00
diff --git a/src/services/refactors/extractMethod.ts b/src/services/refactors/extractMethod.ts
@@ -417,7 +417,7 @@ namespace ts.refactor.extractMethod {
                                 }
                             }
                             else {
-                                if (!(permittedJumps & (SyntaxKind.BreakStatement ? PermittedJumps.Break : PermittedJumps.Continue))) {
+                                if (!(permittedJumps & (node.kind === SyntaxKind.BreakStatement ? PermittedJumps.Break : PermittedJumps.Continue))) {
                                     // attempt to break or continue in a forbidden context
                                     (errors || (errors = [])).push(createDiagnosticForNode(node, Messages.CannotExtractRangeContainingConditionalBreakOrContinueStatements));
                                 }

Original file line number	Diff line number	Diff line change
`@@ -417,7 +417,7 @@ namespace ts.refactor.extractMethod {`
`417`	`417`	`}`
`418`	`418`	`}`
`419`	`419`	`else {`
`420`		`- if (!(permittedJumps & (SyntaxKind.BreakStatement ? PermittedJumps.Break : PermittedJumps.Continue))) {`
	`420`	`+ if (!(permittedJumps & (node.kind === SyntaxKind.BreakStatement ? PermittedJumps.Break : PermittedJumps.Continue))) {`
`421`	`421`	`// attempt to break or continue in a forbidden context`
`422`	`422`	`(errors \|\| (errors = [])).push(createDiagnosticForNode(node, Messages.CannotExtractRangeContainingConditionalBreakOrContinueStatements));`
`423`	`423`	`}`