Skip to content

Commit a4d12a4

Browse files
authored
fix(58146): enum quick info can display non ascii strings (#58171)
1 parent a9b0d1e commit a4d12a4

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

src/compiler/utilities.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1762,7 +1762,7 @@ function canUseOriginalText(node: LiteralLikeNode, flags: GetLiteralTextFlags):
17621762

17631763
/** @internal */
17641764
export function getTextOfConstantValue(value: string | number) {
1765-
return isString(value) ? '"' + escapeNonAsciiString(value) + '"' : "" + value;
1765+
return isString(value) ? `"${escapeString(value)}"` : "" + value;
17661766
}
17671767

17681768
// Make an identifier from an external module name by extracting the string after the last "/" and replacing
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
/// <reference path='fourslash.ts' />
2+
3+
//// enum Demo {
4+
//// /*Emoji*/Emoji = '🍎',
5+
//// /*Hebrew*/Hebrew = 'תפוח',
6+
//// /*Chinese*/Chinese = '苹果',
7+
//// /*Japanese*/Japanese = 'りんご',
8+
//// }
9+
10+
verify.quickInfoAt("Emoji", '(enum member) Demo.Emoji = "🍎"');
11+
verify.quickInfoAt("Hebrew",'(enum member) Demo.Hebrew = "תפוח"');
12+
verify.quickInfoAt("Chinese", '(enum member) Demo.Chinese = "苹果"');
13+
verify.quickInfoAt("Japanese",'(enum member) Demo.Japanese = "りんご"');

0 commit comments

Comments
 (0)