Fix #442: (es3, es5, es6+) Show compiler errors for conflicting properties.

Author: about-code

src/compiler/checker.ts

@@ -14794,11 +14794,13 @@ namespace ts {
                             error(memberNameNode, message, memberName, className);
                         }
                         else if ((
+                            memberName === "name" ||
+                            memberName === "length" ||
                             memberName === "caller" ||
-                            memberName === "arguments" ) &&
+                            memberName === "arguments") &&
                             isMethod === false
                         ) {
-                           error(memberNameNode, message, memberName, className);
+                            error(memberNameNode, message, memberName, className);
                         }
                     }
                 }

tests/baselines/reference/staticPropertyNameConflictsEs6.errors.txt

@@ -1,26 +1,32 @@
+tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflictsEs6.ts(4,12): error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'StaticName'.
+tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflictsEs6.ts(15,12): error TS2699: Static property 'length' conflicts with built-in property 'Function.length' of constructor function 'StaticLength'.
 tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflictsEs6.ts(26,12): error TS2699: Static property 'prototype' conflicts with built-in property 'Function.prototype' of constructor function 'StaticPrototype'.
 tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflictsEs6.ts(31,12): error TS2300: Duplicate identifier 'prototype'.
 tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflictsEs6.ts(31,12): error TS2699: Static property 'prototype' conflicts with built-in property 'Function.prototype' of constructor function 'StaticPrototypeFn'.
 tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflictsEs6.ts(37,12): error TS2699: Static property 'caller' conflicts with built-in property 'Function.caller' of constructor function 'StaticCaller'.
 tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflictsEs6.ts(48,12): error TS2699: Static property 'arguments' conflicts with built-in property 'Function.arguments' of constructor function 'StaticArguments'.
 
 
-==== tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflictsEs6.ts (5 errors) ====
+==== tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflictsEs6.ts (7 errors) ====
 
 
     class StaticName {
-        static name: number; // ok
+        static name: number; // error
+               ~~~~
+!!! error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'StaticName'.
         name: string; // ok
     }
 
     class StaticNameFn {
-        static name() {} // ok
+        static name() {}  // ok
         name() {} // ok
     }
 
 
     class StaticLength {
-        static length: number; // ok
+        static length: number;  // error
+               ~~~~~~
+!!! error TS2699: Static property 'length' conflicts with built-in property 'Function.length' of constructor function 'StaticLength'.
         length: string; // ok
     }
 

tests/baselines/reference/staticPropertyNameConflictsEs6.js

@@ -2,18 +2,18 @@
 
 
 class StaticName {
-    static name: number; // ok
+    static name: number; // error
     name: string; // ok
 }
 
 class StaticNameFn {
-    static name() {} // ok
+    static name() {}  // ok
     name() {} // ok
 }
 
 
 class StaticLength {
-    static length: number; // ok
+    static length: number;  // error
     length: string; // ok
 }
 

tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflictsEs6.ts

@@ -2,18 +2,18 @@
 
 
 class StaticName {
-    static name: number; // ok
+    static name: number; // error
     name: string; // ok
 }
 
 class StaticNameFn {
-    static name() {} // ok
+    static name() {}  // ok
     name() {} // ok
 }
 
 
 class StaticLength {
-    static length: number; // ok
+    static length: number;  // error
     length: string; // ok
 }