Merge branch 'master' of https://github.com/Microsoft/TypeScript into feature/eslint

Author: a-tarasyuk

src/compiler/binder.ts

@@ -778,7 +778,7 @@ namespace ts {
         function isNarrowableReference(expr: Expression): boolean {
             return expr.kind === SyntaxKind.Identifier || expr.kind === SyntaxKind.ThisKeyword || expr.kind === SyntaxKind.SuperKeyword ||
                 (isPropertyAccessExpression(expr) || isNonNullExpression(expr) || isParenthesizedExpression(expr)) && isNarrowableReference(expr.expression) ||
-                isElementAccessExpression(expr) && expr.argumentExpression &&
+                isElementAccessExpression(expr) &&
                 (isStringLiteral(expr.argumentExpression) || isNumericLiteral(expr.argumentExpression)) &&
                 isNarrowableReference(expr.expression);
         }

src/compiler/checker.ts

@@ -459,10 +459,6 @@
         "category": "Error",
         "code": 1149
     },
-    "'new T[]' cannot be used to create an array. Use 'new Array<T>()' instead.": {
-        "category": "Error",
-        "code": 1150
-    },
     "'const' declarations must be initialized.": {
         "category": "Error",
         "code": 1155

src/compiler/diagnosticMessages.json

@@ -5490,10 +5490,22 @@ namespace ts {
         }
 
         function parseDeclaration(): Statement {
+            const modifiers = lookAhead(() => (parseDecorators(), parseModifiers()));
+            // `parseListElement` attempted to get the reused node at this position,
+            // but the ambient context flag was not yet set, so the node appeared
+            // not reusable in that context.
+            const isAmbient = some(modifiers, isDeclareModifier);
+            if (isAmbient) {
+                const node = tryReuseAmbientDeclaration();
+                if (node) {
+                    return node;
+                }
+            }
+
             const node = <Statement>createNodeWithJSDoc(SyntaxKind.Unknown);
             node.decorators = parseDecorators();
             node.modifiers = parseModifiers();
-            if (some(node.modifiers, isDeclareModifier)) {
+            if (isAmbient) {
                 for (const m of node.modifiers!) {
                     m.flags |= NodeFlags.Ambient;
                 }
@@ -5504,6 +5516,15 @@ namespace ts {
             }
         }
 
+        function tryReuseAmbientDeclaration(): Statement | undefined {
+            return doInsideOfContext(NodeFlags.Ambient, () => {
+                const node = currentNode(parsingContext);
+                if (node) {
+                    return consumeNode(node) as Statement;
+                }
+            });
+        }
+
         function parseDeclarationWorker(node: Statement): Statement {
             switch (token()) {
                 case SyntaxKind.VarKeyword:

src/compiler/parser.ts

@@ -1142,7 +1142,7 @@ namespace ts {
             // If we change our policy of rechecking failed lookups on each program create,
             // we should adjust the value returned here.
             function moduleNameResolvesToAmbientModuleInNonModifiedFile(moduleName: string): boolean {
-                const resolutionToFile = getResolvedModule(oldSourceFile!, moduleName);
+                const resolutionToFile = getResolvedModule(oldSourceFile, moduleName);
                 const resolvedFile = resolutionToFile && oldProgram!.getSourceFile(resolutionToFile.resolvedFileName);
                 if (resolutionToFile && resolvedFile) {
                     // In the old program, we resolved to an ambient module that was in the same
@@ -1831,6 +1831,7 @@ namespace ts {
 
                     switch (parent.kind) {
                         case SyntaxKind.ClassDeclaration:
+                        case SyntaxKind.ClassExpression:
                         case SyntaxKind.MethodDeclaration:
                         case SyntaxKind.MethodSignature:
                         case SyntaxKind.Constructor:
@@ -1840,7 +1841,7 @@ namespace ts {
                         case SyntaxKind.FunctionDeclaration:
                         case SyntaxKind.ArrowFunction:
                             // Check type parameters
-                            if (nodes === (<ClassDeclaration | FunctionLikeDeclaration>parent).typeParameters) {
+                            if (nodes === (<ClassLikeDeclaration | FunctionLikeDeclaration>parent).typeParameters) {
                                 diagnostics.push(createDiagnosticForNodeArray(nodes, Diagnostics.type_parameter_declarations_can_only_be_used_in_a_ts_file));
                                 return;
                             }

src/compiler/program.ts

@@ -879,7 +879,7 @@ namespace ts {
 
         setText(text, start, length);
 
-        return {
+        const scanner: Scanner = {
             getStartPos: () => startPos,
             getTextPos: () => pos,
             getToken: () => token,
@@ -915,6 +915,17 @@ namespace ts {
             scanRange,
         };
 
+        if (Debug.isDebugging) {
+            Object.defineProperty(scanner, "__debugShowCurrentPositionInText", {
+                get: () => {
+                    const text = scanner.getText();
+                    return text.slice(0, scanner.getStartPos()) + "║" + text.slice(scanner.getStartPos());
+                },
+            });
+        }
+
+        return scanner;
+
         function error(message: DiagnosticMessage): void;
         function error(message: DiagnosticMessage, errPos: number, length: number): void;
         function error(message: DiagnosticMessage, errPos: number = pos, length?: number): void {

src/compiler/scanner.ts

@@ -3346,7 +3346,7 @@ namespace ts {
          * This should be called in a loop climbing parents of the symbol, so we'll get `N`.
          */
         /* @internal */ getAccessibleSymbolChain(symbol: Symbol, enclosingDeclaration: Node | undefined, meaning: SymbolFlags, useOnlyExternalAliasing: boolean): Symbol[] | undefined;
-        /* @internal */ getTypePredicateOfSignature(signature: Signature): TypePredicate;
+        /* @internal */ getTypePredicateOfSignature(signature: Signature): TypePredicate | undefined;
         /**
          * An external module with an 'export =' declaration resolves to the target of the 'export =' declaration,
          * and an external module with no 'export =' declaration resolves to the module itself.

src/compiler/types.ts

@@ -220,7 +220,7 @@ namespace ts {
         return node.end - node.pos;
     }
 
-    export function getResolvedModule(sourceFile: SourceFile, moduleNameText: string): ResolvedModuleFull | undefined {
+    export function getResolvedModule(sourceFile: SourceFile | undefined, moduleNameText: string): ResolvedModuleFull | undefined {
         return sourceFile && sourceFile.resolvedModules && sourceFile.resolvedModules.get(moduleNameText);
     }
 

src/compiler/utilities.ts

@@ -110,7 +110,7 @@ interface ReadonlyArray<T> {
      * @param depth The maximum recursion depth
      */
     flat<U>(depth?: number): any[];
-  }
+}
 
 interface Array<T> {
 

src/lib/es2019.array.d.ts

@@ -1094,7 +1094,7 @@ interface ReadonlyArray<T> {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): T[];
     /**
@@ -1230,7 +1230,7 @@ interface Array<T> {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): T[];
     /**
@@ -1860,7 +1860,7 @@ interface Int8Array {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): Int8Array;
 
@@ -1887,7 +1887,7 @@ interface Int8Array {
      * @param begin The index of the beginning of the array.
      * @param end The index of the end of the array.
      */
-    subarray(begin: number, end?: number): Int8Array;
+    subarray(begin?: number, end?: number): Int8Array;
 
     /**
      * Converts a number to a string by using the current locale.
@@ -2135,7 +2135,7 @@ interface Uint8Array {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): Uint8Array;
 
@@ -2162,7 +2162,7 @@ interface Uint8Array {
      * @param begin The index of the beginning of the array.
      * @param end The index of the end of the array.
      */
-    subarray(begin: number, end?: number): Uint8Array;
+    subarray(begin?: number, end?: number): Uint8Array;
 
     /**
      * Converts a number to a string by using the current locale.
@@ -2410,7 +2410,7 @@ interface Uint8ClampedArray {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): Uint8ClampedArray;
 
@@ -2437,7 +2437,7 @@ interface Uint8ClampedArray {
      * @param begin The index of the beginning of the array.
      * @param end The index of the end of the array.
      */
-    subarray(begin: number, end?: number): Uint8ClampedArray;
+    subarray(begin?: number, end?: number): Uint8ClampedArray;
 
     /**
      * Converts a number to a string by using the current locale.
@@ -2683,7 +2683,7 @@ interface Int16Array {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): Int16Array;
 
@@ -2710,7 +2710,7 @@ interface Int16Array {
      * @param begin The index of the beginning of the array.
      * @param end The index of the end of the array.
      */
-    subarray(begin: number, end?: number): Int16Array;
+    subarray(begin?: number, end?: number): Int16Array;
 
     /**
      * Converts a number to a string by using the current locale.
@@ -2959,7 +2959,7 @@ interface Uint16Array {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): Uint16Array;
 
@@ -2986,7 +2986,7 @@ interface Uint16Array {
      * @param begin The index of the beginning of the array.
      * @param end The index of the end of the array.
      */
-    subarray(begin: number, end?: number): Uint16Array;
+    subarray(begin?: number, end?: number): Uint16Array;
 
     /**
      * Converts a number to a string by using the current locale.
@@ -3234,7 +3234,7 @@ interface Int32Array {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): Int32Array;
 
@@ -3261,7 +3261,7 @@ interface Int32Array {
      * @param begin The index of the beginning of the array.
      * @param end The index of the end of the array.
      */
-    subarray(begin: number, end?: number): Int32Array;
+    subarray(begin?: number, end?: number): Int32Array;
 
     /**
      * Converts a number to a string by using the current locale.
@@ -3508,7 +3508,7 @@ interface Uint32Array {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): Uint32Array;
 
@@ -3535,7 +3535,7 @@ interface Uint32Array {
      * @param begin The index of the beginning of the array.
      * @param end The index of the end of the array.
      */
-    subarray(begin: number, end?: number): Uint32Array;
+    subarray(begin?: number, end?: number): Uint32Array;
 
     /**
      * Converts a number to a string by using the current locale.
@@ -3783,7 +3783,7 @@ interface Float32Array {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): Float32Array;
 
@@ -3810,7 +3810,7 @@ interface Float32Array {
      * @param begin The index of the beginning of the array.
      * @param end The index of the end of the array.
      */
-    subarray(begin: number, end?: number): Float32Array;
+    subarray(begin?: number, end?: number): Float32Array;
 
     /**
      * Converts a number to a string by using the current locale.
@@ -4059,7 +4059,7 @@ interface Float64Array {
     /**
      * Returns a section of an array.
      * @param start The beginning of the specified portion of the array.
-     * @param end The end of the specified portion of the array.
+     * @param end The end of the specified portion of the array. This is exclusive of the element at the index 'end'.
      */
     slice(start?: number, end?: number): Float64Array;
 
@@ -4081,21 +4081,12 @@ interface Float64Array {
     sort(compareFn?: (a: number, b: number) => number): this;
 
     /**
-     * Gets a new Float64Array view of the ArrayBuffer store for this array, referencing the elements
      * at begin, inclusive, up to end, exclusive.
      * @param begin The index of the beginning of the array.
      * @param end The index of the end of the array.
      */
-    subarray(begin: number, end?: number): Float64Array;
+    subarray(begin?: number, end?: number): Float64Array;
 
-    /**
-     * Converts a number to a string by using the current locale.
-     */
-    toLocaleString(): string;
-
-    /**
-     * Returns a string representation of an array.
-     */
     toString(): string;
 
     [index: number]: number;