Skip to content

Commit bb7dea1

Browse files
author
Kanchalai Tanglertsampan
committed
Address code review: fix comment
1 parent 56f31c3 commit bb7dea1

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

tests/baselines/reference/tsxAttributeResolution3.errors.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ tests/cases/conformance/jsx/file.tsx(35,8): error TS2322: Type '{ x: string; y:
5454
!!! error TS2322: Types of property 'x' are incompatible.
5555
!!! error TS2322: Type 'number' is not assignable to type 'string'.
5656

57-
// OK
57+
// Error
5858
var obj6 = { x: 'ok', y: 32, extra: 100 };
5959
<test1 {...obj6} />
6060
~~~~~~~~~

tests/baselines/reference/tsxAttributeResolution3.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ var obj4 = { x: 32, y: 32 };
3131
var obj5 = { x: 32, y: 32 };
3232
<test1 x="ok" {...obj5} />
3333

34-
// OK
34+
// Error
3535
var obj6 = { x: 'ok', y: 32, extra: 100 };
3636
<test1 {...obj6} />
3737

@@ -56,7 +56,7 @@ var obj4 = { x: 32, y: 32 };
5656
// Error
5757
var obj5 = { x: 32, y: 32 };
5858
<test1 x="ok" {...obj5}/>;
59-
// OK
59+
// Error
6060
var obj6 = { x: 'ok', y: 32, extra: 100 };
6161
<test1 {...obj6}/>;
6262
// OK (spread override)

tests/cases/conformance/jsx/tsxAttributeResolution3.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ var obj4 = { x: 32, y: 32 };
3232
var obj5 = { x: 32, y: 32 };
3333
<test1 x="ok" {...obj5} />
3434

35-
// OK
35+
// Error
3636
var obj6 = { x: 'ok', y: 32, extra: 100 };
3737
<test1 {...obj6} />
3838

0 commit comments

Comments
 (0)