Fix declaration emit of divergent accessors in JS classes (#58172)

Author: Andarist

src/compiler/checker.ts

@@ -9853,7 +9853,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                                         /*dotDotDotToken*/ undefined,
                                         paramSymbol ? parameterToParameterDeclarationName(paramSymbol, getEffectiveParameterDeclaration(paramSymbol), context) : "value",
                                         /*questionToken*/ undefined,
-                                        isPrivate ? undefined : serializeTypeForDeclaration(context, /*declaration*/ undefined, getTypeOfSymbol(p), p),
+                                        isPrivate ? undefined : serializeTypeForDeclaration(context, /*declaration*/ undefined, getWriteTypeOfSymbol(p), p),
                                     )],
                                     /*body*/ undefined,
                                 ),

tests/baselines/reference/declarationEmitClassAccessorsJs1.js

@@ -0,0 +1,34 @@
+//// [tests/cases/compiler/declarationEmitClassAccessorsJs1.ts] ////
+
+//// [index.js]
+// https://github.com/microsoft/TypeScript/issues/58167
+
+export class VFile {
+  /**
+   * @returns {string}
+   */
+  get path() {
+    return ''
+  }
+
+  /**
+   * @param {URL | string} path
+   */
+  set path(path) {
+  }
+}
+
+
+
+
+//// [index.d.ts]
+export class VFile {
+    /**
+     * @param {URL | string} path
+     */
+    set path(path: string | URL);
+    /**
+     * @returns {string}
+     */
+    get path(): string;
+}

tests/baselines/reference/declarationEmitClassAccessorsJs1.symbols

@@ -0,0 +1,26 @@
+//// [tests/cases/compiler/declarationEmitClassAccessorsJs1.ts] ////
+
+=== index.js ===
+// https://github.com/microsoft/TypeScript/issues/58167
+
+export class VFile {
+>VFile : Symbol(VFile, Decl(index.js, 0, 0))
+
+  /**
+   * @returns {string}
+   */
+  get path() {
+>path : Symbol(VFile.path, Decl(index.js, 2, 20), Decl(index.js, 8, 3))
+
+    return ''
+  }
+
+  /**
+   * @param {URL | string} path
+   */
+  set path(path) {
+>path : Symbol(VFile.path, Decl(index.js, 2, 20), Decl(index.js, 8, 3))
+>path : Symbol(path, Decl(index.js, 13, 11))
+  }
+}
+

tests/baselines/reference/declarationEmitClassAccessorsJs1.types

@@ -0,0 +1,32 @@
+//// [tests/cases/compiler/declarationEmitClassAccessorsJs1.ts] ////
+
+=== index.js ===
+// https://github.com/microsoft/TypeScript/issues/58167
+
+export class VFile {
+>VFile : VFile
+>      : ^^^^^
+
+  /**
+   * @returns {string}
+   */
+  get path() {
+>path : string
+>     : ^^^^^^
+
+    return ''
+>'' : ""
+>   : ^^
+  }
+
+  /**
+   * @param {URL | string} path
+   */
+  set path(path) {
+>path : string
+>     : ^^^^^^
+>path : string | URL
+>     : ^^^^^^^^^^^^
+  }
+}
+

tests/cases/compiler/declarationEmitClassAccessorsJs1.ts

@@ -0,0 +1,22 @@
+// @strict: true
+// @checkJs: true
+// @declaration: true
+// @emitDeclarationOnly: true
+// @filename: index.js
+
+// https://github.com/microsoft/TypeScript/issues/58167
+
+export class VFile {
+  /**
+   * @returns {string}
+   */
+  get path() {
+    return ''
+  }
+
+  /**
+   * @param {URL | string} path
+   */
+  set path(path) {
+  }
+}