Emit comments for expression statements

Author: sheetalkamat

src/compiler/emitter.ts

@@ -917,10 +917,12 @@ module ts {
 
             function emitExpressionStatement(node: ExpressionStatement) {
                 var isArrowExpression = node.expression.kind === SyntaxKind.ArrowFunction;
+                emitLeadingComments(node);
                 if (isArrowExpression) write("(");
                 emit(node.expression);
                 if (isArrowExpression) write(")");
                 write(";");
+                emitTrailingComments(node);
             }
 
             function emitIfStatement(node: IfStatement) {

tests/baselines/reference/aliasAssignments.js

@@ -23,6 +23,6 @@ exports.someClass = someClass;
 //// [aliasAssignments_1.js]
 var moduleA = require("aliasAssignments_moduleA");
 var x = moduleA;
-x = 1;
+x = 1; // Should be error
 var y = 1;
-y = moduleA;
+y = moduleA; // should be error

tests/baselines/reference/aliasOnMergedModuleInterface.js

@@ -24,5 +24,5 @@ var x: foo.A = foo.bar("hello"); // foo.A should be ok but foo.bar should be err
 //// [aliasOnMergedModuleInterface_0.js]
 //// [aliasOnMergedModuleInterface_1.js]
 var z;
-z.bar("hello");
+z.bar("hello"); // This should be ok
 var x = foo.bar("hello"); // foo.A should be ok but foo.bar should be error

tests/baselines/reference/aliasUsedAsNameValue.js

@@ -31,5 +31,6 @@ exports.b = b;
 var mod = require("aliasUsedAsNameValue_0");
 var b = require("aliasUsedAsNameValue_1");
 exports.a = function () {
+    //var x = mod.id; // TODO needed hack that mod is loaded
     b.b(mod);
 };

tests/baselines/reference/ambiguousCallsWhereReturnTypesAgree.js

@@ -35,7 +35,7 @@ var TestClass = (function () {
     TestClass.prototype.bar = function (x) {
     };
     TestClass.prototype.foo = function (x) {
-        this.bar(x);
+        this.bar(x); // should not error
     };
     return TestClass;
 })();

tests/baselines/reference/argumentsBindsToFunctionScopeArgumentList.js

@@ -7,5 +7,5 @@ function foo(a) {
 //// [argumentsBindsToFunctionScopeArgumentList.js]
 var arguments = 10;
 function foo(a) {
-    arguments = 10;
+    arguments = 10; /// This shouldnt be of type number and result in error.
 }

tests/baselines/reference/arithAssignTyping.js

@@ -20,15 +20,15 @@ var f = (function () {
     }
     return f;
 })();
-f += '';
-f += 1;
-f -= 1;
-f *= 1;
-f /= 1;
-f %= 1;
-f &= 1;
-f |= 1;
-f <<= 1;
-f >>= 1;
-f >>>= 1;
-f ^= 1;
+f += ''; // error
+f += 1; // error
+f -= 1; // error
+f *= 1; // error
+f /= 1; // error
+f %= 1; // error
+f &= 1; // error
+f |= 1; // error
+f <<= 1; // error
+f >>= 1; // error
+f >>>= 1; // error
+f ^= 1; // error

tests/baselines/reference/arrayAssignmentTest1.js

@@ -153,29 +153,32 @@ var i1_error = []; // should be an error - is
 var c1_error = []; // should be an error - is
 var c2_error = []; // should be an error - is
 var c3_error = []; // should be an error - is
-arr_any = arr_i1;
-arr_any = arr_c1;
-arr_any = arr_c2;
-arr_any = arr_c3;
-arr_i1 = arr_i1;
-arr_i1 = arr_c1;
-arr_i1 = arr_c2;
-arr_i1 = arr_c3;
-arr_c1 = arr_c1;
-arr_c1 = arr_c2;
-arr_c1 = arr_i1;
-arr_c1 = arr_c3;
-arr_c2 = arr_c2;
-arr_c2 = arr_c1;
-arr_c2 = arr_i1;
-arr_c2 = arr_c3;
-arr_c3 = arr_c2_2;
-arr_c3 = arr_c1_2;
-arr_c3 = arr_i1_2;
-arr_any = f1;
-arr_any = o1;
-arr_any = a1;
-arr_any = c1;
-arr_any = c2;
-arr_any = c3;
-arr_any = i1;
+arr_any = arr_i1; // should be ok - is
+arr_any = arr_c1; // should be ok - is
+arr_any = arr_c2; // should be ok - is
+arr_any = arr_c3; // should be ok - is
+arr_i1 = arr_i1; // should be ok - subtype relationship - is
+arr_i1 = arr_c1; // should be ok - subtype relationship - is
+arr_i1 = arr_c2; // should be ok - subtype relationship - is
+arr_i1 = arr_c3; // should be an error - is
+arr_c1 = arr_c1; // should be ok - subtype relationship - is
+arr_c1 = arr_c2; // should be ok - subtype relationship - is
+arr_c1 = arr_i1; // should be an error - is
+arr_c1 = arr_c3; // should be an error - is
+arr_c2 = arr_c2; // should be ok - subtype relationship - is
+arr_c2 = arr_c1; // should be an error - subtype relationship - is
+arr_c2 = arr_i1; // should be an error - subtype relationship - is
+arr_c2 = arr_c3; // should be an error - is
+// "clean up bug" occurs at this point
+// if you move these three expressions to another file, they raise an error
+// something to do with state from the above propagating forward?
+arr_c3 = arr_c2_2; // should be an error - is
+arr_c3 = arr_c1_2; // should be an error - is
+arr_c3 = arr_i1_2; // should be an error - is
+arr_any = f1; // should be an error - is
+arr_any = o1; // should be an error - is
+arr_any = a1; // should be ok - is
+arr_any = c1; // should be an error - is
+arr_any = c2; // should be an error - is
+arr_any = c3; // should be an error - is
+arr_any = i1; // should be an error - is

tests/baselines/reference/arrayAssignmentTest2.js

@@ -123,16 +123,17 @@ var arr_i1_2 = [];
 var arr_c1_2 = [];
 var arr_c2_2 = [];
 var arr_c3 = [];
-arr_c3 = arr_c2_2;
-arr_c3 = arr_c1_2;
-arr_c3 = arr_i1_2;
-arr_any = f1;
+// "clean up error" occurs at this point
+arr_c3 = arr_c2_2; // should be an error - is
+arr_c3 = arr_c1_2; // should be an error - is
+arr_c3 = arr_i1_2; // should be an error - is
+arr_any = f1; // should be an error - is
 arr_any = function () {
     return null;
-};
-arr_any = o1;
-arr_any = a1;
-arr_any = c1;
-arr_any = c2;
-arr_any = c3;
-arr_any = i1;
+}; // should be an error - is
+arr_any = o1; // should be an error - is
+arr_any = a1; // should be ok - is
+arr_any = c1; // should be an error - is
+arr_any = c2; // should be an error - is
+arr_any = c3; // should be an error - is
+arr_any = i1; // should be an error - is

tests/baselines/reference/arrayAssignmentTest4.js

@@ -51,5 +51,5 @@ var o1 = { one: 1 };
 var arr_any = [];
 arr_any = function () {
     return null;
-};
-arr_any = c3;
+}; // should be an error - is
+arr_any = c3; // should be an error - is