Skip to content

Commit c4fdcca

Browse files
committed
Emit pinned/tripleslash reference comments of elided module declaration
Fixes #501
1 parent 5353128 commit c4fdcca

File tree

4 files changed

+29
-4
lines changed

4 files changed

+29
-4
lines changed

src/compiler/emitter.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1761,7 +1761,10 @@ module ts {
17611761
}
17621762

17631763
function emitModuleDeclaration(node: ModuleDeclaration) {
1764-
if (!isInstantiated(node)) return;
1764+
if (!isInstantiated(node)) {
1765+
return emitPinnedOrTripleSlashComments(node);
1766+
}
1767+
17651768
emitLeadingComments(node);
17661769
if (!(node.flags & NodeFlags.Export)) {
17671770
emitStart(node);
Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,20 @@
1-
//// [commentOnElidedModule1.ts]
1+
//// [tests/cases/compiler/commentOnElidedModule1.ts] ////
2+
3+
//// [a.ts]
24
/*! Keep this pinned comment */
35
module ElidedModule {
46
}
57

68
// Don't keep this comment.
79
module ElidedModule2 {
10+
}
11+
12+
//// [b.ts]
13+
///<reference path="a.ts"/>
14+
module ElidedModule3 {
815
}
916

10-
//// [commentOnElidedModule1.js]
17+
//// [a.js]
18+
/*! Keep this pinned comment */
19+
//// [b.js]
20+
///<reference path="a.ts"/>

tests/baselines/reference/commentOnElidedModule1.types

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
=== tests/cases/compiler/commentOnElidedModule1.ts ===
1+
=== tests/cases/compiler/b.ts ===
2+
///<reference path="a.ts"/>
3+
module ElidedModule3 {
4+
>ElidedModule3 : ElidedModule3
5+
}
6+
=== tests/cases/compiler/a.ts ===
27
/*! Keep this pinned comment */
38
module ElidedModule {
49
>ElidedModule : ElidedModule
@@ -8,3 +13,4 @@ module ElidedModule {
813
module ElidedModule2 {
914
>ElidedModule2 : ElidedModule2
1015
}
16+
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
1+
//@filename: a.ts
12
/*! Keep this pinned comment */
23
module ElidedModule {
34
}
45

56
// Don't keep this comment.
67
module ElidedModule2 {
8+
}
9+
10+
//@filename: b.ts
11+
///<reference path="a.ts"/>
12+
module ElidedModule3 {
713
}

0 commit comments

Comments
 (0)