Always use verify.completions when testing completions (#28137)

Author: Andy

src/harness/fourslash.ts

@@ -12,4 +12,4 @@
 goTo.marker();
 var text = "this.children = ch";
 edit.insert(text);
-verify.completionListContains("children", "(parameter) children: string[]");
+verify.completions({ includes: { name: "children", text: "(parameter) children: string[]" }, isNewIdentifierLocation: true });

tests/cases/fourslash/argumentsAreAvailableAfterEditsAtEndOfFunction.ts

@@ -4,5 +4,5 @@
 //// var x;
 //// var y = x as /**/
 
-goTo.marker();
-verify.completionListContains('T');
+verify.completions({ marker: "", includes: "T" });
+

tests/cases/fourslash/asOperatorCompletion.ts

@@ -6,8 +6,6 @@
 ////var r = new c5b();
 ////r./*2*/
 
-goTo.marker('1');
-verify.not.completionListContains('y', 'var y: number');
+verify.completions({ marker: "1", excludes: ["y"] });
 edit.backspace(4);
-goTo.marker('2');
-verify.completionListContains('foo', '(method) c5b.foo(): void');
+verify.completions({ marker: "2", exact: { name: "foo", text: "(method) c5b.foo(): void" } });

tests/cases/fourslash/augmentedTypesClass2.ts

@@ -8,6 +8,4 @@ verify.quickInfos({
     1: "class c5b\nnamespace c5b",
     2: "class c5b\nnamespace c5b"
 });
-
-goTo.marker('3');
-verify.completionListContains("c5b", "class c5b\nnamespace c5b");
+verify.completions({ marker: "3", includes: { name: "c5b", text: "class c5b\nnamespace c5b" }})

tests/cases/fourslash/augmentedTypesClass3.ts

@@ -7,8 +7,5 @@
 ////var x: m1c./*1*/;
 ////var /*2*/r = m1c;
 
-goTo.marker('1');
-verify.completionListContains('I');
-verify.not.completionListContains('foo');
-
+verify.completions({ marker: "1", exact: "I" });
 verify.quickInfoAt("2", "var r: number");

tests/cases/fourslash/augmentedTypesModule1.ts

@@ -7,11 +7,10 @@
 
 verify.quickInfoAt("11", "function m2f(x: number): void\nnamespace m2f");
 
-goTo.marker('1');
-verify.completionListContains('I');
+verify.completions({ marker: "1", exact: "I" });
 
 edit.insert('I.');
-verify.not.completionListContains('foo');
+verify.completions({ exact: undefined });
 edit.backspace(1);
 
 verify.quickInfoAt("2", "var r: (x: number) => void");

tests/cases/fourslash/augmentedTypesModule2.ts

@@ -5,11 +5,10 @@
 ////var x: m2g./*1*/;
 ////var /*2*/r = m2g/*3*/;
 
-goTo.marker('1');
-verify.completionListContains('C');
+verify.completions({ marker: "1", exact: "C" });
 
 edit.insert('C.');
-verify.not.completionListContains('foo');
+verify.completions({ exact: undefined });
 edit.backspace(1);
 
 verify.quickInfoAt("2", "var r: typeof m2g");

tests/cases/fourslash/augmentedTypesModule3.ts

@@ -1,19 +1,17 @@
 /// <reference path='fourslash.ts'/>
 
-////module m3d { export var y = 2; } 
+////module m3d { export var y = 2; }
 ////declare class m3d { foo(): void }
 ////var /*1*/r = new m3d();
 ////r./*2*/
 ////var /*4*/r2 = m3d./*3*/
 
 verify.quickInfoAt("1", "var r: m3d");
 
-goTo.marker('2');
-verify.completionListContains('foo');
+verify.completions({ marker: "2", exact: "foo" });
 edit.insert('foo();');
 
-goTo.marker('3');
-verify.completionListContains('y');
+verify.completions({ marker: "3", includes: "y" });
 edit.insert('y;');
 
 verify.quickInfoAt("4", "var r2: number");

tests/cases/fourslash/augmentedTypesModule4.ts

@@ -1,20 +1,18 @@
 /// <reference path='fourslash.ts'/>
 
-////declare class m3e { foo(): void } 
+////declare class m3e { foo(): void }
 ////module m3e { export var y = 2; }
 ////var /*1*/r = new m3e();
 ////r./*2*/
 ////var /*4*/r2 = m3e./*3*/
 
 verify.quickInfoAt("1", "var r: m3e");
 
-goTo.marker('2');
-verify.completionListContains('foo');
+verify.completions({ marker: "2", exact: "foo" });
 
 edit.insert('foo();');
 
-goTo.marker('3');
-verify.completionListContains('y');
+verify.completions({ marker: "3", includes: "y" });
 edit.insert('y;');
 
 verify.quickInfoAt("4", "var r2: number");