Skip to content

Commit cc4a3a8

Browse files
author
Andy Hanson
committed
Add check for undefined declarations
1 parent 36eb1ce commit cc4a3a8

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/services/goToDefinition.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,11 +198,11 @@ namespace ts.GoToDefinition {
198198
return false;
199199
}
200200

201-
function tryAddSignature(signatureDeclarations: Declaration[], selectConstructors: boolean, symbolKind: string, symbolName: string, containerName: string, result: DefinitionInfo[]) {
201+
function tryAddSignature(signatureDeclarations: Declaration[] | undefined, selectConstructors: boolean, symbolKind: string, symbolName: string, containerName: string, result: DefinitionInfo[]) {
202202
const declarations: Declaration[] = [];
203203
let definition: Declaration | undefined;
204204

205-
for (const d of signatureDeclarations) {
205+
if (signatureDeclarations) for (const d of signatureDeclarations) {
206206
if (selectConstructors ? d.kind === SyntaxKind.Constructor : isSignatureDeclaration(d)) {
207207
declarations.push(d);
208208
if ((<FunctionLikeDeclaration>d).body) definition = d;
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
/// <reference path='fourslash.ts' />
2+
3+
// @Filename: /node_modules/foo/index.js
4+
////not read
5+
6+
// @Filename: /a.ts
7+
////import { f } from "foo";
8+
/////**/f();
9+
10+
verify.goToDefinition("", []);

0 commit comments

Comments
 (0)