Skip to content

Commit d353fcd

Browse files
committed
remove fullTypeCheck flag as it may lead to missing errors if we make any requests with fullTypeCheck=false and we cache any result
1 parent ccaf904 commit d353fcd

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/compiler/checker.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ module ts {
5858

5959
var stringLiteralTypes: Map<StringLiteralType> = {};
6060

61-
var fullTypeCheck = false;
6261
var emitExtends = false;
6362

6463
var mergedSymbols: Symbol[] = [];
@@ -4356,7 +4355,7 @@ module ts {
43564355
}
43574356
}
43584357
}
4359-
if (fullTypeCheck && !(links.flags & NodeCheckFlags.TypeChecked)) {
4358+
if (!(links.flags & NodeCheckFlags.TypeChecked)) {
43604359
checkSignatureDeclaration(node);
43614360
if (node.type) {
43624361
checkIfNonVoidFunctionHasReturnExpressionsOrSingleThrowStatment(node, getTypeFromTypeNode(node.type));
@@ -6254,7 +6253,6 @@ module ts {
62546253
function checkSourceFile(node: SourceFile) {
62556254
var links = getNodeLinks(node);
62566255
if (!(links.flags & NodeCheckFlags.TypeChecked)) {
6257-
fullTypeCheck = true;
62586256
emitExtends = false;
62596257
potentialThisCollisions.length = 0;
62606258
forEach(node.statements, checkSourceElement);
@@ -6271,7 +6269,6 @@ module ts {
62716269
}
62726270
if (emitExtends) links.flags |= NodeCheckFlags.EmitExtends;
62736271
links.flags |= NodeCheckFlags.TypeChecked;
6274-
fullTypeCheck = false;
62756272
}
62766273
}
62776274

0 commit comments

Comments
 (0)