Skip to content

Commit d42c5ba

Browse files
committed
Begin packaging of signature help items
1 parent 67516a1 commit d42c5ba

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

src/services/services.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3542,6 +3542,15 @@ module ts {
35423542
return undefined;
35433543
}
35443544

3545+
function getSignatureHelpItemsFromCandidateInfo(candidates: Signature[], bestSignature: Signature): SignatureHelpItems {
3546+
var items = map(candidates, candidateSignature => {
3547+
return new SignatureHelpItem(false, "", "", "", new Array<SignatureHelpParameter>(candidateSignature.parameters.length), "");
3548+
});
3549+
var selectedItemIndex = candidates.indexOf(bestSignature);
3550+
Debug.assert(selectedItemIndex >= 0);
3551+
return new SignatureHelpItems(items, undefined, selectedItemIndex);
3552+
}
3553+
35453554
synchronizeHostData();
35463555

35473556
// Decide whether to show signature help
@@ -3556,7 +3565,7 @@ module ts {
35563565
var candidates = <Signature[]>[];
35573566
var resolvedSignature = typeInfoResolver.getResolvedSignature(call, candidates);
35583567
return candidates.length
3559-
? new SignatureHelpItems(new Array<SignatureHelpItem>(candidates.length), undefined, undefined)
3568+
? getSignatureHelpItemsFromCandidateInfo(candidates, resolvedSignature)
35603569
: undefined;
35613570
}
35623571

tests/cases/fourslash/fourslash.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ module FourSlashInterface {
295295
}
296296

297297
public currentSignatureParamterCountIs(expected: number) {
298-
// FourSlash.currentTestState.verifyCurrentSignatureHelpParameterCount(expected);
298+
FourSlash.currentTestState.verifyCurrentSignatureHelpParameterCount(expected);
299299
}
300300

301301
public currentSignatureTypeParamterCountIs(expected: number) {

0 commit comments

Comments
 (0)