Skip to content

Commit deaf8e4

Browse files
committed
Addressing CR feedback.
1 parent f4d3c1c commit deaf8e4

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/compiler/checker.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1800,7 +1800,6 @@ module ts {
18001800
function resolveAnonymousTypeMembers(type: ObjectType) {
18011801
var symbol = type.symbol;
18021802
if (symbol.flags & SymbolFlags.TypeLiteral) {
1803-
// Type literal
18041803
var members = symbol.members;
18051804
var callSignatures = getSignaturesOfSymbol(members["__call"]);
18061805
var constructSignatures = getSignaturesOfSymbol(members["__new"]);
@@ -1810,8 +1809,8 @@ module ts {
18101809
else {
18111810
// Combinations of function, class, enum and module
18121811
var members = emptySymbols;
1813-
var callSignatures = <Signature[]>emptyArray;
1814-
var constructSignatures = <Signature[]>emptyArray;
1812+
var callSignatures: Signature[] = emptyArray;
1813+
var constructSignatures: Signature[] = emptyArray;
18151814
if (symbol.flags & SymbolFlags.HasExports) {
18161815
members = symbol.exports;
18171816
}
@@ -1821,13 +1820,16 @@ module ts {
18211820
if (symbol.flags & SymbolFlags.Class) {
18221821
var classType = getDeclaredTypeOfClass(symbol);
18231822
constructSignatures = getSignaturesOfSymbol(symbol.members["__constructor"]);
1824-
if (!constructSignatures.length) constructSignatures = getDefaultConstructSignatures(classType);
1823+
if (!constructSignatures.length) {
1824+
constructSignatures = getDefaultConstructSignatures(classType);
1825+
}
18251826
if (classType.baseTypes.length) {
1826-
var members = createSymbolTable(getNamedMembers(members));
1827+
members = createSymbolTable(getNamedMembers(members));
18271828
addInheritedMembers(members, getPropertiesOfType(getTypeOfSymbol(classType.baseTypes[0].symbol)));
18281829
}
18291830
}
1830-
var numberIndexType = (symbol.flags & SymbolFlags.Enum) ? <Type>stringType : undefined;
1831+
var stringIndexType: Type = undefined;
1832+
var numberIndexType: Type = (symbol.flags & SymbolFlags.Enum) ? stringType : undefined;
18311833
}
18321834
setObjectTypeMembers(type, members, callSignatures, constructSignatures, stringIndexType, numberIndexType);
18331835
}

0 commit comments

Comments
 (0)