Skip to content

Commit e39d577

Browse files
authored
Update Node.js core modules (#62201)
1 parent 605d7ee commit e39d577

File tree

2 files changed

+17
-51
lines changed

2 files changed

+17
-51
lines changed

src/compiler/utilities.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12026,7 +12026,7 @@ export function isSideEffectImport(node: Node): boolean {
1202612026
return !!ancestor && !ancestor.importClause;
1202712027
}
1202812028

12029-
// require('module').builtinModules.filter(x => !x.startsWith('_'))
12029+
// require('module').builtinModules.filter(x => !x.match(/^(?:_|node:)/))
1203012030
const unprefixedNodeCoreModulesList = [
1203112031
"assert",
1203212032
"assert/strict",
@@ -12069,7 +12069,6 @@ const unprefixedNodeCoreModulesList = [
1206912069
"stream/web",
1207012070
"string_decoder",
1207112071
"sys",
12072-
"test/mock_loader",
1207312072
"timers",
1207412073
"timers/promises",
1207512074
"tls",
@@ -12088,11 +12087,10 @@ const unprefixedNodeCoreModulesList = [
1208812087
/** @internal */
1208912088
export const unprefixedNodeCoreModules: Set<string> = new Set(unprefixedNodeCoreModulesList);
1209012089

12091-
// await fetch('https://nodejs.org/docs/latest/api/all.json').then(r => r.text()).then(t =>
12092-
// new Set(t.match(/(?<=')node:.+?(?=')/g))
12093-
// .difference(new Set(require('module').builtinModules.map(x => `node:${x}`))))
12090+
// require('module').builtinModules.filter(x => x.startsWith('node:'))
1209412091
/** @internal */
1209512092
export const exclusivelyPrefixedNodeCoreModules: Set<string> = new Set([
12093+
"node:quic",
1209612094
"node:sea",
1209712095
"node:sqlite",
1209812096
"node:test",

tests/baselines/reference/tsserver/typingsInstaller/discover-typings-should-return-node-for-core-modules.js

Lines changed: 14 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1330,38 +1330,6 @@ TI:: [hh:mm:ss:mss] Finished typings discovery:
13301330
]
13311331
}
13321332

1333-
ts.JsTyping.discoverTypings::
1334-
{
1335-
"fileNames": [
1336-
"/home/src/projects/project/app.js"
1337-
],
1338-
"projectRootPath": "/home/src/projects/project",
1339-
"safeList": {},
1340-
"packageNameToTypingLocation": {},
1341-
"typeAcquisition": {
1342-
"enable": true
1343-
},
1344-
"unresolvedImports": [
1345-
"test/mock_loader",
1346-
"somename"
1347-
],
1348-
"typesRegistry": {},
1349-
"compilerOptions": {}
1350-
}
1351-
TI:: [hh:mm:ss:mss] Inferred typings from unresolved imports: ["node","somename"]
1352-
TI:: [hh:mm:ss:mss] Finished typings discovery:
1353-
{
1354-
"cachedTypingPaths": [],
1355-
"newTypingNames": [
1356-
"node",
1357-
"somename"
1358-
],
1359-
"filesToWatch": [
1360-
"/home/src/projects/project/bower_components",
1361-
"/home/src/projects/project/node_modules"
1362-
]
1363-
}
1364-
13651333
ts.JsTyping.discoverTypings::
13661334
{
13671335
"fileNames": [
@@ -3102,7 +3070,7 @@ ts.JsTyping.discoverTypings::
31023070
"enable": true
31033071
},
31043072
"unresolvedImports": [
3105-
"node:test/mock_loader",
3073+
"node:timers",
31063074
"somename"
31073075
],
31083076
"typesRegistry": {},
@@ -3134,7 +3102,7 @@ ts.JsTyping.discoverTypings::
31343102
"enable": true
31353103
},
31363104
"unresolvedImports": [
3137-
"node:timers",
3105+
"node:timers/promises",
31383106
"somename"
31393107
],
31403108
"typesRegistry": {},
@@ -3166,7 +3134,7 @@ ts.JsTyping.discoverTypings::
31663134
"enable": true
31673135
},
31683136
"unresolvedImports": [
3169-
"node:timers/promises",
3137+
"node:tls",
31703138
"somename"
31713139
],
31723140
"typesRegistry": {},
@@ -3198,7 +3166,7 @@ ts.JsTyping.discoverTypings::
31983166
"enable": true
31993167
},
32003168
"unresolvedImports": [
3201-
"node:tls",
3169+
"node:trace_events",
32023170
"somename"
32033171
],
32043172
"typesRegistry": {},
@@ -3230,7 +3198,7 @@ ts.JsTyping.discoverTypings::
32303198
"enable": true
32313199
},
32323200
"unresolvedImports": [
3233-
"node:trace_events",
3201+
"node:tty",
32343202
"somename"
32353203
],
32363204
"typesRegistry": {},
@@ -3262,7 +3230,7 @@ ts.JsTyping.discoverTypings::
32623230
"enable": true
32633231
},
32643232
"unresolvedImports": [
3265-
"node:tty",
3233+
"node:url",
32663234
"somename"
32673235
],
32683236
"typesRegistry": {},
@@ -3294,7 +3262,7 @@ ts.JsTyping.discoverTypings::
32943262
"enable": true
32953263
},
32963264
"unresolvedImports": [
3297-
"node:url",
3265+
"node:util",
32983266
"somename"
32993267
],
33003268
"typesRegistry": {},
@@ -3326,7 +3294,7 @@ ts.JsTyping.discoverTypings::
33263294
"enable": true
33273295
},
33283296
"unresolvedImports": [
3329-
"node:util",
3297+
"node:util/types",
33303298
"somename"
33313299
],
33323300
"typesRegistry": {},
@@ -3358,7 +3326,7 @@ ts.JsTyping.discoverTypings::
33583326
"enable": true
33593327
},
33603328
"unresolvedImports": [
3361-
"node:util/types",
3329+
"node:v8",
33623330
"somename"
33633331
],
33643332
"typesRegistry": {},
@@ -3390,7 +3358,7 @@ ts.JsTyping.discoverTypings::
33903358
"enable": true
33913359
},
33923360
"unresolvedImports": [
3393-
"node:v8",
3361+
"node:vm",
33943362
"somename"
33953363
],
33963364
"typesRegistry": {},
@@ -3422,7 +3390,7 @@ ts.JsTyping.discoverTypings::
34223390
"enable": true
34233391
},
34243392
"unresolvedImports": [
3425-
"node:vm",
3393+
"node:wasi",
34263394
"somename"
34273395
],
34283396
"typesRegistry": {},
@@ -3454,7 +3422,7 @@ ts.JsTyping.discoverTypings::
34543422
"enable": true
34553423
},
34563424
"unresolvedImports": [
3457-
"node:wasi",
3425+
"node:worker_threads",
34583426
"somename"
34593427
],
34603428
"typesRegistry": {},
@@ -3486,7 +3454,7 @@ ts.JsTyping.discoverTypings::
34863454
"enable": true
34873455
},
34883456
"unresolvedImports": [
3489-
"node:worker_threads",
3457+
"node:zlib",
34903458
"somename"
34913459
],
34923460
"typesRegistry": {},
@@ -3518,7 +3486,7 @@ ts.JsTyping.discoverTypings::
35183486
"enable": true
35193487
},
35203488
"unresolvedImports": [
3521-
"node:zlib",
3489+
"node:quic",
35223490
"somename"
35233491
],
35243492
"typesRegistry": {},

0 commit comments

Comments
 (0)