Fix bad JSON syntax in tests, use JSON.parse first for perf (#61901)

Author: jakebailey

src/compiler/utilities.ts

@@ -7692,9 +7692,18 @@ export function base64decode(host: { base64decode?(input: string): string; } | u
 export function readJsonOrUndefined(path: string, hostOrText: { readFile(fileName: string): string | undefined; } | string): object | undefined {
     const jsonText = isString(hostOrText) ? hostOrText : hostOrText.readFile(path);
     if (!jsonText) return undefined;
-    // gracefully handle if readFile fails or returns not JSON
-    const result = parseConfigFileTextToJson(path, jsonText);
-    return !result.error ? result.config : undefined;
+    // Try strictly parsing first, then fall back to our (slower)
+    // parser that is resilient to comments/trailing commas.
+    // package.json files should never have these, but we
+    // have no way to communicate these issues in the first place.
+    let result = tryParseJson(jsonText);
+    if (result === undefined) {
+        const looseResult = parseConfigFileTextToJson(path, jsonText);
+        if (!looseResult.error) {
+            result = looseResult.config;
+        }
+    }
+    return result;
 }
 
 /** @internal */

tests/baselines/reference/conditionalExportsResolutionFallback(moduleresolution=node16).errors.txt

@@ -10,7 +10,7 @@ error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolut
         ".": {
             "import": "./dist/index.mjs",
             "require": "./dist/index.js",
-            "types": "./dist/index.d.ts",
+            "types": "./dist/index.d.ts"
         }
       }
     }
@@ -26,4 +26,5 @@ error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolut
     // Should be an untyped resolution to dep/dist/index.mjs,
     // but the first search is only for TS files, and when
     // there's no dist/index.d.mts, it continues looking for
-    // matching conditions and resolves via `types`.
+    // matching conditions and resolves via `types`.
+    

tests/baselines/reference/conditionalExportsResolutionFallback(moduleresolution=nodenext).errors.txt

@@ -10,7 +10,7 @@ error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResol
         ".": {
             "import": "./dist/index.mjs",
             "require": "./dist/index.js",
-            "types": "./dist/index.d.ts",
+            "types": "./dist/index.d.ts"
         }
       }
     }
@@ -26,4 +26,5 @@ error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResol
     // Should be an untyped resolution to dep/dist/index.mjs,
     // but the first search is only for TS files, and when
     // there's no dist/index.d.mts, it continues looking for
-    // matching conditions and resolves via `types`.
+    // matching conditions and resolves via `types`.
+    

tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).errors.txt

@@ -126,12 +126,13 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import
             "./types": {
                 "types": {
                     "import": "./index.d.mts",
-                    "require": "./index.d.cts",
+                    "require": "./index.d.cts"
                 },
                 "node": {
                     "import": "./index.mjs",
                     "require": "./index.cjs"
                 }
             }
         }
-    }
+    }
+    

tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).js

@@ -112,15 +112,16 @@ export const cjsSource = true;
         "./types": {
             "types": {
                 "import": "./index.d.mts",
-                "require": "./index.d.cts",
+                "require": "./index.d.cts"
             },
             "node": {
                 "import": "./index.mjs",
                 "require": "./index.cjs"
             }
         }
     }
-}
+}
+
 
 //// [index.mjs]
 // esm format file

tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node18).errors.txt

@@ -126,12 +126,13 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import
             "./types": {
                 "types": {
                     "import": "./index.d.mts",
-                    "require": "./index.d.cts",
+                    "require": "./index.d.cts"
                 },
                 "node": {
                     "import": "./index.mjs",
                     "require": "./index.cjs"
                 }
             }
         }
-    }
+    }
+    

tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node18).js

@@ -112,15 +112,16 @@ export const cjsSource = true;
         "./types": {
             "types": {
                 "import": "./index.d.mts",
-                "require": "./index.d.cts",
+                "require": "./index.d.cts"
             },
             "node": {
                 "import": "./index.mjs",
                 "require": "./index.cjs"
             }
         }
     }
-}
+}
+
 
 //// [index.mjs]
 // esm format file

tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=nodenext).errors.txt

@@ -120,12 +120,13 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import
             "./types": {
                 "types": {
                     "import": "./index.d.mts",
-                    "require": "./index.d.cts",
+                    "require": "./index.d.cts"
                 },
                 "node": {
                     "import": "./index.mjs",
                     "require": "./index.cjs"
                 }
             }
         }
-    }
+    }
+    

tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=nodenext).js

@@ -112,15 +112,16 @@ export const cjsSource = true;
         "./types": {
             "types": {
                 "import": "./index.d.mts",
-                "require": "./index.d.cts",
+                "require": "./index.d.cts"
             },
             "node": {
                 "import": "./index.mjs",
                 "require": "./index.cjs"
             }
         }
     }
-}
+}
+
 
 //// [index.mjs]
 // esm format file

tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node16).errors.txt

@@ -64,7 +64,7 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ
     {
         "name": "package",
         "private": true,
-        "type": "module",
+        "type": "module"
     }
 ==== node_modules/inner/package.json (0 errors) ====
     {
@@ -75,4 +75,5 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ
             "./mjs/*": "./*.mjs",
             "./js/*": "./*.js"
         }
-    }
+    }
+