Merge pull request #10754 from Microsoft/source_file

Andy · web-flow · commit e7de977b90bd · 2016-09-13T14:02:39.000-07:00
Optimize 'getSourceFile' to only get the source file once.
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -91,7 +91,10 @@ namespace ts {
         }
 
         public getText(sourceFile?: SourceFile): string {
-            return (sourceFile || this.getSourceFile()).text.substring(this.getStart(), this.getEnd());
+            if (!sourceFile) {
+                sourceFile = this.getSourceFile();
+            }
+            return sourceFile.text.substring(this.getStart(sourceFile), this.getEnd());
         }
 
         private addSyntheticNodes(nodes: Node[], pos: number, end: number, useJSDocScanner?: boolean): number {

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,10 @@ namespace ts {`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`public getText(sourceFile?: SourceFile): string {`
`94`		`- return (sourceFile \|\| this.getSourceFile()).text.substring(this.getStart(), this.getEnd());`
	`94`	`+ if (!sourceFile) {`
	`95`	`+ sourceFile = this.getSourceFile();`
	`96`	`+ }`
	`97`	`+ return sourceFile.text.substring(this.getStart(sourceFile), this.getEnd());`
`95`	`98`	`}`
`96`	`99`
`97`	`100`	`private addSyntheticNodes(nodes: Node[], pos: number, end: number, useJSDocScanner?: boolean): number {`