Skip to content

Commit f11dbc1

Browse files
author
Andy Hanson
committed
Respond to PR feedback
1 parent 7685e6a commit f11dbc1

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

src/compiler/comments.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,9 @@ namespace ts {
182182
}
183183
}
184184

185-
function emitTripleSlashLeadingComment(commentPos: number, commentEnd: number, _kind: SyntaxKind, hasTrailingNewLine: boolean, rangePos: number) {
185+
function emitTripleSlashLeadingComment(commentPos: number, commentEnd: number, kind: SyntaxKind, hasTrailingNewLine: boolean, rangePos: number) {
186186
if (isTripleSlashComment(commentPos, commentEnd)) {
187-
emitLeadingComment(commentPos, commentEnd, _kind, hasTrailingNewLine, rangePos);
187+
emitLeadingComment(commentPos, commentEnd, kind, hasTrailingNewLine, rangePos);
188188
}
189189
}
190190

src/compiler/core.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -903,7 +903,7 @@ namespace ts {
903903
return t => compose(a(t));
904904
}
905905
else {
906-
return _t => u => u;
906+
return _ => u => u;
907907
}
908908
}
909909

src/compiler/emitter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace ts {
1414
}
1515

1616
const id = (s: SourceFile) => s;
17-
const nullTransformers: Transformer[] = [_ctx => id];
17+
const nullTransformers: Transformer[] = [_ => id];
1818

1919
// targetSourceFile is when users only want one file in entire project to be emitted. This is used in compileOnSave feature
2020
export function emitFiles(resolver: EmitResolver, host: EmitHost, targetSourceFile: SourceFile, emitOnlyDtsFiles?: boolean): EmitResult {

src/compiler/moduleNameResolver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ namespace ts {
55

66
/* @internal */
77
export function trace(host: ModuleResolutionHost, message: DiagnosticMessage, ...args: any[]): void;
8-
export function trace(host: ModuleResolutionHost, _message: DiagnosticMessage): void {
8+
export function trace(host: ModuleResolutionHost): void {
99
host.trace(formatMessage.apply(undefined, arguments));
1010
}
1111

src/compiler/parser.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,10 +572,10 @@ namespace ts {
572572
// attached to the EOF token.
573573
let parseErrorBeforeNextFinishedNode = false;
574574

575-
export function parseSourceFile(fileName: string, _sourceText: string, languageVersion: ScriptTarget, _syntaxCursor: IncrementalParser.SyntaxCursor, setParentNodes?: boolean, scriptKind?: ScriptKind): SourceFile {
575+
export function parseSourceFile(fileName: string, sourceText: string, languageVersion: ScriptTarget, syntaxCursor: IncrementalParser.SyntaxCursor, setParentNodes?: boolean, scriptKind?: ScriptKind): SourceFile {
576576
scriptKind = ensureScriptKind(fileName, scriptKind);
577577

578-
initializeState(_sourceText, languageVersion, _syntaxCursor, scriptKind);
578+
initializeState(sourceText, languageVersion, syntaxCursor, scriptKind);
579579

580580
const result = parseSourceFileWorker(fileName, languageVersion, setParentNodes, scriptKind);
581581

src/compiler/sys.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,7 @@ namespace ts {
591591
getExecutingFilePath: () => ChakraHost.executingFile,
592592
getCurrentDirectory: () => ChakraHost.currentDirectory,
593593
getDirectories: ChakraHost.getDirectories,
594-
getEnvironmentVariable: ChakraHost.getEnvironmentVariable || ((_name: string) => ""),
594+
getEnvironmentVariable: ChakraHost.getEnvironmentVariable || (() => ""),
595595
readDirectory: (path: string, extensions?: string[], excludes?: string[], includes?: string[]) => {
596596
const pattern = getFileMatcherPatterns(path, excludes, includes, !!ChakraHost.useCaseSensitiveFileNames, ChakraHost.currentDirectory);
597597
return ChakraHost.readDirectory(path, extensions, pattern.basePaths, pattern.excludePattern, pattern.includeFilePattern, pattern.includeDirectoryPattern);

0 commit comments

Comments
 (0)