Enhance type argument completions #62170
Conversation
Previously, `getTypeArgumentConstraint` could only find constraints for type arguments of generic type instantiations. Now it additionally supports type arguments of the following expression kinds: - function calls - `new` expressions - tagged templates - JSX expressions - decorators - instantiation expressions
mkantor
force-pushed
the
type-argument-completions
branch
from
b9800de to
d5bbf02
Compare
1 similar comment
|
@i-ayushh18 I don't know if this is intentional, but it seems that you have a bot which is spamming a bunch of nonsense comments across many pull requests. If it is intentional, please cut it out. |
Sorry for the thing,a bot was responsible for that,will suspend that at latest! |
|
I have tested this changes locally, and it works well for me. Looking forward to seeing it merged and released soon. |
| return constraint && instantiateType(constraint, createTypeMapper(typeParameters, getEffectiveTypeArguments(typeReferenceNode, typeParameters))); | ||
| let typeArgumentPosition; | ||
| if ( | ||
| "typeArguments" in node.parent && // eslint-disable-line local/no-in-operator |
There was a problem hiding this comment.
We typically avoid these kinds of checks; is there no helper that achieves the same thing? Or at least, a switch case?
| @@ -42624,6 +42624,48 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker { | |||
| return undefined; | |||
| } | |||
|
|
|||
| function getSignaturesFromCallLike(node: CallLikeExpression): readonly Signature[] { | |||
There was a problem hiding this comment.
It feels suspicious that this is the first time we'd need a func like this; there's nothing else that does this? Not just getResolvedSignature?
#43526 implemented limited support for completions within type arguments, but only for type arguments of types (not values like generic function calls), and only for specific locations within the type literal (e.g. property names of object types). This pull request generalizes type argument completions such that suggestions now appear in many more scenarios, including:
f<…>())newexpressions (new Foo<…>())tag<…>`blah`)<Component<…>/>)@decorator<…> class {})f<…>)Foo<{ x: … }>)Foo<"…">)Foo<[…]>)Suggested completions are derived from the relevant type parameter's constraint.
This pull request subsumes #61758 and includes the additional enhancements mentioned in that pull request's description.
Fixes #61751.
Fixes #56299.
Fixes #52898.
Fixes #34771.