Skip to content

Commit 0c32303

Browse files
imadityaaAditya Abhishek
andauthored
fix for quotes in csv log (#229)
Co-authored-by: Aditya Abhishek <[email protected]>
1 parent 1c57079 commit 0c32303

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/VirtualClient/VirtualClient.Core.UnitTests/Logging/MetricsCsvFileLoggerTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public void MetricsCsvFileLoggerWritesTheExpectedCsvToFiles_1()
7676
{ "metricValue", 123.45 },
7777
{ "metricUnit", "milliseconds" },
7878
{ "metricCategorization", "Latency" },
79-
{ "metricDescription", "The average latency (in milliseconds)." },
79+
{ "metricDescription", "The average \"latency\" (in milliseconds)." },
8080
{ "metricRelativity", MetricRelativity.LowerIsBetter },
8181
{ "toolName", "ToolA" },
8282
{ "tags", "Tag1,Tag2,Tag3" }
@@ -101,7 +101,7 @@ public void MetricsCsvFileLoggerWritesTheExpectedCsvToFiles_1()
101101
$",\"avg. latency\"" +
102102
$",\"123.45\"" +
103103
$",\"milliseconds\"" +
104-
$",\"The average latency (in milliseconds).\"" +
104+
$",\"The average \"\"latency\"\" (in milliseconds).\"" +
105105
$",\"LowerIsBetter\"" +
106106
$",\"Test\"" +
107107
$",\"Unix\"" +

src/VirtualClient/VirtualClient.Core/Logging/MetricsCsvFileLogger.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ internal static string CreateMessage(EventContext context)
169169
{
170170
StringBuilder messageBuilder = new StringBuilder();
171171
messageBuilder.Append(Environment.NewLine);
172-
messageBuilder.AppendJoin(',', MetricsCsvFileLogger.CsvFields.Select(field => $"\"{field.GetFieldValue(context)}\""));
172+
messageBuilder.AppendJoin(',', MetricsCsvFileLogger.CsvFields.Select(field => $"\"{field.GetFieldValue(context)?.Replace("\"", "\"\"")}\""));
173173

174174
return messageBuilder.ToString();
175175
}

0 commit comments

Comments
 (0)