Win32NT unit tests fix (#457)

* Trying Path.Combine.

* Using Path.Combine for more tests.

* Using Path.Combine for more unit tests.

* Debugging.

* Checking Path.Combine string.

* Trying checking for OS.

* Trying operatingsytem.iswindows.

* Fixing small issue.

* fixing small mistake.

* Fixing small mistake.

* Overloading standardize path.

* Using this.mockFixture.Combine.

* useUnixStylePathsOnly should be required in overloaded method.

* reverting

---------

Co-authored-by: saibulusu <[email protected]>

Author: saibulusu

src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/CPS/CPSClientExecutorTests2.cs

@@ -56,7 +56,7 @@ private void SetupTest(PlatformID platformID, Architecture architecture)
             this.mockFixture.Parameters["Delaytime"] = 30;
             this.mockFixture.Parameters["ConfidenceLevel"] = "99";
 
-            string exampleResults = File.ReadAllText(this.mockFixture.Combine(CPSClientExecutorTests2.ExamplesDirectory, "CPS_Example_Results_Server.txt"));
+            string exampleResults = File.ReadAllText(Path.Combine(CPSClientExecutorTests2.ExamplesDirectory, "CPS_Example_Results_Server.txt"));
 
             this.mockFixture.Process.StandardOutput.Append(exampleResults);
 

src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/CPS/CPSServerExecutorTests2.cs

@@ -55,7 +55,7 @@ public void SetupTest(PlatformID platformID, Architecture architecture)
             this.mockFixture.Parameters["Scenario"] = "CPSMock";
             this.mockFixture.Parameters["ConfidenceLevel"] = "99";
 
-            string exampleResults = File.ReadAllText(this.mockFixture.Combine(CPSServerExecutorTests2.ExamplesDirectory, "CPS_Example_Results_Server.txt"));
+            string exampleResults = File.ReadAllText(Path.Combine(CPSServerExecutorTests2.ExamplesDirectory, "CPS_Example_Results_Server.txt"));
 
             this.mockFixture.FileSystem.Setup(rt => rt.File.ReadAllTextAsync(It.IsAny<string>(), It.IsAny<CancellationToken>()))
                 .ReturnsAsync(exampleResults);

src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/Latte/LatteClientExecutorTests2.cs

@@ -45,7 +45,7 @@ public void SetupTest(PlatformID platformID, Architecture architecture)
             this.mockFixture.Parameters["WarmupTime"] = 300;
             this.mockFixture.Parameters["Protocol"] = "Tcp";
 
-            string exampleResults = File.ReadAllText(this.mockFixture.Combine(LatteClientExecutorTests2.ExamplesDirectory, "Latte_Results_Example.txt"));
+            string exampleResults = File.ReadAllText(Path.Combine(LatteClientExecutorTests2.ExamplesDirectory, "Latte_Results_Example.txt"));
 
             LatteWorkloadState executionStartedState = new LatteWorkloadState(ClientServerStatus.ExecutionStarted);
             Item<LatteWorkloadState> expectedStateItem = new Item<LatteWorkloadState>(nameof(LatteWorkloadState), executionStartedState);

src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/Latte/LatteServerExecutorTests2.cs

@@ -43,7 +43,7 @@ public void SetupTest(PlatformID platformID, Architecture architecture)
             this.mockFixture.Parameters["Workload"] = "CPS";
             this.mockFixture.Parameters["Scenario"] = "LatteMock";
 
-            string exampleResults = File.ReadAllText(this.mockFixture.Combine(LatteServerExecutorTests2.ExamplesDirectory, "Latte_Results_Example.txt"));
+            string exampleResults = File.ReadAllText(Path.Combine(LatteServerExecutorTests2.ExamplesDirectory, "Latte_Results_Example.txt"));
 
             this.mockFixture.FileSystem.Setup(rt => rt.File.ReadAllTextAsync(It.IsAny<string>(), It.IsAny<CancellationToken>()))
                 .ReturnsAsync(exampleResults);

src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/NTttcp/NTttcpClientExecutorTests2.cs

@@ -52,7 +52,7 @@ public void SetupTest(PlatformID platformID, Architecture architecture)
             this.mockFixture.Parameters["ConnectionsPerThread"] = 2;
             this.mockFixture.Parameters["DevInterruptsDifferentiator"] = "mlx";
 
-            string exampleResults = File.ReadAllText(this.mockFixture.Combine(NTttcpClientExecutorTests2.ExamplesDirectory, "ClientOutput.xml"));
+            string exampleResults = File.ReadAllText(Path.Combine(NTttcpClientExecutorTests2.ExamplesDirectory, "ClientOutput.xml"));
 
             NTttcpWorkloadState executionStartedState = new NTttcpWorkloadState(ClientServerStatus.ExecutionStarted);
             Item<NTttcpWorkloadState> expectedStateItem = new Item<NTttcpWorkloadState>(nameof(NTttcpWorkloadState), executionStartedState);

src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/NTttcp/NTttcpServerExecutorTests2.cs

@@ -47,7 +47,7 @@ public void SetupTest(PlatformID platformID, Architecture architecture)
             this.mockFixture.Parameters["Workload"] = "CPS";
             this.mockFixture.Parameters["Scenario"] = "NTttcpMock";
 
-            string exampleResults = File.ReadAllText(this.mockFixture.Combine(NTttcpServerExecutorTests2.ExamplesDirectory, "ClientOutput.xml"));
+            string exampleResults = File.ReadAllText(Path.Combine(NTttcpServerExecutorTests2.ExamplesDirectory, "ClientOutput.xml"));
 
             this.mockFixture.FileSystem.Setup(rt => rt.File.ReadAllTextAsync(It.IsAny<string>(), It.IsAny<CancellationToken>()))
                 .ReturnsAsync(exampleResults);

src/VirtualClient/VirtualClient.Actions.UnitTests/Prime95/Prime95ExecutorTests.cs

@@ -31,7 +31,7 @@ public void SetupTest(PlatformID platform)
             this.mockPackage = new DependencyPath("prime95", this.mockFixture.GetPackagePath("prime95"));
             this.mockFixture.SetupPackage(this.mockPackage);
 
-            this.exampleResults = File.ReadAllText(this.mockFixture.Combine(Prime95ExecutorTests.ExamplesDirectory, "prime95_results_example_pass.txt"));
+            this.exampleResults = File.ReadAllText(Path.Combine(Prime95ExecutorTests.ExamplesDirectory, "prime95_results_example_pass.txt"));
 
             this.mockFixture.File.Reset();
             this.mockFixture.File.Setup(fe => fe.Exists(It.IsAny<string>()))

src/VirtualClient/VirtualClient.Actions.UnitTests/ScriptExecutor/PowershellExecutorTests.cs

@@ -34,7 +34,7 @@ public void SetupTest(PlatformID platform = PlatformID.Win32NT)
 
             this.fixture.Dependencies.RemoveAll<IEnumerable<IBlobManager>>();
 
-            this.exampleResults = File.ReadAllText(this.fixture.Combine(PowershellExecutorTests.ExamplesDirectory, "validJsonExample.json"));
+            this.exampleResults = File.ReadAllText(Path.Combine(PowershellExecutorTests.ExamplesDirectory, "validJsonExample.json"));
 
             this.fixture.File.Reset();
             this.fixture.File.Setup(fe => fe.Exists(It.IsAny<string>()))

src/VirtualClient/VirtualClient.Actions.UnitTests/ScriptExecutor/ScriptExecutorTests.cs

@@ -35,7 +35,7 @@ public void SetupTest(PlatformID platform)
             this.mockPackage = new DependencyPath("workloadPackage", this.mockFixture.GetPackagePath("workloadPackage"));
             this.mockFixture.SetupPackage(this.mockPackage);
 
-            this.exampleResults = File.ReadAllText(this.mockFixture.Combine(ScriptExecutorTests.ExamplesDirectory, "validJsonExample.json"));
+            this.exampleResults = File.ReadAllText(Path.Combine(ScriptExecutorTests.ExamplesDirectory, "validJsonExample.json"));
 
             this.mockFixture.File.Reset();
             this.mockFixture.File.Setup(fe => fe.Exists(It.IsAny<string>()))