sysbench thread count has ceiling -- protecting against failures for vms with high cpu count (#237)

Co-authored-by: Erica Vellanoweth <[email protected]>

Author: ericavella

src/VirtualClient/VirtualClient.Actions.UnitTests/SysbenchOLTP/SysbenchOLTPClientExecutorTests.cs

@@ -372,6 +372,70 @@ public async Task SysbenchOLTPClientExecutorUsesDefinedParameters()
             }
         }
 
+        [Test]
+        public async Task SysbenchOLTPClientExecutorUsesThreadCeilingForHighCoreCount()
+        {
+            SetupDefaultBehavior();
+
+            this.mockFixture.SystemManagement.Setup(mgr => mgr.GetCpuInfoAsync(It.IsAny<CancellationToken>()))
+                .ReturnsAsync(new CpuInfo("cpu", "description", 4, 16, 4, 4, false));
+
+            this.mockFixture.StateManager.OnGetState().ReturnsAsync(JObject.FromObject(new SysbenchOLTPExecutor.SysbenchOLTPState()
+            {
+                SysbenchInitialized = false
+            }));
+
+            string[] expectedCommands =
+            {
+                "sudo ./autogen.sh",
+                "sudo ./configure",
+                "sudo make -j",
+                "sudo make install",
+                $"sudo mysql -u sbtest -h 1.2.3.5 sbtest --execute=\"USE sbtest; SHOW tables; SELECT FOUND_ROWS();\"",
+                $"sudo mysql -u sbtest -h 1.2.3.5 sbtest --execute=\"USE sbtest; SELECT COUNT(*) FROM sbtest1;\"",
+                $"sudo /home/user/tools/VirtualClient/packages/sysbench/src/sysbench oltp_read_write --threads=64 --tables=10 --table-size=1000000 --mysql-db=sbtest --mysql-host=1.2.3.5 --time=10 cleanup",
+                $"sudo /home/user/tools/VirtualClient/packages/sysbench/src/sysbench oltp_common --tables=10 --table-size=1000000 --mysql-db=sbtest --mysql-host=1.2.3.5 prepare",
+                $"sudo /home/user/tools/VirtualClient/packages/sysbench/src/sysbench oltp_read_write --threads=64 --tables=10 --table-size=1000000 --mysql-db=sbtest --mysql-host=1.2.3.5 --time=10 run"
+            };
+
+            int commandNumber = 0;
+            bool commandExecuted = false;
+            this.mockFixture.ProcessManager.OnCreateProcess = (exe, arguments, workingDir) =>
+            {
+
+                string expectedCommand = expectedCommands[commandNumber];
+                if (expectedCommand == $"{exe} {arguments}")
+                {
+                    commandExecuted = true;
+                }
+                Assert.IsTrue(commandExecuted);
+                commandExecuted = false;
+                commandNumber += 1;
+
+                InMemoryProcess process = new InMemoryProcess
+                {
+                    StartInfo = new ProcessStartInfo
+                    {
+                        FileName = exe,
+                        Arguments = arguments
+                    },
+                    ExitCode = 0,
+                    OnStart = () => true,
+                    OnHasExited = () => true
+                };
+
+                string resultsPath = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "Examples", "SysbenchOLTP", "SysbenchOLTPExample.txt");
+                process.StandardOutput.Append(File.ReadAllText(resultsPath));
+
+                return process;
+            };
+
+            using (TestSysbenchOLTPClientExecutor SysbenchExecutor = new TestSysbenchOLTPClientExecutor(this.mockFixture.Dependencies, this.mockFixture.Parameters))
+            {
+                await SysbenchExecutor.ExecuteAsync(CancellationToken.None);
+            }
+        }
+
         [Test]
         public async Task SysbenchOLTPClientExecutorRunsTheExpectedWorkloadCommandBalancedScenario()
         {

src/VirtualClient/VirtualClient.Actions/SysbenchOLTP/SysbenchOLTPClientExecutor.cs

@@ -158,6 +158,8 @@ public int Threads
                     numThreads = threads.ToInt32(CultureInfo.InvariantCulture);
                 }
 
+                numThreads = Math.Min(numThreads, 64);
+
                 return numThreads;
             }
         }

website/docs/workloads/sysbench-oltp/sysbench-oltp-profiles.md

@@ -113,7 +113,7 @@ Runs a system-intensive workload using the Sysbench Benchmark to test the bandwi
   |---------------------------|-------------------------------------------------------------------------------------------------------------------------|-------------|
   | DatabaseName              | Not Required. Configure the name of database under test.                                                                |sbtest          |
   | DatabaseScenario              | Not Required. Configures the scenario in which to stress the database.                                      | Default          |
-  | Threads              | Not Required. Number of threads to use during workload execution.                | vCPU * 8         |
+  | Threads              | Not Required. Number of threads to use during workload execution.                | vCPU * 8, max 64      |
   | RecordCount              | Not Required. Number of records per table in the database.                                                      | 10^(vCPU + 2)         |
   | NumTables             | Not Required. Number of tables created in the database.                         | 10              |
   | Duration              | Required. Timespan duration of the workload.                                                               | N/A          |