Skip to content

Commit 7d65516

Browse files
authored
Revert default proxy logger source (#530)
* Revert default proxy logger source * fix test
1 parent 78d23cb commit 7d65516

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.0.26
1+
2.0.27

src/VirtualClient/VirtualClient.Core.UnitTests/Proxy/ProxyLoggerTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public void ProxyLoggerUsesTheExpectedSourceWhenAnExplicitSourceIsProvided()
4848
}
4949

5050
[Test]
51-
public void ProxyLoggerHandlesCasesWhenAnExplicitSourceIsNotProvided()
51+
public void ProxyLoggerDefaultsToVirtualClientWhenAnExplicitSourceIsNotProvided()
5252
{
5353
using (ProxyTelemetryChannel channel = new ProxyTelemetryChannel(this.mockProxyApiClient.Object))
5454
{
@@ -57,7 +57,7 @@ public void ProxyLoggerHandlesCasesWhenAnExplicitSourceIsNotProvided()
5757
ProxyTelemetryMessage messageLogged = channel.FirstOrDefault();
5858

5959
Assert.IsNotNull(messageLogged);
60-
Assert.IsNull(messageLogged.Source);
60+
Assert.AreEqual("VirtualClient", messageLogged.Source);
6161
}
6262
}
6363
}

src/VirtualClient/VirtualClient.Core/Proxy/ProxyLogger.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,9 @@ public ProxyLogger(ProxyTelemetryChannel channel, string source = null)
3737
channel.ThrowIfNull(nameof(channel));
3838

3939
this.Channel = channel;
40-
this.Source = source;
40+
this.Source = !string.IsNullOrWhiteSpace(source)
41+
? source
42+
: "VirtualClient";
4143
}
4244

4345
/// <summary>

0 commit comments

Comments
 (0)