Ensure IProcessProxy.ExitTime is set when an operation is cancelled or experiences a timeout.

Author: brdeyo

.pipelines/azure-pipelines-linux.yml

@@ -16,7 +16,7 @@ resources:
     options: --entrypoint=""
 
 variables:
-  VcVersion : 1.14.16
+  VcVersion : 1.14.17
   ROOT: $(Build.SourcesDirectory)
   CDP_DEFINITION_BUILD_COUNT: $[counter('', 0)] # needed for onebranch.pipeline.version task https://aka.ms/obpipelines/versioning
   ENABLE_PRS_DELAYSIGN: 1

.pipelines/azure-pipelines.yml

@@ -18,7 +18,7 @@ pool:
   vmImage: windows-latest
 
 variables:
-  VcVersion : 1.14.16
+  VcVersion : 1.14.17
   ROOT: $(Build.SourcesDirectory)
   CDP_DEFINITION_BUILD_COUNT: $[counter('', 0)] # needed for onebranch.pipeline.version task https://aka.ms/obpipelines/versioning
   ENABLE_PRS_DELAYSIGN: 1

src/VirtualClient/VirtualClient.Common/IProcessProxy.cs

@@ -39,7 +39,7 @@ public interface IProcessProxy : IDisposable
         /// <summary>
         /// Gets the exit time for the underlying process.
         /// </summary>
-        DateTime ExitTime { get; }
+        DateTime ExitTime { get; set; }
 
         /// <summary>
         /// The underlying process details.
@@ -97,7 +97,7 @@ public interface IProcessProxy : IDisposable
         /// <summary>
         ///  Gets the start time for the underlying process.
         /// </summary>
-        DateTime StartTime { get; }
+        DateTime StartTime { get; set; }
 
         /// <summary>
         /// Gracefully closes the process and main window.

src/VirtualClient/VirtualClient.Common/ProcessExtensions.cs

@@ -83,7 +83,7 @@ public static async Task StartAndWaitAsync(this IProcessProxy process, Cancellat
 
             if (process.Start())
             {
-                await process.WaitForExitAsync(cancellationToken, timeout).ConfigureAwait(false);
+                await process.WaitForExitAsync(cancellationToken, timeout);
             }
         }
 

src/VirtualClient/VirtualClient.Common/ProcessProxy.cs

@@ -365,6 +365,10 @@ public virtual async Task WaitForExitAsync(CancellationToken cancellationToken,
             {
                 // Expected whenever the CancellationToken receives a cancellation request.
             }
+            finally
+            {
+                this.exitTime = DateTime.UtcNow;
+            }
         }
 
         /// <summary>

src/VirtualClient/VirtualClient.Contracts/VirtualClientLoggingExtensions.cs

@@ -762,8 +762,6 @@ public static void LogMetrics(
             metricName.ThrowIfNullOrWhiteSpace(nameof(metricName));
             toolName.ThrowIfNullOrWhiteSpace(nameof(toolName));
             eventContext.ThrowIfNull(nameof(eventContext));
-            scenarioStartTime.ThrowIfInvalid(nameof(scenarioStartTime), (time) => time != DateTime.MinValue);
-            scenarioEndTime.ThrowIfInvalid(nameof(scenarioEndTime), (time) => time != DateTime.MinValue);
 
             var properties = new Dictionary<string, object>
             {