Skip to content

Commit afe8699

Browse files
RakeshwarKRakeshwar Reddy Kambaiahgari
RakeshwarK
and
Rakeshwar Reddy Kambaiahgari
authored
Suppressed wget certificate check in Compression Workload (#537)
* Added a flag to skip certificate check * Update Functional Tests * Updated tests --------- Co-authored-by: Rakeshwar Reddy Kambaiahgari <[email protected]>
1 parent cbd3c6f commit afe8699

File tree

8 files changed

+17
-16
lines changed

8 files changed

+17
-16
lines changed

‎src/VirtualClient/VirtualClient.Actions.FunctionalTests/CompressionProfileTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,11 +140,11 @@ private IEnumerable<string> GetProfileExpectedCommands(PlatformID platform, Arch
140140
{
141141
commands = new List<string>
142142
{
143-
$"sudo wget https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
143+
$"sudo wget --no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
144144
$"sudo unzip silesia.zip -d silesia",
145145
$"sudo bash -c \"pbzip2 -fv /home/user/tools/VirtualClient/packages/pbzip2/silesia/*\"",
146146
$"sudo bash -c \"pbzip2 -fvd /home/user/tools/VirtualClient/packages/pbzip2/silesia/*\"",
147-
$"sudo wget https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
147+
$"sudo wget --no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
148148
$"sudo unzip silesia.zip -d silesia",
149149
$"sudo bash -c \"gzip -rvf /home/user/tools/VirtualClient/packages/gzip/silesia\"",
150150
$"sudo bash -c \"gzip -rvfd /home/user/tools/VirtualClient/packages/gzip/silesia\""
@@ -154,7 +154,7 @@ private IEnumerable<string> GetProfileExpectedCommands(PlatformID platform, Arch
154154
{
155155
commands = new List<string>
156156
{
157-
$"wget https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
157+
$"wget --no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
158158
$"unzip silesia.zip -d silesia",
159159
$"7z a -bt -mx1 -mmt -mm=LZMA -r 7zLZMAFastestMode.7z C:\\users\\any\\tools\\VirtualClient\\packages\\7zip\\silesia\\*",
160160
$"7z a -bt -mx7 -mmt -mm=LZMA -r 7zLZMAMaximumMode.7z C:\\users\\any\\tools\\VirtualClient\\packages\\7zip\\silesia\\*",

‎src/VirtualClient/VirtualClient.Actions.UnitTests/Compressor7zip/Compressor7zipExecutorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public async Task Compressor7zipExecutorGetsDefaultFileIfInputFileOrDirNotProvid
8080
{ nameof(Compression7zipExecutor.PackageName), "7zip" },
8181
{ nameof(Compression7zipExecutor.Scenario), "mockScenario" }
8282
};
83-
string expectedCommand = $"wget https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip";
83+
string expectedCommand = $"wget --no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip";
8484

8585
bool commandExecuted = false;
8686
this.ProcessManager.OnCreateProcess = (exe, arguments, workingDir) =>
@@ -172,7 +172,7 @@ public async Task Compressor7zipExecutorExecutesTheCorrectCommandsWithInstallati
172172
string mockPackagePath = this.mockPackage.Path;
173173
List<string> expectedCommands = new List<string>
174174
{
175-
$"wget https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
175+
$"wget --no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
176176
$"unzip silesia.zip -d silesia",
177177
$"7z testOption1 testOption2 {this.PlatformSpecifics.Combine(mockPackagePath, "silesia/*")}"
178178
};

‎src/VirtualClient/VirtualClient.Actions.UnitTests/Gzip/GzipExecutorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public async Task GzipExecutorGetsDefaultFileIfInputFileOrDirNotProvided()
8888
{ nameof(GzipExecutor.PackageName), "gzip" },
8989
{ nameof(GzipExecutor.Scenario), "mockScenario" }
9090
};
91-
string expectedCommand = $"sudo wget https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip";
91+
string expectedCommand = $"sudo wget --no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip";
9292

9393
bool commandExecuted = false;
9494
this.mockFixture.ProcessManager.OnCreateProcess = (exe, arguments, workingDir) =>
@@ -180,7 +180,7 @@ public async Task GzipExecutorExecutesTheCorrectCommandsWithInstallationIfInputF
180180
string mockPackagePath = this.mockPackage.Path;
181181
List<string> expectedCommands = new List<string>
182182
{
183-
$"sudo wget https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
183+
$"sudo wget --no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
184184
$"sudo unzip silesia.zip -d silesia",
185185
$"sudo bash -c \"gzip testOption1 testOption2 {this.mockFixture.PlatformSpecifics.Combine(mockPackagePath, "silesia")}\""
186186
};

‎src/VirtualClient/VirtualClient.Actions.UnitTests/Pbzip2/Pzip2ExecutorTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public async Task Pbzip2ExecutorGetsDefaultFileIfInputFileOrDirNotProvided()
8787
{ nameof(Pbzip2Executor.PackageName), "pbzip2" },
8888
{ nameof(Pbzip2Executor.Scenario), "mockScenario" }
8989
};
90-
string expectedCommand = $"sudo wget https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip";
90+
string expectedCommand = $"sudo wget --no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip";
9191

9292
bool commandExecuted = false;
9393
this.mockFixture.ProcessManager.OnCreateProcess = (exe, arguments, workingDir) =>
@@ -179,7 +179,7 @@ public async Task Pbzip2ExecutorExecutesTheCorrectCommandsWithInstallationIfInpu
179179
string mockPackagePath = this.mockPackage.Path;
180180
List<string> expectedCommands = new List<string>
181181
{
182-
$"sudo wget https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
182+
$"sudo wget --no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip",
183183
$"sudo unzip silesia.zip -d silesia",
184184
$"sudo bash -c \"pbzip2 testOption1 testOption2 {this.mockFixture.PlatformSpecifics.Combine(mockPackagePath, "silesia/*")}\""
185185
};

‎src/VirtualClient/VirtualClient.Actions/7zip/Compression7zipExecutor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ protected override async Task InitializeAsync(EventContext telemetryContext, Can
119119
// Choose default file for compression and decompression if files/dirs are not provided.
120120
if (string.IsNullOrWhiteSpace(this.InputFilesOrDirs))
121121
{
122-
await this.ExecuteCommandAsync("wget", $"https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip", this.Compressor7zipDirectory, cancellationToken);
122+
await this.ExecuteCommandAsync("wget", $"--no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip", this.Compressor7zipDirectory, cancellationToken);
123123
await this.ExecuteCommandAsync("unzip", "silesia.zip -d silesia", this.Compressor7zipDirectory, cancellationToken);
124124
}
125125

‎src/VirtualClient/VirtualClient.Actions/Gzip/GzipExecutor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ await this.CheckDistroSupportAsync(telemetryContext, cancellationToken)
118118
// Choose default file for compression and decompression if files/dirs are not provided.
119119
if (string.IsNullOrWhiteSpace(this.InputFilesOrDirs))
120120
{
121-
await this.ExecuteCommandAsync("wget", $"https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip", this.GzipDirectory, cancellationToken);
121+
await this.ExecuteCommandAsync("wget", $"--no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip", this.GzipDirectory, cancellationToken);
122122
await this.ExecuteCommandAsync("unzip", "silesia.zip -d silesia", this.GzipDirectory, cancellationToken);
123123
}
124124

‎src/VirtualClient/VirtualClient.Actions/Pbzip2/Pbzip2Executor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ await this.CheckDistroSupportAsync(telemetryContext, cancellationToken)
122122
// Choose default file for compression and decompression if files/dirs are not provided.
123123
if (string.IsNullOrWhiteSpace(this.InputFiles))
124124
{
125-
await this.ExecuteCommandAsync("wget", $"https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip", this.Pbzip2Directory, cancellationToken);
125+
await this.ExecuteCommandAsync("wget", $"--no-check-certificate https://sun.aei.polsl.pl//~sdeor/corpus/silesia.zip", this.Pbzip2Directory, cancellationToken);
126126
await this.ExecuteCommandAsync("unzip", "silesia.zip -d silesia", this.Pbzip2Directory, cancellationToken);
127127
}
128128

‎website/docs/workloads/hplinpack/hplinpack-profiles.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,15 @@ This profile is designed to identify general/broad regressions when compared aga
7979

8080
```
8181

82+
*
8283
* **Performance Library Parameter set**
8384
The following parameter sets are supported.
8485

8586
| Platform | PerformanceLibrary | PerformanceLibraryVersion | CompilerName | CompilerVersion | Commandline Usage |
86-
|--------------------------|-----------------------------|-----------------------------------------------|------------|------------|
87-
| arm64 | ARM | 23.04.1, 24.10 and 25.04.1 | gcc | 11 | --parameters=PerformanceLibrary=ARM,,,PerformanceLibraryVersion=23.04.10,,,CompilerName=gcc,,,CompilerVersion=11 |
88-
| x64 | AMD | 4.2.0, 5.0.0, 5.1.0 | gcc | 11 | --parameters=PerformanceLibrary=AMD,,,PerformanceLibraryVersion=4.2.0,,,CompilerName=gcc,,,CompilerVersion=11 |
89-
| x64 | INTEL | 2024.2.2.17, 2025.1.0.803 | gcc | 13 | --parameters=PerformanceLibrary=INTEL,,,PerformanceLibraryVersion=2024.2.2.17,,,CompilerVersion=13 |
87+
|--------------------------|-----------------------------|-----------------------------------------------|-----------------|-------------------|---------------------|
88+
| arm64 | ARM | 23.04.1, 24.10 and 25.04.1 | gcc | 11 | --parameters=PerformanceLibrary=ARM,,,PerformanceLibraryVersion=23.04.10,,,CompilerName=gcc,,,CompilerVersion=11 |
89+
| x64 | AMD | 4.2.0, 5.0.0, 5.1.0 | gcc | 11 | --parameters=PerformanceLibrary=AMD,,,PerformanceLibraryVersion=4.2.0,,,CompilerName=gcc,,,CompilerVersion=11 |
90+
| x64 | INTEL | 2024.2.2.17, 2025.1.0.803 | gcc | 13 | --parameters=PerformanceLibrary=INTEL,,,PerformanceLibraryVersion=2024.2.2.17,,,CompilerVersion=13 |
9091

9192
* **Resources**
9293

0 commit comments

Comments
 (0)