Change dnf-update to dnf check-update (#328)

Author: yangpanMS

.pipelines/azure-pipelines-linux.yml

@@ -38,6 +38,14 @@ stages:
         performMultiLevelLookup: true
         workingDirectory: '$(Build.SourcesDirectory)'
 
+    - script: |
+        # Read the content of VERSION
+        version=$(Build.SourcesDirectory)/VERSION
+
+        # Set the file content as a pipeline variable
+        echo "##vso[task.setvariable variable=VcVersion;isOutput=true]$version"
+      displayName: 'Set VC Version'
+
     - script: chmod -R +x $(Build.SourcesDirectory)
       displayName: 'Allow scripts to be executable on Linux'
 

.pipelines/azure-pipelines.yml

@@ -18,7 +18,7 @@ pool:
   vmImage: windows-latest
 
 variables:
-  VcVersion : 1.14.34
+  VcVersion : 1.0.0
   ROOT: $(Build.SourcesDirectory)
   CDP_DEFINITION_BUILD_COUNT: $[counter('', 0)] # needed for onebranch.pipeline.version task https://aka.ms/obpipelines/versioning
   ENABLE_PRS_DELAYSIGN: 1
@@ -40,12 +40,13 @@ steps:
     performMultiLevelLookup: true
     workingDirectory: '$(Build.SourcesDirectory)'
 
-#- task: GitVersion@5
-#  inputs:
-#    runtime: 'core'
-#    configFilePath: 'GitVersion.yml'
-#    updateAssemblyInfo: true
+- script: |
+    # Read the content of VERSION
+    $version=Get-Content $(Build.SourcesDirectory)\VERSION
 
+    # Set the file content as a pipeline variable
+    echo "##vso[task.setvariable variable=VcVersion;isOutput=true]$version"
+  displayName: 'Set VC Version'
 
   # Ensure the artifact output/bin/obj directories are clean.
 - script: $(Build.SourcesDirectory)\clean.cmd

VERSION

@@ -1 +1 @@
-1.14.24
+1.14.35

src/VirtualClient/VirtualClient.Dependencies/Packaging/DnfPackageInstallation.cs

@@ -22,6 +22,11 @@ namespace VirtualClient.Dependencies
     /// </summary>
     public class DnfPackageInstallation : VirtualClientComponent
     {
+        /// <summary>
+        /// The list of exit codes that dnf could return.
+        /// </summary>
+        public static readonly IEnumerable<int> DnfSuccessfulCodes = new int[] { 0, 100 };
+
         private const string DnfCommand = "dnf";
         private ISystemManagement systemManagement;
 
@@ -138,7 +143,7 @@ await this.ExecuteCommandAsync(DnfPackageInstallation.DnfCommand, $"config-manag
             await this.InstallRetryPolicy.ExecuteAsync(async () =>
             {
                 // Runs Dnf update first.
-                await this.ExecuteCommandAsync(DnfPackageInstallation.DnfCommand, $"update -y", Environment.CurrentDirectory, telemetryContext, cancellationToken)
+                await this.ExecuteCommandAsync(DnfPackageInstallation.DnfCommand, $"check-update -y", Environment.CurrentDirectory, telemetryContext, cancellationToken)
                     .ConfigureAwait(false);
 
                 // Runs the installation command with retries and throws if the command fails after all
@@ -214,7 +219,7 @@ private Task ExecuteCommandAsync(string pathToExe, string commandLineArguments,
                         await this.LogProcessDetailsAsync(process, telemetryContext, "Dnf")
                             .ConfigureAwait(false);
 
-                        process.ThrowIfErrored<DependencyException>(errorReason: ErrorReason.DependencyInstallationFailed);
+                        process.ThrowIfErrored<DependencyException>(DnfPackageInstallation.DnfSuccessfulCodes, errorReason: ErrorReason.DependencyInstallationFailed);
                     }
                 }
             });