fixing wget issue for remote wget download (#219)

* fixing wget issue for remote wget download

* reverting profiles

* fixing UTs and updating version of VC

* fixing json formatting

Author: nmalkapuram

.pipelines/azure-pipelines-linux.yml

@@ -16,7 +16,7 @@ resources:
     options: --entrypoint=""
 
 variables:
-  VcVersion : 1.13.1
+  VcVersion : 1.13.2
   ROOT: $(Build.SourcesDirectory)
   CDP_DEFINITION_BUILD_COUNT: $[counter('', 0)] # needed for onebranch.pipeline.version task https://aka.ms/obpipelines/versioning
   ENABLE_PRS_DELAYSIGN: 1

.pipelines/azure-pipelines.yml

@@ -18,7 +18,7 @@ pool:
   vmImage: windows-latest
 
 variables:
-  VcVersion : 1.13.1
+  VcVersion : 1.13.2
   ROOT: $(Build.SourcesDirectory)
   CDP_DEFINITION_BUILD_COUNT: $[counter('', 0)] # needed for onebranch.pipeline.version task https://aka.ms/obpipelines/versioning
   ENABLE_PRS_DELAYSIGN: 1

src/VirtualClient/VirtualClient.Dependencies.UnitTests/Packaging/WgetPackageInstallationTests.cs

@@ -50,11 +50,9 @@ public void SetupDefaults(PlatformID platform, Architecture architecture)
         }
 
         [Test]
-        [TestCase(PlatformID.Unix, Architecture.X64)]
-        [TestCase(PlatformID.Unix, Architecture.Arm64)]
         [TestCase(PlatformID.Win32NT, Architecture.X64)]
         [TestCase(PlatformID.Win32NT, Architecture.Arm64)]
-        public void WgetPackageInstallationThrowsIfTheWgetTooletPackageIsNotFound(PlatformID platform, Architecture architecture)
+        public void WgetPackageInstallationThrowsIfTheWgetTooletPackageIsNotFoundOnWindows(PlatformID platform, Architecture architecture)
         {
             this.SetupDefaults(platform, architecture);
 

src/VirtualClient/VirtualClient.Dependencies/Packaging/WgetPackageInstallation.cs

@@ -89,20 +89,23 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel
                 {
                     DependencyPath wgetPackage = null;
 
-                    try
+                    if (this.Platform == PlatformID.Win32NT)
                     {
-                        wgetPackage = await this.GetPlatformSpecificPackageAsync(WgetPackageInstallation.WgetPackageName, cancellationToken);
-                    }
-                    catch (DependencyException exc)
-                    {
-                        throw new DependencyException(
-                            $"Missing required package. The '{WgetPackageInstallation.WgetPackageName}' package does not exist. This package is expected " +
-                            $"to be included with the Virtual Client. It may be necessary to use a newer version of the Virtual Client.",
-                            exc,
-                            ErrorReason.DependencyNotFound);
-                    }
+                        try
+                        {
+                            wgetPackage = await this.GetPlatformSpecificPackageAsync(WgetPackageInstallation.WgetPackageName, cancellationToken);
+                        }
+                        catch (DependencyException exc)
+                        {
+                            throw new DependencyException(
+                                $"Missing required package. The '{WgetPackageInstallation.WgetPackageName}' package does not exist. This package is expected " +
+                                $"to be included with the Virtual Client. It may be necessary to use a newer version of the Virtual Client.",
+                                exc,
+                                ErrorReason.DependencyNotFound);
+                        }
 
-                    telemetryContext.AddContext("wgetPackagePath", wgetPackage.Path);
+                        telemetryContext.AddContext("wgetPackagePath", wgetPackage.Path);
+                    }
 
                     // For windows we are using the wget we download. In Linux we are using wget from the package managers.
                     string wgetExe = this.Platform == PlatformID.Unix ? "wget" : this.Combine(wgetPackage.Path, "wget.exe");