Skip to content

Commit 3605370

Browse files
authored
Managed addon now uses dotnet 10 by default and Windows 26100 (#182)
When using `winapp node create-addon` to create a managed add-on, the resulting .csproj now uses this TFM by default: ``` <TargetFramework>net10.0-windows10.0.26100.0</TargetFramework> ``` This is just the default, the app dev can easily change it. We're targeting Windows version 26100 by default because the AI APIs the API projections use are supported there.
1 parent b5fec74 commit 3605370

File tree

4 files changed

+4
-11
lines changed

4 files changed

+4
-11
lines changed

samples/electron/csAddon/csAddon.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<TargetFramework>net8.0-windows10.0.19041.0</TargetFramework>
3+
<TargetFramework>net10.0-windows10.0.26100.0</TargetFramework>
44
<OutputType>Library</OutputType>
55
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
66
<AssemblyName>csAddon</AssemblyName>

samples/electron/package-lock.json

Lines changed: 0 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/winapp-npm/cs-addon-template/AddonTemplate.csproj.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<TargetFramework>net8.0-windows10.0.19041.0</TargetFramework>
3+
<TargetFramework>net10.0-windows10.0.26100.0</TargetFramework>
44
<OutputType>Library</OutputType>
55
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
66
<AssemblyName>{AddonName}</AssemblyName>

src/winapp-npm/cs-addon-template/Directory.packages.props.template

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<PackageVersion Include="Microsoft.JavaScript.NodeApi.Generator" Version="0.9.17" />
99

1010
<!-- These versions may be updated automatically during restore to match yaml -->
11-
<PackageVersion Include="Microsoft.WindowsAppSDK" Version="Run restore to set version before building" />
12-
<PackageVersion Include="Microsoft.Windows.SDK.BuildTools" Version="Run restore to set version before building" />
11+
<PackageVersion Include="Microsoft.WindowsAppSDK" Version="Run winapp restore to set version before building" />
12+
<PackageVersion Include="Microsoft.Windows.SDK.BuildTools" Version="Run winapp restore to set version before building" />
1313
</ItemGroup>
1414
</Project>

0 commit comments

Comments
 (0)