refactor: migrate to Microsoft.Windows.Storage.ApplicationData and centralize settings keys (#1900)

## Description
- Replace `Windows.Storage.ApplicationData` with
`Microsoft.Windows.Storage.ApplicationData`.
- Centralize Settings Keys in a `SettingsKeys` Class.
- define key constants in `ScratchPadPage`.

## Motivation and Context
- Closes #1892
- Closes #1893

## How Has This Been Tested?
**Manually tested**

## Screenshots (if appropriate):

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

Co-authored-by: Niels Laute <[email protected]>

Author: Zakariathr22

WinUIGallery/Helpers/NavigationOrientationHelper.cs

@@ -3,25 +3,23 @@
 
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
-using Windows.Storage;
+using Microsoft.Windows.Storage;
 using WinUIGallery.Pages;
 
 namespace WinUIGallery.Helpers;
 
 public static class NavigationOrientationHelper
 {
-
-    private const string IsLeftModeKey = "NavigationIsOnLeftMode";
     private static bool _isLeftMode = true;
-
+    private static ApplicationData appData = ApplicationData.GetDefault();
     public static bool IsLeftMode()
     {
         if (NativeHelper.IsAppPackaged)
         {
-            var valueFromSettings = ApplicationData.Current.LocalSettings.Values[IsLeftModeKey];
+            var valueFromSettings = appData.LocalSettings.Values[SettingsKeys.IsLeftMode];
             if (valueFromSettings == null)
             {
-                ApplicationData.Current.LocalSettings.Values[IsLeftModeKey] = true;
+                appData.LocalSettings.Values[SettingsKeys.IsLeftMode] = true;
                 valueFromSettings = true;
             }
             return (bool)valueFromSettings;
@@ -37,7 +35,7 @@ public static void IsLeftModeForElement(bool isLeftMode, UIElement element)
         UpdateNavigationViewForElement(isLeftMode, element);
         if (NativeHelper.IsAppPackaged)
         {
-            ApplicationData.Current.LocalSettings.Values[IsLeftModeKey] = isLeftMode;
+            appData.LocalSettings.Values[SettingsKeys.IsLeftMode] = isLeftMode;
         }
         else
         {

WinUIGallery/Helpers/ProtocolActivationClipboardHelper.cs

@@ -4,7 +4,7 @@
 using System;
 using Windows.ApplicationModel;
 using Windows.ApplicationModel.DataTransfer;
-using Windows.Storage;
+using Microsoft.Windows.Storage;
 using WinUIGallery.Models;
 
 namespace WinUIGallery.Helpers;
@@ -14,19 +14,19 @@ namespace WinUIGallery.Helpers;
 /// </summary>
 public static class ProtocolActivationClipboardHelper
 {
-    private const string ShowCopyLinkTeachingTipKey = "ShowCopyLinkTeachingTip";
     private static bool _showCopyLinkTeachingTip = true;
+    private static ApplicationData appData = ApplicationData.GetDefault();
 
     public static bool ShowCopyLinkTeachingTip
     {
         get
         {
             if (NativeHelper.IsAppPackaged)
             {
-                object valueFromSettings = ApplicationData.Current.LocalSettings.Values[ShowCopyLinkTeachingTipKey];
+                object valueFromSettings = appData.LocalSettings.Values[SettingsKeys.ShowCopyLinkTeachingTip];
                 if (valueFromSettings == null)
                 {
-                    ApplicationData.Current.LocalSettings.Values[ShowCopyLinkTeachingTipKey] = true;
+                    appData.LocalSettings.Values[SettingsKeys.ShowCopyLinkTeachingTip] = true;
                     valueFromSettings = true;
                 }
                 return (bool)valueFromSettings;
@@ -41,7 +41,7 @@ public static bool ShowCopyLinkTeachingTip
         {
             if (NativeHelper.IsAppPackaged)
             {
-                ApplicationData.Current.LocalSettings.Values[ShowCopyLinkTeachingTipKey] = value;
+                appData.LocalSettings.Values[SettingsKeys.ShowCopyLinkTeachingTip] = value;
 
             }
             else

WinUIGallery/Helpers/SettingsHelper.cs

@@ -190,19 +190,3 @@ private static bool TrySaveList(string key, List<string> items)
         return true;
     }
 }
-
-/// <summary>
-/// Provides constant keys used for accessing application settings.
-/// </summary>
-public static class SettingsKeys
-{
-    /// <summary>
-    /// Key for the list of favorited Pages.
-    /// </summary>
-    public const string Favorites = "Favorites";
-
-    /// <summary>
-    /// Key for the list of recently visited Pages.
-    /// </summary>
-    public const string RecentlyVisited = "RecentlyVisited";
-}

WinUIGallery/Helpers/SettingsKeys.cs

@@ -0,0 +1,34 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+namespace WinUIGallery.Helpers;
+
+/// <summary>
+/// Provides constant keys used for accessing application settings.
+/// </summary>
+public static class SettingsKeys
+{
+    /// <summary>
+    /// The key used to store or retrieve the selected application theme.
+    /// </summary>
+    public const string SelectedAppTheme = "SelectedAppTheme";
+
+    /// <summary>
+    /// Represents the key used to determine whether the navigation is in "left mode."
+    /// </summary>
+    public const string IsLeftMode = "NavigationIsOnLeftMode";
+
+    /// <summary>
+    /// Key for the list of recently visited Pages.
+    /// </summary>
+    public const string RecentlyVisited = "RecentlyVisited";
+
+    /// <summary>
+    /// Key for the list of favorited Pages.
+    /// </summary>
+    public const string Favorites = "Favorites";
+
+    /// <summary>
+    /// Represents the key used to identify the "Show Copy Link" teaching tip of the protocol activation clipboard.
+    /// </summary>
+    public const string ShowCopyLinkTeachingTip = "ShowCopyLinkTeachingTip";
+}

WinUIGallery/Helpers/ThemeHelper.cs

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 using Microsoft.UI.Xaml;
-using Windows.Storage;
+using Microsoft.Windows.Storage;
 
 namespace WinUIGallery.Helpers;
 
@@ -11,7 +11,7 @@ namespace WinUIGallery.Helpers;
 /// </summary>
 public static class ThemeHelper
 {
-    private const string SelectedAppThemeKey = "SelectedAppTheme";
+    private static ApplicationData appData = ApplicationData.GetDefault();
 
     /// <summary>
     /// Gets the current actual theme of the app based on the requested theme of the
@@ -65,7 +65,7 @@ public static ElementTheme RootTheme
 
             if (NativeHelper.IsAppPackaged)
             {
-                ApplicationData.Current.LocalSettings.Values[SelectedAppThemeKey] = value.ToString();
+                appData.LocalSettings.Values[SettingsKeys.SelectedAppTheme] = value.ToString();
             }
         }
     }
@@ -74,7 +74,7 @@ public static void Initialize()
     {
         if (NativeHelper.IsAppPackaged)
         {
-            string savedTheme = ApplicationData.Current.LocalSettings.Values[SelectedAppThemeKey]?.ToString();
+            string savedTheme = appData.LocalSettings.Values[SettingsKeys.SelectedAppTheme]?.ToString();
 
             if (savedTheme != null)
             {

WinUIGallery/Samples/ControlPages/Fundamentals/ScratchPadPage.xaml.cs

@@ -16,6 +16,15 @@ namespace WinUIGallery.ControlPages;
 
 public sealed partial class ScratchPadPage : Page
 {
+    // The name of the ApplicationData container used to store all ScratchPad-related settings.
+    private const string containerKey = "ScratchPad";
+
+    // The key under the ScratchPad container for storing the XAML composite value.
+    private const string xamlCompositeValueKey = "ScratchPadXAML";
+
+    // The key within the XAML composite value that stores the number of 4KB segments.
+    private const string xamlSegmentCountKey = "count";
+
     public ScratchPadPage()
     {
         this.InitializeComponent();
@@ -62,16 +71,16 @@ private string GetDefaultScratchXAML()
 
     public string ReadScratchPadXAMLinLocalSettings()
     {
-        var appData = ApplicationData.Current;
-        if (appData.LocalSettings.Containers.ContainsKey("ScratchPad"))
+        var appData = Microsoft.Windows.Storage.ApplicationData.GetDefault();
+        if (appData.LocalSettings.Containers.ContainsKey(containerKey))
         {
-            var scratchPadContainer = appData.LocalSettings.CreateContainer("ScratchPad", ApplicationDataCreateDisposition.Existing);
-            if (scratchPadContainer != null && scratchPadContainer.Values.ContainsKey("ScratchPadXAML"))
+            var scratchPadContainer = appData.LocalSettings.CreateContainer(containerKey, Microsoft.Windows.Storage.ApplicationDataCreateDisposition.Existing);
+            if (scratchPadContainer != null && scratchPadContainer.Values.ContainsKey(xamlCompositeValueKey))
             {
                 // String values are limited to 4K characters. Use a composite value to support a longer string.
-                var compositeStr = scratchPadContainer.Values["ScratchPadXAML"] as ApplicationDataCompositeValue;
+                var compositeStr = scratchPadContainer.Values[xamlCompositeValueKey] as ApplicationDataCompositeValue;
                 var xamlStr = "";
-                int count = (int)compositeStr["count"];
+                int count = (int)compositeStr[xamlSegmentCountKey];
                 for (int i = 0; i < count; i++)
                 {
                     xamlStr += compositeStr[i.ToString()];
@@ -84,8 +93,8 @@ public string ReadScratchPadXAMLinLocalSettings()
 
     public void SaveScratchPadXAMLinLocalSettings(string xamlStr)
     {
-        var appData = ApplicationData.Current;
-        var scratchPadContainer = appData.LocalSettings.CreateContainer("ScratchPad", ApplicationDataCreateDisposition.Always);
+        var appData = Microsoft.Windows.Storage.ApplicationData.GetDefault();
+        var scratchPadContainer = appData.LocalSettings.CreateContainer(containerKey, Microsoft.Windows.Storage.ApplicationDataCreateDisposition.Existing);
         // String values are limited to 4K characters. Use a composite value to support a longer string.
         var compositeStr = new ApplicationDataCompositeValue();
         int count = 0;
@@ -96,8 +105,8 @@ public void SaveScratchPadXAMLinLocalSettings(string xamlStr)
             count++;
             xamlStr = xamlStr.Substring(len);
         }
-        compositeStr["count"] = count;
-        scratchPadContainer.Values["ScratchPadXAML"] = compositeStr;
+        compositeStr[xamlSegmentCountKey] = count;
+        scratchPadContainer.Values[xamlCompositeValueKey] = compositeStr;
     }
 
     private async void ResetToDefaultClick(object sender, RoutedEventArgs e)