Merge pull request #191 from smowton/patch-1

NateD-MSFT · web-flow · commit 21faa4290ccd · 2025-10-28T10:35:26.000-07:00
Map suppression names for irql-function-not-annotated
diff --git a/src/drivers/libraries/Suppression.qll b/src/drivers/libraries/Suppression.qll
@@ -110,6 +110,9 @@ abstract class CASuppression extends PreprocessorPragma {
     this.getRuleName() = any(["__WARNING_PROTOTYPE_MISMATCH", "28127"]) and
     result = "lgtm[cpp/drivers/routine-function-type-not-expected]"
     or
+    this.getRuleName() = any(["__WARNING_UNEXPECTED_IRQL_CHANGE", "28167"]) and
+    result = "lgtm[cpp/drivers/irql-function-not-annotated]"
+    or
     result = "lgtm[" + this.getRuleName() + "]"
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,9 @@ abstract class CASuppression extends PreprocessorPragma {`
`110`	`110`	`this.getRuleName() = any(["__WARNING_PROTOTYPE_MISMATCH", "28127"]) and`
`111`	`111`	`result = "lgtm[cpp/drivers/routine-function-type-not-expected]"`
`112`	`112`	`or`
	`113`	`+ this.getRuleName() = any(["__WARNING_UNEXPECTED_IRQL_CHANGE", "28167"]) and`
	`114`	`+ result = "lgtm[cpp/drivers/irql-function-not-annotated]"`
	`115`	`+ or`
`113`	`116`	`result = "lgtm[" + this.getRuleName() + "]"`
`114`	`117`	`}`
`115`	`118`	`}`