Skip to content

Commit 31acf32

Browse files
updates from review
1 parent 3d5524e commit 31acf32

File tree

3 files changed

+323
-325
lines changed

3 files changed

+323
-325
lines changed

src/drivers/general/queries/IrqlInconsistentWithRequired/IrqlInconsistentWithRequired.qhelp

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
<qhelp>
33
<overview>
44
<p>
5-
TODO overview
5+
The actual IRQL is inconsistent with the required IRQL
66
</p>
77
</overview>
88
<recommendation>
99
<p>
10-
TODO recommendation
10+
An _IRQL_requires_same_ annotation specifies that the driver should be executing at a particular IRQL when the function completes, but there is at least one path in which the driver is executing at a different IRQL when the function completes.
1111
</p>
1212
</recommendation>
1313
<example>
@@ -28,24 +28,16 @@
2828
}
2929
}
3030
}]]>
31-
</sample>
32-
<p>
33-
TODO example 2
34-
</p>
35-
<sample language="c"> <![CDATA[
36-
// Example code
37-
}]]>
38-
</sample>
31+
3932
</example>
4033
<semmleNotes>
4134
<p>
42-
TODO notes
4335
</p>
4436
</semmleNotes>
4537
<references>
4638
<li>
47-
<a href="example.com">
48-
Example link
39+
<a href="https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28166-function-does-not-restore-irql-value">
40+
C28166
4941
</a>
5042
</li>
5143
</references>

src/drivers/general/queries/IrqlInconsistentWithRequired/IrqlInconsistentWithRequired.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
* @platform Desktop
99
* @feature.area Multiple
1010
* @impact Insecure Coding Practice
11-
* @repro.textAn _IRQL_requires_same_ annotation specifies that the driver should be executing at a particular IRQL when the function completes, but there is at least one path in which the driver is executing at a different IRQL when the function completes.
11+
* @repro.text An _IRQL_requires_same_ annotation specifies that the driver should be executing at a particular IRQL when the function completes, but there is at least one path in which the driver is executing at a different IRQL when the function completes.
1212
* @owner.email: [email protected]
13-
* @opaqueid CQLD-C28156
13+
* @opaqueid CQLD-C28166
1414
* @problem.severity warning
1515
* @precision medium
1616
* @tags correctness

0 commit comments

Comments
 (0)