Skip to content

Commit b9e2ad9

Browse files
updates from review
1 parent ab606f7 commit b9e2ad9

File tree

3 files changed

+441
-436
lines changed

3 files changed

+441
-436
lines changed

src/drivers/general/queries/AnnotationSyntax/AnnotationSyntax.qhelp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
</example>
4747
<semmleNotes>
4848
<p>
49-
TODO notes
5049
</p>
5150
</semmleNotes>
5251
<references>

src/drivers/general/queries/AnnotationSyntax/AnnotationSyntax.ql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,17 @@
2121
import cpp
2222
import drivers.libraries.SAL
2323

24-
from SALAnnotation sa, SALParameter sp
24+
from SALAnnotation sa
2525
where
2626
// restoreIRQLGlobal was not on the whole function
27-
// saveIRQLGlobalL was not on the whole function
27+
// saveIRQLGlobal was not on the whole function
2828
(
2929
sa.toString().matches("%restoresIRQLGlobal%") or //restoreIRQLGlobal //__drv_restoresIRQLGlobal //_IRQL_restores_global_
3030
sa.toString().matches("%_IRQL_saves_global_%") or //restoreIRQLGlobal //__drv_restoresIRQLGlobal //_IRQL_restores_global_
3131
sa.toString().matches("%savesIRQLGlobal%") or //saveIRQLGlobal //__drv_savesIRQLGlobal //_IRQL_saves_global_
3232
sa.toString().matches("%_IRQL_restores_global_%")
3333
) and
34-
sp.getAnnotation() = sa
34+
exists(SALParameter sp | sp.getAnnotation() = sa)
3535
or
3636
(
3737
sa.toString().matches("%_When_%") or

0 commit comments

Comments
 (0)