Skip to content

Commit 37a6cc1

Browse files
author
REDMOND\jingf
committed
N/A
1 parent 6db95cf commit 37a6cc1

File tree

2 files changed

+10
-23
lines changed

2 files changed

+10
-23
lines changed

Tools/WinMLRunner/src/EventTraceHelper.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Level Verbosity is as follows:
2424
From <https://docs.microsoft.com/en-us/message-analyzer/system-etw-provider-event-keyword-level-settings>
2525
*/
2626

27-
void EventTraceHelper::RemoveTrailingSpace(PEVENT_MAP_INFO pMapInfo)
27+
static void RemoveTrailingSpace(PEVENT_MAP_INFO pMapInfo)
2828
{
2929
DWORD byteLength = 0;
3030

@@ -35,7 +35,7 @@ void EventTraceHelper::RemoveTrailingSpace(PEVENT_MAP_INFO pMapInfo)
3535
}
3636
}
3737

38-
DWORD EventTraceHelper::GetArraySize(PEVENT_RECORD pEvent, PTRACE_EVENT_INFO pInfo, USHORT i, PUSHORT ArraySize)
38+
static DWORD GetArraySize(PEVENT_RECORD pEvent, PTRACE_EVENT_INFO pInfo, USHORT i, PUSHORT ArraySize)
3939
{
4040
DWORD status = ERROR_SUCCESS;
4141
PROPERTY_DATA_DESCRIPTOR dataDescriptor;
@@ -64,7 +64,7 @@ DWORD EventTraceHelper::GetArraySize(PEVENT_RECORD pEvent, PTRACE_EVENT_INFO pIn
6464
// map values can be integer values or bit values. If the property specifies a value
6565
// map, get the map.
6666

67-
DWORD EventTraceHelper::GetMapInfo(PEVENT_RECORD pEvent, LPWSTR pMapName, DWORD DecodingSource,
67+
static DWORD GetMapInfo(PEVENT_RECORD pEvent, LPWSTR pMapName, DWORD DecodingSource,
6868
PEVENT_MAP_INFO& pMapInfo)
6969
{
7070
DWORD status = ERROR_SUCCESS;
@@ -111,7 +111,7 @@ DWORD EventTraceHelper::GetMapInfo(PEVENT_RECORD pEvent, LPWSTR pMapName, DWORD
111111
return status;
112112
}
113113

114-
DWORD EventTraceHelper::GetPropertyLength(PEVENT_RECORD pEvent, PTRACE_EVENT_INFO pInfo, USHORT i, PUSHORT PropertyLength)
114+
static DWORD GetPropertyLength(PEVENT_RECORD pEvent, PTRACE_EVENT_INFO pInfo, USHORT i, PUSHORT PropertyLength)
115115
{
116116
DWORD status = ERROR_SUCCESS;
117117
PROPERTY_DATA_DESCRIPTOR dataDescriptor;
@@ -170,7 +170,7 @@ DWORD EventTraceHelper::GetPropertyLength(PEVENT_RECORD pEvent, PTRACE_EVENT_INF
170170
return status;
171171
}
172172

173-
DWORD EventTraceHelper::GetEventInformation(PEVENT_RECORD pEvent, PTRACE_EVENT_INFO& pInfo)
173+
static DWORD GetEventInformation(PEVENT_RECORD pEvent, PTRACE_EVENT_INFO& pInfo)
174174
{
175175
DWORD status = ERROR_SUCCESS;
176176
DWORD bufferSize = 0;
@@ -202,7 +202,7 @@ DWORD EventTraceHelper::GetEventInformation(PEVENT_RECORD pEvent, PTRACE_EVENT_I
202202
return status;
203203
}
204204

205-
std::wstring& EventTraceHelper::TrimOperatorName(std::wstring& s)
205+
static std::wstring& TrimOperatorName(std::wstring& s)
206206
{
207207
wstring substring = L"_kernel_time";
208208
int offset = (int)s.find(substring);
@@ -232,7 +232,7 @@ std::wstring& EventTraceHelper::TrimOperatorName(std::wstring& s)
232232
/// \return A DWORD with a windows error value. If the function succeded, it returns
233233
/// ERROR_SUCCESS.
234234
///
235-
DWORD EventTraceHelper::GetFormatedPropertyData(_In_ const PEVENT_RECORD EventRecord,
235+
static DWORD GetFormatedPropertyData(_In_ const PEVENT_RECORD EventRecord,
236236
_In_ const PTRACE_EVENT_INFO EventInfo,
237237
_In_ USHORT Index, _Inout_ PBYTE& UserData, _In_ PBYTE EndOfUserData,
238238
_Inout_ wstring& propertyValue)
@@ -353,7 +353,7 @@ DWORD EventTraceHelper::GetFormatedPropertyData(_In_ const PEVENT_RECORD EventRe
353353
/// \return A DWORD with a windows error value. If the function succeded, it returns
354354
/// ERROR_SUCCESS.
355355
///
356-
DWORD EventTraceHelper::FormatDataForCPUFallback(_In_ const PEVENT_RECORD EventRecord,
356+
static DWORD FormatDataForCPUFallback(_In_ const PEVENT_RECORD EventRecord,
357357
_In_ const PTRACE_EVENT_INFO EventInfo)
358358
{
359359
DWORD status = ERROR_SUCCESS;
@@ -419,7 +419,7 @@ DWORD EventTraceHelper::FormatDataForCPUFallback(_In_ const PEVENT_RECORD EventR
419419
return ERROR_SUCCESS;
420420
}
421421

422-
VOID WINAPI EventTraceHelper::EventRecordCallback(EVENT_RECORD* pEventRecord)
422+
static VOID WINAPI EventRecordCallback(EVENT_RECORD* pEventRecord)
423423
{
424424
// This is where you would get the details of ETW event
425425
DWORD status = ERROR_SUCCESS;
@@ -470,7 +470,7 @@ VOID WINAPI EventTraceHelper::EventRecordCallback(EVENT_RECORD* pEventRecord)
470470
}
471471
}
472472

473-
ULONG WINAPI EventTraceHelper::BufferCallback(PEVENT_TRACE_LOGFILEW pLogFile)
473+
static ULONG WINAPI BufferCallback(PEVENT_TRACE_LOGFILEW pLogFile)
474474
{
475475
return TRUE;
476476
}

Tools/WinMLRunner/src/EventTraceHelper.h

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,5 @@ class EventTraceHelper
3131

3232
private:
3333
static void ProcessEventTrace(PTRACEHANDLE traceHandle);
34-
static ULONG WINAPI BufferCallback(PEVENT_TRACE_LOGFILEW pLogFile);
35-
static VOID WINAPI EventRecordCallback(EVENT_RECORD* pEventRecord);
36-
37-
static void RemoveTrailingSpace(PEVENT_MAP_INFO pMapInfo);
38-
static DWORD GetArraySize(PEVENT_RECORD pEvent, PTRACE_EVENT_INFO pInfo, USHORT i, PUSHORT ArraySize);
39-
static DWORD GetMapInfo(PEVENT_RECORD pEvent, LPWSTR pMapName, DWORD DecodingSource, PEVENT_MAP_INFO& pMapInfo);
40-
static DWORD GetPropertyLength(PEVENT_RECORD pEvent, PTRACE_EVENT_INFO pInfo, USHORT i, PUSHORT PropertyLength);
41-
static DWORD GetEventInformation(PEVENT_RECORD pEvent, PTRACE_EVENT_INFO& pInfo);
42-
static wstring& TrimOperatorName(wstring& s);
43-
static DWORD GetFormatedPropertyData(_In_ const PEVENT_RECORD EventRecord, _In_ const PTRACE_EVENT_INFO EventInfo,
44-
_In_ USHORT Index, _Inout_ PBYTE& UserData, _In_ PBYTE EndOfUserData,
45-
_Inout_ wstring& propertyValue);
46-
static DWORD FormatDataForCPUFallback(_In_ const PEVENT_RECORD EventRecord, _In_ const PTRACE_EVENT_INFO EventInfo);
4734

4835
};

0 commit comments

Comments
 (0)