Skip to content

Commit 55a6b77

Browse files
Ori LevariOri Levari
andauthored
remove Microsoft Engagement Framework package and all usages of it (#302)
Co-authored-by: Ori Levari <[email protected]>
1 parent 40c8862 commit 55a6b77

File tree

5 files changed

+12
-21
lines changed

5 files changed

+12
-21
lines changed

Samples/Emoji8/UWP/cs/Emoji8/Constants.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright (c) Microsoft Corporation.
22
// Licensed under the MIT license.
33

4-
using Microsoft.Services.Store.Engagement;
54
using System;
65
using System.Collections.Generic;
76
using System.Collections.ObjectModel;
@@ -39,7 +38,5 @@ class Constants
3938
public static readonly string TwitterConsumerKey = "";
4039
public static readonly string TwitterConsumerSecret = "";
4140
public static readonly string TwitterCallbackURI = "";
42-
43-
public static StoreServicesCustomEventLogger LOGGER = StoreServicesCustomEventLogger.GetDefault();
4441
}
4542
}

Samples/Emoji8/UWP/cs/Emoji8/Emoji8.csproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,6 @@
208208
<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform">
209209
<Version>6.1.7</Version>
210210
</PackageReference>
211-
<PackageReference Include="Microsoft.Services.Store.Engagement">
212-
<Version>10.1711.28001</Version>
213-
</PackageReference>
214211
<PackageReference Include="Microsoft.Toolkit.Services">
215212
<Version>4.0.0</Version>
216213
</PackageReference>
@@ -231,9 +228,6 @@
231228
</PackageReference>
232229
</ItemGroup>
233230
<ItemGroup>
234-
<SDKReference Include="Microsoft.Services.Store.Engagement, Version=10.0">
235-
<Name>Microsoft Engagement Framework</Name>
236-
</SDKReference>
237231
<SDKReference Include="Microsoft.VCLibs, Version=14.0">
238232
<Name>Visual C++ 2015 Runtime for Universal Windows Platform Apps</Name>
239233
</SDKReference>

Samples/Emoji8/UWP/cs/Emoji8/Pages/MainPage.xaml.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ private async void Start_Click(object sender, RoutedEventArgs e)
7171
Debug.WriteLine("Finished cleaning up MainPage, ready to move onto EmotionPage");
7272
}
7373

74-
Constants.LOGGER.Log(GameText.LOADER.GetString("LoggerStartButtonClicked"));
74+
Debug.WriteLine(GameText.LOADER.GetString("LoggerStartButtonClicked"));
7575
Frame.Navigate(typeof(EmotionPage));
7676
}
7777

Samples/Emoji8/UWP/cs/Emoji8/Pages/ResultsPage.xaml.cs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,10 @@
1616
using Emoji8.Pages.PageHelpers;
1717
using Microsoft.Toolkit.Services.Twitter;
1818
using System.IO;
19-
20-
// The Blank Page item template is documented at https://go.microsoft.com/fwlink/?LinkId=234238
21-
19+
using System.Diagnostics;
20+
21+
// The Blank Page item template is documented at https://go.microsoft.com/fwlink/?LinkId=234238
22+
2223
namespace Emoji8
2324
{
2425
/// <summary>
@@ -124,7 +125,7 @@ private async void PlayAgain(object sender, RoutedEventArgs e)
124125
Gif.Source = null;
125126
brandedGif.Source = null;
126127

127-
Constants.LOGGER.Log(GameText.LOADER.GetString("LoggerPlayAgainClicked"));
128+
Debug.WriteLine(GameText.LOADER.GetString("LoggerPlayAgainClicked"));
128129
Frame.Navigate(typeof(EmotionPage));
129130
}
130131

@@ -133,11 +134,11 @@ private async void ShareButtonClicked(object sender, RoutedEventArgs e)
133134
try
134135
{
135136
await EstablishTwitterUserAsync();
136-
Constants.LOGGER.Log(GameText.LOADER.GetString("LoggerShareToTwitterClicked"));
137+
Debug.WriteLine(GameText.LOADER.GetString("LoggerShareToTwitterClicked"));
137138
}
138139
catch (Exception ex)
139140
{
140-
Constants.LOGGER.Log($"{GameText.LOADER.GetString("LoggerShareToTwitterError")} {ex.Message}");
141+
Debug.WriteLine($"{GameText.LOADER.GetString("LoggerShareToTwitterError")} {ex.Message}");
141142
await MessageDialogService.Current.WriteMessage(GameText.LOADER.GetString("TwitterServiceUnavailable"));
142143
await ReturnScreenToNormalAfterPopupAsync(PostTweetBorder);
143144
return;
@@ -150,7 +151,7 @@ private void ContinueAsLoggedInUserClickedYes(object sender, RoutedEventArgs e)
150151

151152
//confirmed user can now edit Tweet content
152153
CreateTweet();
153-
Constants.LOGGER.Log(GameText.LOADER.GetString("LoggerContinuePostingYesClicked"));
154+
Debug.WriteLine(GameText.LOADER.GetString("LoggerContinuePostingYesClicked"));
154155
}
155156

156157
private async void ContinueAsLoggedInUserClickedNo(object sender, RoutedEventArgs e)
@@ -160,13 +161,13 @@ private async void ContinueAsLoggedInUserClickedNo(object sender, RoutedEventArg
160161
//log out user and prompt then to log in again
161162
TwitterService.Instance.Logout();
162163
await EstablishTwitterUserAsync();
163-
Constants.LOGGER.Log(GameText.LOADER.GetString("LoggerContinuePostingNoClicked"));
164+
Debug.WriteLine(GameText.LOADER.GetString("LoggerContinuePostingNoClicked"));
164165
}
165166

166167
private async void PostTweetClickedCancel(object sender, RoutedEventArgs e)
167168
{
168169
await ReturnScreenToNormalAfterPopupAsync(PostTweetBorder);
169-
Constants.LOGGER.Log(GameText.LOADER.GetString("LoggerPostTweetCancelClicked"));
170+
Debug.WriteLine(GameText.LOADER.GetString("LoggerPostTweetCancelClicked"));
170171
}
171172

172173
private async void PostTweetClickedShare(object sender, RoutedEventArgs e)
@@ -185,7 +186,7 @@ private async void PostTweetClickedShare(object sender, RoutedEventArgs e)
185186
}
186187

187188
await ReturnScreenToNormalAfterPopupAsync(PostTweetBorder);
188-
Constants.LOGGER.Log(GameText.LOADER.GetString("LoggerPostTweetClicked"));
189+
Debug.WriteLine(GameText.LOADER.GetString("LoggerPostTweetClicked"));
189190
}
190191

191192
private async Task ReturnScreenToNormalAfterPopupAsync(UIElement p)

Samples/Emoji8/UWP/cs/Emoji8/Services/IntelligenceService.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ private IntelligenceService() { }
3232
public static IntelligenceService Current => _current ?? (_current = new IntelligenceService());
3333

3434
private LearningModel _model = null;
35-
private LearningModelDevice _device;
3635
private LearningModelSession _session;
3736
private TensorFeatureDescriptor _inputImageDescriptor;
3837
private TensorFeatureDescriptor _outputTensorDescriptor;

0 commit comments

Comments
 (0)