Skip to content

Commit e8db0d9

Browse files
author
Sheil Kumar
committed
pr feedback
1 parent cf69390 commit e8db0d9

File tree

6 files changed

+30
-19
lines changed

6 files changed

+30
-19
lines changed

‎Samples/WinMLSamplesGallery/WinMLSamplesGallery (Package)/Package.appxmanifest‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<Identity
1010
Name="42365107-cbb5-412e-80ac-554e5225ab17"
11-
Publisher="CN=sheil"
11+
Publisher="CN=Windows ML"
1212
Version="1.0.7.0" />
1313

1414
<Properties>

‎Samples/WinMLSamplesGallery/WinMLSamplesGallery/Pages/HomePage.xaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<StackPanel Orientation="Horizontal" HorizontalAlignment="Center" VerticalAlignment="Top" Height="250">
1919
<Image Source="assets/winml_icon.ico" Stretch="UniformToFill" Height="200" VerticalAlignment="Center"/>
2020
<StackPanel Orientation="Vertical" Padding="25,0,0,0" VerticalAlignment="Center">
21-
<TextBlock Foreground="#12bef6" FontSize="60" FontFamily="Segoe UI Light" FontWeight="SemiBold" HorizontalAlignment="Center">Windows AI</TextBlock>
21+
<TextBlock Foreground="#12bef6" FontSize="60" FontFamily="Segoe UI Light" FontWeight="SemiBold" HorizontalAlignment="Center">Windows ML</TextBlock>
2222
<TextBlock Foreground="#12bef6" FontSize="50" FontFamily="Segoe UI Light" FontWeight="SemiBold" HorizontalAlignment="Center">1.9.1</TextBlock>
2323
</StackPanel>
2424
</StackPanel>

‎Samples/WinMLSamplesGallery/WinMLSamplesGallery/Pages/SampleBasePage.xaml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@
2727
<Grid Padding="10">
2828
<TextBlock FontFamily="Segoe UI Light" FontSize="25" Text="{x:Bind sampleMetadata.Title}" TextWrapping="Wrap" />
2929

30-
<Button Style="{StaticResource AccentButtonStyle}" Content="Learn more..." HorizontalAlignment="Right" ToolTipService.ToolTip="Learn more about this sample...">
31-
<Button.Flyout>
32-
<Flyout>
30+
<Button Style="{StaticResource AccentButtonStyle}" Content="Learn more..." HorizontalAlignment="Right" ToolTipService.ToolTip="Learn more about this sample...">
31+
<Button.Flyout>
32+
<Flyout>
3333
<StackPanel Grid.Row="0" Grid.Column="1" HorizontalAlignment="Right">
3434
<TextBlock Typography.Capitals="AllSmallCaps" Typography.StylisticSet4="True" FontFamily="Segoe UI Light" FontSize="20" Margin="0,0,0,5">View source code</TextBlock>
3535
<TextBlock FontSize="14">
@@ -65,9 +65,9 @@
6565
Send feedback about this page
6666
</Hyperlink>
6767
</TextBlock>
68-
</StackPanel>
69-
</Flyout>
70-
</Button.Flyout>
68+
</StackPanel>
69+
</Flyout>
70+
</Button.Flyout>
7171
</Button>
7272
</Grid>
7373
</Border>

‎Samples/WinMLSamplesGallery/WinMLSamplesGallery/SampleMetadata/SampleMetadata.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
"Docs": []
2222
},
2323
{
24-
"Title": "Batching",
24+
"Title": "Batched Inputs",
2525
"DescriptionShort": "Perform infererence over multiple inputs at once to increase runtime performance.",
26-
"Description": "WinML enables batched inputs that allow callers to perform inference over multiple inputs at once in order to increase performance. Use this sample to compare inference runtime performace with and without batching. 50 images will be passed through SqueezeNet for classification.\n\nBy using batch size override further optimizations can be made by the engine to run machine learning models even faster.",
26+
"Description": "Use this sample to compare inference runtime performace with and without batched inputs. 50 images will be passed through SqueezeNet for classification. Set a batch size and click Start Inference to compare.",
2727
"Icon": "\uE155",
2828
"Tag": "Batching",
2929
"XAMLGithubLink": "https://github.com/microsoft/Windows-Machine-Learning/blob/user/sheilk/winml-samples-gallery/Samples/WinMLSamplesGallery/WinMLSamplesGallery/Samples/Batching/Batching.xaml",

‎Samples/WinMLSamplesGallery/WinMLSamplesGallery/Samples/Batching/Batching.xaml‎

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,6 @@
3838
</Page.Resources>
3939

4040
<StackPanel>
41-
<TextBlock Margin="0,10,0,0" FontFamily="Segoe UI Light" FontSize="14" HorizontalAlignment="Left" TextWrapping="Wrap">
42-
In order for batching to work, your model must have a value of -1 or a variable name in the batch dimension.
43-
Additionally, the DATA_BATCH Denotation must be added on the batch dimension. To edit your model you can use tools like
44-
<Hyperlink TextDecorations="None" NavigateUri="{StaticResource WinMLDashboardGithubURL}" ToolTipService.ToolTip="{StaticResource WinMLDashboardGithubURL}">
45-
WinML Dashboard.
46-
</Hyperlink>
47-
</TextBlock>
4841
<StackPanel Orientation="Horizontal" Margin="0,20,0,0">
4942
<TextBlock FontSize="16" Margin="0,5,15,0">Device</TextBlock>
5043
<local_controls:DeviceComboBox x:Name="DeviceComboBox" />
@@ -54,12 +47,28 @@
5447
Start Inference
5548
</Button>
5649
</StackPanel>
57-
<StackPanel x:Name="LoadingContainer" Visibility="Collapsed" Orientation="Horizontal" Margin="0,30,0,0">
50+
<StackPanel x:Name="LoadingContainer" Visibility="Collapsed" Orientation="Horizontal" Margin="0,25,0,0">
5851
<TextBlock x:Name="EvalText" FontFamily="Segoe UI Light" FontSize="14" FontWeight="Bold" Text="Evaluating non-batched Inputs: "/>
5952
<TextBlock x:Name="EvalProgressText" FontFamily="Segoe UI Light" FontSize="14" Margin="20,0,0,0" TextAlignment="Center" />
6053
<ProgressBar x:Name="EvalProgressBar" Width="300" Value="0" Margin="20,0,0,0" />
6154
</StackPanel>
6255
<GridView x:Name="EvalResults" ItemTemplate="{StaticResource EvalResultsTemplate}" />
56+
<TextBlock Margin="0,25,0,0" FontFamily="Segoe UI Light" FontSize="14" HorizontalAlignment="Left" TextWrapping="Wrap">
57+
<Run FontSize="20" >Details</Run>
58+
<LineBreak />
59+
<LineBreak />
60+
The Windows ML API allows callers to perform inference over batched inputs in order to increase performance.
61+
<LineBreak />
62+
<LineBreak />
63+
To use batched inputs, the model must have a value of -1 or a variable name in the input batch dimension.
64+
Additionally, the DATA_BATCH Denotation must be added on the batch dimension. To edit your model you can use tools like
65+
<Hyperlink TextDecorations="None" NavigateUri="{StaticResource WinMLDashboardGithubURL}" ToolTipService.ToolTip="{StaticResource WinMLDashboardGithubURL}">
66+
WinML Dashboard.
67+
</Hyperlink>
68+
<LineBreak />
69+
<LineBreak />
70+
By using batch size override further optimizations can be made by the engine to run machine learning models even faster.
71+
</TextBlock>
6372
<ComboBox SelectedIndex="0" BorderBrush="#dbdbdb" Header="" Width="70" FontSize="18" Margin="0,10,0,0"
6473
Typography.Capitals="AllSmallCaps" Typography.StylisticSet4="True"
6574
HorizontalAlignment="Right">

‎Samples/WinMLSamplesGallery/WinMLSamplesGallery/WinMLSamplesGallery.csproj‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@
2828
<None Remove="Video.xaml" />
2929
</ItemGroup>
3030
<ItemGroup>
31-
<Content Include="SampleMetadata\SampleMetadata.json" />
31+
<Content Include="SampleMetadata\SampleMetadata.json">
32+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
33+
</Content>
3234
<Content Include="InputData\fish.png" />
3335
<Content Include="InputData\hummingbird.jpg" />
3436
<Content Include="InputData\ilsvrc2013.txt" />

0 commit comments

Comments
 (0)