Skip to content

Commit a344d8a

Browse files
committed
Move to Microsoft.Windows.Globalization namespace
1 parent 108def9 commit a344d8a

File tree

8 files changed

+27
-14
lines changed

8 files changed

+27
-14
lines changed

BuildAll.ps1

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,7 @@ Try {
332332
Copy-Item -path "BuildOutput\$configurationForMrtAndAnyCPU\$platformToRun\Microsoft.Windows.ApplicationModel.Resources.Projection\Microsoft.Windows.ApplicationModel.Resources.Projection.dll" -destination "$BasePath\lib\net6.0-windows10.0.17763.0" -force
333333
Copy-Item -path "BuildOutput\$configurationForMrtAndAnyCPU\$platformToRun\Microsoft.Windows.ApplicationModel.Resources.Projection\Microsoft.Windows.ApplicationModel.Resources.Projection.pdb" -destination "$BasePath\lib\net6.0-windows10.0.17763.0" -force
334334
Copy-Item -path "BuildOutput\$configurationForMrtAndAnyCPU\$platformToRun\Microsoft.Windows.ApplicationModel.Resources\Microsoft.Windows.ApplicationModel.Resources.winmd" -destination "$BasePath\lib\uap10.0" -force
335+
Copy-Item -path "BuildOutput\$configurationForMrtAndAnyCPU\$platformToRun\Microsoft.Windows.ApplicationModel.Resources\Microsoft.Windows.Globalization.winmd" -destination "$BasePath\lib\uap10.0" -force
335336
}
336337
}
337338

build/NuSpecs/AppxManifest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
<ActivatableClass ActivatableClassId="Microsoft.Windows.ApplicationModel.Resources.ResourceCandidate" ThreadingModel="both" />
2323
<ActivatableClass ActivatableClassId="Microsoft.Windows.ApplicationModel.Resources.ResourceLoader" ThreadingModel="both" />
2424
<ActivatableClass ActivatableClassId="Microsoft.Windows.ApplicationModel.Resources.ResourceManager" ThreadingModel="both" />
25+
<ActivatableClass ActivatableClassId="Microsoft.Windows.Globalization.ApplicationLanguages" ThreadingModel="both" />
2526
</InProcessServer>
2627
</Extension>
2728
<Extension Category="windows.activatableClass.inProcessServer">

dev/MRTCore/mrt/Microsoft.Windows.ApplicationModel.Resources/projection/Microsoft.Windows.ApplicationModel.Resources.Projection.csproj

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33
<TargetFramework>net6.0-windows10.0.17763.0</TargetFramework>
44
<TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>
@@ -21,7 +21,7 @@
2121
</ItemGroup>
2222

2323
<PropertyGroup>
24-
<CSWinRTIncludes>Microsoft.Windows.ApplicationModel.Resources</CSWinRTIncludes>
24+
<CSWinRTIncludes>Microsoft.Windows.Globalization;Microsoft.Windows.ApplicationModel.Resources</CSWinRTIncludes>
2525
<CSWinRTWindowsMetadata>10.0.17763.0</CSWinRTWindowsMetadata>
2626
<NoWarn>MSB3271</NoWarn>
2727
</PropertyGroup>
@@ -30,10 +30,11 @@
3030
<PropertyGroup Condition="'$(Configuration)'=='Release'">
3131
<DebugType>pdbonly</DebugType>
3232
<DebugSymbols>true</DebugSymbols>
33-
</PropertyGroup>
33+
</PropertyGroup>
3434

3535
<ItemGroup>
3636
<CsWinRTInputs Include="$(OutDir)/**/*.winmd" />
37+
<CsWinRTInputs Include="$(BaseOutputPath)/Microsoft.Windows.ApplicationModel.Resources/Microsoft.Windows.Globalization.winmd" />
3738
</ItemGroup>
3839

3940
<ItemGroup>

dev/MRTCore/mrt/Microsoft.Windows.ApplicationModel.Resources/src/ApplicationLanguages.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33

44
#include "pch.h"
55
#include "ApplicationLanguages.h"
6-
#include "ApplicationLanguages.g.cpp"
6+
#include "Microsoft.Windows.Globalization.ApplicationLanguages.g.cpp"
77

88
#include <winrt/Windows.Globalization.h>
99

1010
#include <AppModel.Identity.h>
1111

1212
#include "Helper.h"
1313

14-
namespace winrt::Microsoft::Windows::ApplicationModel::Resources::implementation
14+
namespace winrt::Microsoft::Windows::Globalization::implementation
1515
{
1616
hstring ApplicationLanguages::m_language;
1717

@@ -44,7 +44,7 @@ namespace winrt::Microsoft::Windows::ApplicationModel::Resources::implementation
4444
{
4545
bool isValidLanguageTag = IsWellFormedLanguageTag(language.c_str());
4646

47-
THROW_HR_IF_MSG(E_INVALIDARG, isValidLanguageTag, "The parameter is incorrect");
47+
THROW_HR_IF_MSG(E_INVALIDARG, !isValidLanguageTag, "The parameter is incorrect");
4848

4949
static wil::srwlock lock;
5050

@@ -56,4 +56,4 @@ namespace winrt::Microsoft::Windows::ApplicationModel::Resources::implementation
5656
winrt::Windows::Globalization::ApplicationLanguages::PrimaryLanguageOverride(language);
5757
}
5858
}
59-
} // namespace winrt::Microsoft::Windows::ApplicationModel::Resources::implementation
59+
} // namespace winrt::Microsoft::Windows::Globalization::implementation

dev/MRTCore/mrt/Microsoft.Windows.ApplicationModel.Resources/src/ApplicationLanguages.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
// Licensed under the MIT License.
33

44
#pragma once
5-
#include "ApplicationLanguages.g.h"
5+
#include "Microsoft.Windows.Globalization.ApplicationLanguages.g.h"
66

7-
namespace winrt::Microsoft::Windows::ApplicationModel::Resources::implementation
7+
namespace winrt::Microsoft::Windows::Globalization::implementation
88
{
99
struct ApplicationLanguages
1010
{
@@ -18,11 +18,11 @@ namespace winrt::Microsoft::Windows::ApplicationModel::Resources::implementation
1818
private:
1919
static hstring m_language;
2020
};
21-
} // namespace winrt::Microsoft::Windows::ApplicationModel::Resources::implementation
21+
} // namespace winrt::Microsoft::Windows::Globalization::implementation
2222

23-
namespace winrt::Microsoft::Windows::ApplicationModel::Resources::factory_implementation
23+
namespace winrt::Microsoft::Windows::Globalization::factory_implementation
2424
{
2525
struct ApplicationLanguages : ApplicationLanguagesT<ApplicationLanguages, implementation::ApplicationLanguages>
2626
{
2727
};
28-
} // namespace winrt::Microsoft::Windows::ApplicationModel::Resources::factory_implementation
28+
} // namespace winrt::Microsoft::Windows::Globalization::factory_implementation

dev/MRTCore/mrt/Microsoft.Windows.ApplicationModel.Resources/src/Helper.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ bool IsWellFormedLanguageTag(const wchar_t* languageTag)
100100

101101
while (ok && (*test != L'\0'))
102102
{
103-
// we accept letters, numbers, dash and semi-colon (as list separator)
103+
// we accept letters, numbers and dash
104104
if (((*test >= L'0') && (*test <= L'9')) || ((*test >= L'a') && (*test <= L'z')) || ((*test >= L'A') && (*test <= L'Z')) ||
105105
(*test == L'-'))
106106
{

dev/MRTCore/mrt/Microsoft.Windows.ApplicationModel.Resources/src/Microsoft.Windows.ApplicationModel.Resources.idl

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,12 @@ namespace Microsoft.Windows.ApplicationModel.Resources
113113
static String TargetSize { get; };
114114
static String Theme { get; };
115115
}
116+
} // namespace Microsoft.Windows.ApplicationModel.Resources
117+
118+
namespace Microsoft.Windows.Globalization
119+
{
120+
[contractversion(1)]
121+
apicontract MrtCoreContract{};
116122

117123
[contract(MrtCoreContract, 2)]
118124
runtimeclass ApplicationLanguages
@@ -122,4 +128,4 @@ namespace Microsoft.Windows.ApplicationModel.Resources
122128
static String PrimaryLanguageOverride;
123129
}
124130

125-
} // namespace Microsoft.Windows.ApplicationModel. Resources
131+
} // namespace Microsoft.Windows.Globalization

dev/MRTCore/mrt/Microsoft.Windows.ApplicationModel.Resources/src/ResourceContext.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@
88

99
const wchar_t c_languageQualifierName[] = L"Language";
1010

11+
#include "ApplicationLanguages.h"
12+
13+
using namespace winrt::Microsoft::Windows::Globalization;
14+
1115
namespace winrt::Microsoft::Windows::ApplicationModel::Resources::implementation
1216
{
1317
void ResourceContext::InitializeQualifierNames()

0 commit comments

Comments
 (0)