feat(implement-new-checks): enable aria-allowed-role, presentation-role-conflict, and p-as-heading (#6030)

#### Details

This PR adds:
- `aria-allowed-role` and `presentation-role-conflict` as automated
check rules
<img width="1004" alt="aria-allowed-role and presentation-role-conflict
in FastPass' automated checks"
src="https://user-images.githubusercontent.com/18401275/190701565-78ee4e28-cf75-4884-bdfb-1bac395de8bb.png">

- `p-as-heading` as a needs review rule 
<img width="1208" alt="p-as-heading in FastPass' Needs Review"
src="https://user-images.githubusercontent.com/18401275/190701351-e58e9a3c-57cf-48d0-84d2-3167a53eaa5d.png">


##### Motivation

Feature 1981768 🪄

##### Context
<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue: 1986752
- [x] Ran `yarn null:autoadd`
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [x] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS

Author: shanisebarona

src/ad-hoc-visualizations/needs-review/visualization.tsx

@@ -23,6 +23,7 @@ const needsReviewRuleAnalyzerConfiguration: RuleAnalyzerConfiguration = {
         'link-in-text-block',
         'scrollable-region-focusable',
         'label-content-name-mismatch',
+        'p-as-heading',
     ],
     resultProcessor: (scanner: ScannerUtils) => scanner.getFailingInstances,
     telemetryProcessor: (telemetryFactory: TelemetryDataFactory) =>

src/common/components/cards/rich-resolution-content.tsx

@@ -318,6 +318,15 @@ export const RichResolutionContent = NamedFC<RichResolutionContentProps>(
                     </span>
                 );
             }
+            case 'web/p-as-heading': {
+                return (
+                    <span>
+                        Inspect the {`<p>`} element and verify that the element is not used as a
+                        heading through visual styling with bold, italic text or font-size. If
+                        headings are needed, use the appropriate heading tags.
+                    </span>
+                );
+            }
             default: {
                 throw new Error(
                     `Cannot render RichResolutionContent with unrecognized contentId ${contentId}`,

src/scanner/get-rule-inclusions.ts

@@ -28,6 +28,14 @@ export const explicitRuleOverrides: DictionaryStringTo<RuleIncluded> = {
         status: 'excluded',
         reason: 'only reports to needs-review results due to potential false-positives',
     },
+    'aria-allowed-role': {
+        status: 'included',
+        reason: 'best practice rule that was investigated with no known false positives, implemented as an automated check.',
+    },
+    'presentation-role-conflict': {
+        status: 'included',
+        reason: 'best practice rule that was investigated with no known false positives, implemented as an automated check.',
+    },
 };
 
 export const getRuleInclusions = (

src/tests/end-to-end/tests/details-view/cross-origin-iframe.test.ts

@@ -76,11 +76,12 @@ describe('scanning', () => {
                 fastPassAutomatedChecksSelectors.ruleDetail,
             );
 
-            expect(ruleDetails).toHaveLength(4);
+            expect(ruleDetails).toHaveLength(5);
 
             const expectedCounts = {
                 'frame-title': 2,
                 'html-has-lang': 1,
+                'aria-allowed-role': 2,
                 'image-alt': 9,
                 label: 3,
             };

src/tests/unit/tests/common/components/cards/__snapshots__/rich-resolution-content.test.tsx.snap

@@ -398,6 +398,14 @@ exports[`RichResolutionContent renders static content with id=web/link-in-text-b
 </ul>
 `;
 
+exports[`RichResolutionContent renders static content with id=web/p-as-heading 1`] = `
+<span>
+  Inspect the 
+  &lt;p&gt;
+   element and verify that the element is not used as a heading through visual styling with bold, italic text or font-size. If headings are needed, use the appropriate heading tags.
+</span>
+`;
+
 exports[`RichResolutionContent renders static content with id=web/scrollable-region-focusable 1`] = `
 <span>
   Examine the element and ensure that, if there is scrollable content, the elements are accessible by keyboard.

src/tests/unit/tests/common/components/cards/rich-resolution-content.test.tsx

@@ -26,6 +26,7 @@ describe('RichResolutionContent', () => {
         'web/link-in-text-block',
         'web/scrollable-region-focusable',
         'web/label-content-name-mismatch',
+        'web/p-as-heading',
         'android/atfa/ClassNameCheck',
         'android/atfa/ClickableSpanCheck',
         'android/atfa/DuplicateClickableBoundsCheck',

src/tests/unit/tests/common/self-fast-pass.test.ts

@@ -74,6 +74,7 @@ describe('SelfFastPass', () => {
                             'link-in-text-block',
                             'scrollable-region-focusable',
                             'label-content-name-mismatch',
+                            'p-as-heading',
                         ],
                     },
                     It.isAny(),

src/tests/unit/tests/scanner/__snapshots__/get-rule-inclusions.test.ts.snap

@@ -13,8 +13,8 @@ exports[`getRuleInclusions matches snapshotted list of production rules 1`] = `
     "status": "included",
   },
   "aria-allowed-role": {
-    "reason": "rule is tagged best-practice",
-    "status": "excluded",
+    "reason": "best practice rule that was investigated with no known false positives, implemented as an automated check.",
+    "status": "included",
   },
   "aria-command-name": {
     "status": "included",
@@ -279,8 +279,8 @@ exports[`getRuleInclusions matches snapshotted list of production rules 1`] = `
     "status": "excluded",
   },
   "presentation-role-conflict": {
-    "reason": "rule is tagged best-practice",
-    "status": "excluded",
+    "reason": "best practice rule that was investigated with no known false positives, implemented as an automated check.",
+    "status": "included",
   },
   "region": {
     "reason": "rule is tagged best-practice",