fix(automated-checks): needs review data missing in details view (#6548)

#### Details

Needs review card view data was not being calculated correctly, this
fixes that. Also improves tests to catch this issue if it were to happen
again.

##### Motivation

Feature work.

##### Context

n/a

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [ ] Addresses an existing issue: #0000
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [ ] (UI changes only) Added screenshots/GIFs to description above
- [ ] (UI changes only) Verified usability with NVDA/JAWS

Author: waabid

src/DetailsView/components/details-view-content.tsx

@@ -10,7 +10,7 @@ import { NamedFC } from 'common/react/named-fc';
 import { GetCardViewData } from 'common/rule-based-view-model-provider';
 import {
     ConvertAssessmentStoreDataToScanNodeResultsCallback,
-    convertUnifiedStoreDataToScanNodeResults,
+    ConvertUnifiedStoreDataToScanNodeResultsCallback,
 } from 'common/store-data-to-scan-node-result-converter';
 import { ScanMetadata } from 'common/types/store-data/unified-data-interface';
 import {
@@ -52,6 +52,7 @@ export type DetailsViewContentDeps = {
     testViewContainerProvider: TestViewContainerProvider;
     defaultRulesMap: ScannerRuleInfoMap;
     convertAssessmentStoreDataToScanNodeResults: ConvertAssessmentStoreDataToScanNodeResultsCallback;
+    convertUnifiedStoreDataToScanNodeResults: ConvertUnifiedStoreDataToScanNodeResultsCallback;
 } & InteractiveHeaderDeps &
     DetailsViewOverlayDeps &
     DetailsViewBodyDeps;
@@ -118,7 +119,7 @@ export const DetailsViewContent = NamedFC<DetailsViewContentProps>('DetailsViewC
         const selectedTest =
             selectedDetailsViewSwitcherNavConfiguration.getSelectedDetailsView(storeState);
 
-        const unifiedScanNodeResults = convertUnifiedStoreDataToScanNodeResults(
+        const unifiedScanNodeResults = deps.convertUnifiedStoreDataToScanNodeResults(
             props.storeState.unifiedScanResultStoreData,
         );
         const automatedChecksCardsViewData = props.deps.getCardViewData(
@@ -134,8 +135,12 @@ export const DetailsViewContent = NamedFC<DetailsViewContentProps>('DetailsViewC
         const tabStopRequirementData =
             props.storeState.visualizationScanResultStoreData.tabStops.requirements;
 
+        const needsReviewScanNodeResults = deps.convertUnifiedStoreDataToScanNodeResults(
+            props.storeState.needsReviewScanResultStoreData,
+        );
+
         const needsReviewCardsViewData = props.deps.getCardViewData(
-            unifiedScanNodeResults,
+            needsReviewScanNodeResults,
             props.deps.getCardSelectionViewData(
                 props.storeState.needsReviewCardSelectionStoreData,
                 props.storeState.needsReviewScanResultStoreData.results,

src/DetailsView/details-view-initializer.ts

@@ -39,7 +39,10 @@ import { AutomatedChecksCardSelectionMessageCreator } from 'common/message-creat
 import { NeedsReviewCardSelectionMessageCreator } from 'common/message-creators/needs-review-card-selection-message-creator';
 import { Messages } from 'common/messages';
 import { getNarrowModeThresholdsForWeb } from 'common/narrow-mode-thresholds';
-import { convertAssessmentStoreDataToScanNodeResults } from 'common/store-data-to-scan-node-result-converter';
+import {
+    convertAssessmentStoreDataToScanNodeResults,
+    convertUnifiedStoreDataToScanNodeResults,
+} from 'common/store-data-to-scan-node-result-converter';
 import { ClientStoresHub } from 'common/stores/client-stores-hub';
 import { ExceptionTelemetryListener } from 'common/telemetry/exception-telemetry-listener';
 import { ExceptionTelemetrySanitizer } from 'common/telemetry/exception-telemetry-sanitizer';
@@ -735,6 +738,7 @@ if (tabId != null) {
                 testViewContainerProvider,
                 defaultRulesMap: getDefaultRulesMap(),
                 convertAssessmentStoreDataToScanNodeResults,
+                convertUnifiedStoreDataToScanNodeResults,
             };
 
             const renderer = new DetailsViewRenderer(

src/tests/unit/tests/DetailsView/__snapshots__/details-view-content.test.tsx.snap

@@ -6,6 +6,7 @@ exports[`DetailsViewContent render renders normally 1`] = `
     deps={
       {
         "convertAssessmentStoreDataToScanNodeResults": [Function],
+        "convertUnifiedStoreDataToScanNodeResults": [Function],
         "defaultRulesMap": {
           "some-rule": {
             "a11yCriteria": null,
@@ -75,6 +76,7 @@ exports[`DetailsViewContent render renders normally 1`] = `
     deps={
       {
         "convertAssessmentStoreDataToScanNodeResults": [Function],
+        "convertUnifiedStoreDataToScanNodeResults": [Function],
         "defaultRulesMap": {
           "some-rule": {
             "a11yCriteria": null,
@@ -125,7 +127,8 @@ exports[`DetailsViewContent render renders normally 1`] = `
     }
     needsReviewCardsViewData={
       {
-        "allCardsCollapsed": false,
+        "allCardsCollapsed": true,
+        "visualHelperEnabled": true,
       }
     }
     pathSnippetStoreData={
@@ -477,6 +480,7 @@ exports[`DetailsViewContent render renders normally 1`] = `
     deps={
       {
         "convertAssessmentStoreDataToScanNodeResults": [Function],
+        "convertUnifiedStoreDataToScanNodeResults": [Function],
         "defaultRulesMap": {
           "some-rule": {
             "a11yCriteria": null,

src/tests/unit/tests/DetailsView/details-view-content.test.tsx

@@ -13,6 +13,8 @@ import { GetCardViewData } from 'common/rule-based-view-model-provider';
 import {
     convertAssessmentStoreDataToScanNodeResults,
     ConvertAssessmentStoreDataToScanNodeResultsCallback,
+    convertUnifiedStoreDataToScanNodeResults,
+    ConvertUnifiedStoreDataToScanNodeResultsCallback,
     ScanNodeResult,
 } from 'common/store-data-to-scan-node-result-converter';
 import { ClientStoresHub } from 'common/stores/client-stores-hub';
@@ -67,6 +69,7 @@ describe(DetailsViewContent.displayName, () => {
     let getDetailsSwitcherNavConfiguration: IMock<GetDetailsSwitcherNavConfiguration>;
     let visualizationConfigurationFactoryMock: IMock<VisualizationConfigurationFactory>;
     let getCardViewDataMock: IMock<GetCardViewData>;
+    let convertUnifiedStoreDataToScanNodeResultsMock: IMock<ConvertUnifiedStoreDataToScanNodeResultsCallback>;
     let convertAssessmentStoreDataToScanNodeResultsMock: IMock<ConvertAssessmentStoreDataToScanNodeResultsCallback>;
     let getCardSelectionViewDataMock: IMock<GetCardSelectionViewData>;
     let targetAppInfo: TargetAppData;
@@ -96,6 +99,10 @@ describe(DetailsViewContent.displayName, () => {
             convertAssessmentStoreDataToScanNodeResults,
             MockBehavior.Strict,
         );
+        convertUnifiedStoreDataToScanNodeResultsMock = Mock.ofInstance(
+            convertUnifiedStoreDataToScanNodeResults,
+            MockBehavior.Strict,
+        );
         getCardSelectionViewDataMock = Mock.ofInstance(
             (storeData: CardSelectionStoreData) => null,
             MockBehavior.Strict,
@@ -136,6 +143,8 @@ describe(DetailsViewContent.displayName, () => {
             getDateFromTimestamp: getDateFromTimestampMock.object,
             getAssessmentInstanceTableHandler: () => assessmentInstanceTableHandlerMock.object,
             visualizationConfigurationFactory: visualizationConfigurationFactoryMock.object,
+            convertUnifiedStoreDataToScanNodeResults:
+                convertUnifiedStoreDataToScanNodeResultsMock.object,
             convertAssessmentStoreDataToScanNodeResults:
                 convertAssessmentStoreDataToScanNodeResultsMock.object,
             defaultRulesMap: defaultRulesMapStub,
@@ -293,22 +302,48 @@ describe(DetailsViewContent.displayName, () => {
                 .setup(vcfm => vcfm.getConfiguration(viewType))
                 .returns(() => configStub);
 
-            const cardsViewDataStub: CardsViewModel = {
+            const unifiedCardsViewDataStub: CardsViewModel = {
                 allCardsCollapsed: false,
             } as CardsViewModel;
+            const needsReviewCardsViewDataStub: CardsViewModel = {
+                allCardsCollapsed: true,
+                visualHelperEnabled: true,
+            } as CardsViewModel;
             const assessmentCardsViewDataStub: CardsViewModel = {
                 allCardsCollapsed: true,
             } as CardsViewModel;
 
-            const scanNodeResultsStub = [
+            const assessmentScanNodeResultsStub = [
+                {
+                    ruleId: 'some-assessment-rule-id',
+                },
+            ] as ScanNodeResult[];
+            const unifiedScanNodeResultsStub = [
                 {
-                    ruleId: 'some-rule-id',
+                    ruleId: 'some-unified-scan-rule-id',
                 },
             ] as ScanNodeResult[];
+            const needsReviewScanNodeResultsStub = [
+                {
+                    ruleId: 'some-needs-review-rule-id',
+                },
+            ] as ScanNodeResult[];
+
+            convertUnifiedStoreDataToScanNodeResultsMock
+                .setup(m => m(state.unifiedScanResultStoreData))
+                .returns(() => unifiedScanNodeResultsStub);
+            convertUnifiedStoreDataToScanNodeResultsMock
+                .setup(m => m(state.needsReviewScanResultStoreData))
+                .returns(() => needsReviewScanNodeResultsStub);
 
             getCardSelectionViewDataMock
                 .setup(g =>
-                    g(undefined, scanNodeResultsStub, null, isResultHighlightUnavailableStub),
+                    g(
+                        undefined,
+                        assessmentScanNodeResultsStub,
+                        null,
+                        isResultHighlightUnavailableStub,
+                    ),
                 )
                 .returns(() => cardSelectionViewData)
                 .verifiable(Times.exactly(1));
@@ -322,19 +357,19 @@ describe(DetailsViewContent.displayName, () => {
                         defaultRulesMapStub,
                     ),
                 )
-                .returns(() => scanNodeResultsStub);
+                .returns(() => assessmentScanNodeResultsStub);
 
             getCardViewDataMock
-                .setup(m => m(scanNodeResultsStub, cardSelectionViewData))
+                .setup(m => m(assessmentScanNodeResultsStub, cardSelectionViewData))
                 .returns(() => assessmentCardsViewDataStub);
 
             getCardViewDataMock
-                .setup(m => m([], cardSelectionViewData))
-                .returns(() => cardsViewDataStub);
+                .setup(m => m(unifiedScanNodeResultsStub, cardSelectionViewData))
+                .returns(() => unifiedCardsViewDataStub);
 
             getCardViewDataMock
-                .setup(m => m(null, cardSelectionViewData))
-                .returns(() => cardsViewDataStub);
+                .setup(m => m(needsReviewScanNodeResultsStub, cardSelectionViewData))
+                .returns(() => needsReviewCardsViewDataStub);
 
             const rendered = shallow(
                 <DetailsViewContent