feat(andsvc-protocol): Update Android Service communication to use new protocol (#4617)

#### Details
This PR updates the AI-Android client to interact with the Android Service using [its new protocol](microsoft/accessibility-insights-for-android-service#126). To do this, all interaction with the service now occurs via ADB rather than a mix of HTTP requests and ADB. Minor changes were made to the setup workflow as port forwarding is no longer applicable, but the overall user impact is minimal.

Some of the work to achieve this includes:
-  add adb commands to communicate with the new content provider (readContent and callContent)
-  create new DeviceCommunicator class that sends commands to the device after setup (implementation details like the specific focus commands and content types (config/result) live here instead of in the adb wrapper)
-  adapt the ServiceConfigurator into a DeviceConfigurator for commands sent to the device during setup (includes some refactoring of grantOverlayPermissions to move logic out of the adb wrapper)
-  replace classes that call http endpoints with calls to the DeviceCommunicator
-  remove port forwarding calls but leave obsolete code for now
-  update unit tests and snapshots
-  update e2e tests and snapshots

##### Motivation
Maintain compatibility with the new Android Service version.

##### Context
Credit to @madalynrose for the implementation

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox -->
- [n/a] Addresses an existing issue: #0000
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`.
- [n/a] (UI changes only) Added screenshots/GIFs to description above
- [n/a] (UI changes only) Verified usability with NVDA/JAWS

Author: jalkire

package.json

@@ -168,7 +168,7 @@
         "webpack-node-externals": "^3.0.0"
     },
     "dependencies": {
-        "accessibility-insights-for-android-service-bin": "1.4.0",
+        "accessibility-insights-for-android-service-bin": "2.0.0",
         "ajv": "^8.6.2",
         "android-device-list": "^1.2.7",
         "appium-adb": "^8.13.2",
@@ -183,7 +183,6 @@
         "lodash": "^4.17.21",
         "luxon": "^2.0.2",
         "office-ui-fabric-react": "7.98.0",
-        "portfinder": "^1.0.28",
         "react": "^16.14.0",
         "react-copy-to-clipboard": "^5.0.4",
         "react-dom": "^16.14.0",

src/common/extension-telemetry-events.ts

@@ -194,12 +194,10 @@ export type NeedsReviewAnalyzerScanTelemetryData = {
     incompleteRuleResults: string;
 } & RuleAnalyzerScanTelemetryData;
 
-export type PortTelemetryData = {
-    port: number;
+export type AndroidScanStartedTelemetryData = {
+    source: TelemetryEventSource;
 };
-
 export type AndroidScanCompletedTelemetryData = {
-    port: number;
     scanDuration: number;
 } & InstanceCount;
 
@@ -231,7 +229,7 @@ export type AtfaInstanceCount = {
 };
 
 export type AndroidScanFailedTelemetryData = {
-    port: number;
+    port?: number;
     scanDuration: number;
 };
 
@@ -267,7 +265,7 @@ export type TelemetryData =
     | IssuesAnalyzerScanTelemetryData
     | AssessmentRequirementScanTelemetryData
     | RequirementStatusTelemetryData
-    | PortTelemetryData
+    | AndroidScanStartedTelemetryData
     | AndroidScanCompletedTelemetryData
     | AndroidScanFailedTelemetryData
     | DeviceFocusKeyEventTelemetryData

src/electron/flux/action-creator/scan-action-creator.ts

@@ -9,8 +9,8 @@ export class ScanActionCreator {
         private readonly deviceConnectionActions: DeviceConnectionActions,
     ) {}
 
-    public scan(port: number): void {
+    public scan(): void {
         this.deviceConnectionActions.statusUnknown.invoke();
-        this.scanActions.scanStarted.invoke({ port });
+        this.scanActions.scanStarted.invoke();
     }
 }

src/electron/flux/action/device-action-payloads.ts

@@ -1,8 +1,5 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
-export interface PortPayload {
-    port: number;
-}
 
 export interface ConnectedDevicePayload {
     connectedDevice: string;

src/electron/flux/action/scan-actions.ts

@@ -1,10 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 import { Action } from 'common/flux/action';
-import { PortPayload } from 'electron/flux/action/device-action-payloads';
 
 export class ScanActions {
-    public readonly scanStarted = new Action<PortPayload>();
+    public readonly scanStarted = new Action<void>();
     public readonly scanCompleted = new Action<void>();
     public readonly scanFailed = new Action<void>();
 }

src/electron/flux/store/android-setup-store.ts

@@ -26,8 +26,6 @@ export class AndroidSetupStore extends BaseStoreImpl<AndroidSetupStoreData> {
         this.stateMachine = this.createAndroidSetupStateMachine(this.stepTransition, {
             setSelectedDevice: this.setSelectedDevice,
             setAvailableDevices: this.setAvailableDevices,
-            getScanPort: () => this.state.scanPort,
-            setScanPort: this.setScanPort,
             setApplicationName: this.setApplicationName,
         });
     }
@@ -69,11 +67,6 @@ export class AndroidSetupStore extends BaseStoreImpl<AndroidSetupStoreData> {
         this.state.availableDevices = devices;
     };
 
-    private setScanPort = (scanPort?: number): void => {
-        // emitChange will be called from step transition when the step changes
-        this.state.scanPort = scanPort;
-    };
-
     private setApplicationName = (appName?: string): void => {
         // emitChange will be called from step transition when the step changes
         this.state.applicationName = appName;

src/electron/flux/types/android-setup-state-machine-types.ts

@@ -13,8 +13,6 @@ export type AndroidSetupStepTransitionCallback = (nextStep: AndroidSetupStepId)
 export type AndroidSetupStoreCallbacks = {
     setSelectedDevice: (device: DeviceInfo) => void;
     setAvailableDevices: (devices: DeviceInfo[]) => void;
-    getScanPort: () => number | undefined;
-    setScanPort: (scanPort?: number) => void;
     setApplicationName: (appName?: string) => void;
 };
 

src/electron/flux/types/android-setup-store-data.ts

@@ -10,6 +10,5 @@ export type AndroidSetupStoreData = {
     selectedDevice?: DeviceInfo;
     availableDevices?: DeviceInfo[];
 
-    scanPort?: number;
     applicationName?: string;
 };

src/electron/platform/android/adb-wrapper.ts

@@ -27,10 +27,11 @@ export interface AdbWrapper {
     getDumpsysOutput(deviceId: string, serviceToQuery: string): Promise<string>;
     installService(deviceId: string, apkLocation: string): Promise<void>;
     uninstallService(deviceId: string, packageName: string): Promise<void>;
-    setTcpForwarding(deviceId: string, localPort: number, devicePort: number): Promise<number>;
-    removeTcpForwarding(deviceId: string, devicePort: number): Promise<void>;
     sendKeyEvent(deviceId: string, keyEventCode: KeyEventCode): Promise<void>;
-    grantOverlayPermission: (deviceId: string, packageName: string) => Promise<void>;
+    grantPermission(deviceId: string, packageName: string, permission: string): Promise<void>;
+    hasPermission(deviceId: string, permissionName: string, matchString: string): Promise<boolean>;
+    readContent: (deviceId: string, contentUri: string) => Promise<string>;
+    callContent: (deviceId: string, contentUri: string, method: string) => Promise<void>;
 }
 
 export interface AdbWrapperFactory {

src/electron/platform/android/android-service-apk-locator.ts

@@ -3,6 +3,7 @@
 import * as path from 'path';
 import { apkVersionName } from 'accessibility-insights-for-android-service-bin';
 
+export const AndroidServicePackageName = 'com.microsoft.accessibilityinsightsforandroidservice';
 export type AndroidServiceApkInfo = {
     path: string;
     versionName: string;