Skip to content

Commit 5524aef

Browse files
waabidwaabid
authored
fix: unset heading margin under heading element for level component (#5355)
* fix: unset heading margin under heading element for level component * updated snapshots * updated snapshots
1 parent afcb44c commit 5524aef

11 files changed

+90
-41
lines changed

‎packages/report-e2e-tests/src/examples/axe-results-with-issues.snap.html‎

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -791,6 +791,10 @@
791791
margin-bottom: unset;
792792
}</style
793793
><style>
794+
.heading-element-for-level--OfRDW {
795+
margin-block-start: unset;
796+
margin-block-end: unset;
797+
}
794798
.failed-instances-container--FqWV6 .collapsible-content {
795799
margin-left: 24px;
796800
}
@@ -1803,7 +1807,7 @@
18031807
><div
18041808
class="failed-instances-container--FqWV6 result-section--j6fYr"
18051809
data-automation-id="result-section"
1806-
><h2
1810+
><h2 class="heading-element-for-level--OfRDW"
18071811
><span class="result-section-title--qv3MK"
18081812
><span class="screen-reader-only">Failed instances 26</span
18091813
><span class="title--neMma" aria-hidden="true"
@@ -1841,7 +1845,7 @@
18411845
data-automation-id="rule-details-group"
18421846
><div
18431847
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
1844-
><h3 class="title-container"
1848+
><h3 class="heading-element-for-level--OfRDW title-container"
18451849
><button
18461850
class="collapsible-control"
18471851
aria-expanded="false"
@@ -1971,7 +1975,7 @@
19711975
></div
19721976
><div
19731977
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
1974-
><h3 class="title-container"
1978+
><h3 class="heading-element-for-level--OfRDW title-container"
19751979
><button
19761980
class="collapsible-control"
19771981
aria-expanded="false"
@@ -2512,7 +2516,7 @@
25122516
></div
25132517
><div
25142518
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
2515-
><h3 class="title-container"
2519+
><h3 class="heading-element-for-level--OfRDW title-container"
25162520
><button
25172521
class="collapsible-control"
25182522
aria-expanded="false"
@@ -2639,7 +2643,7 @@
26392643
></div
26402644
><div
26412645
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
2642-
><h3 class="title-container"
2646+
><h3 class="heading-element-for-level--OfRDW title-container"
26432647
><button
26442648
class="collapsible-control"
26452649
aria-expanded="false"
@@ -2967,7 +2971,7 @@
29672971
></div
29682972
><div
29692973
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
2970-
><h3 class="title-container"
2974+
><h3 class="heading-element-for-level--OfRDW title-container"
29712975
><button
29722976
class="collapsible-control"
29732977
aria-expanded="false"
@@ -3775,7 +3779,7 @@
37753779
></div
37763780
><div
37773781
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
3778-
><h3 class="title-container"
3782+
><h3 class="heading-element-for-level--OfRDW title-container"
37793783
><button
37803784
class="collapsible-control"
37813785
aria-expanded="false"
@@ -3902,7 +3906,7 @@
39023906
></div
39033907
><div
39043908
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
3905-
><h3 class="title-container"
3909+
><h3 class="heading-element-for-level--OfRDW title-container"
39063910
><button
39073911
class="collapsible-control"
39083912
aria-expanded="false"
@@ -4028,7 +4032,7 @@
40284032
></div
40294033
><div
40304034
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
4031-
><h3 class="title-container"
4035+
><h3 class="heading-element-for-level--OfRDW title-container"
40324036
><button
40334037
class="collapsible-control"
40344038
aria-expanded="false"
@@ -4156,7 +4160,7 @@
41564160
></div
41574161
><div class="result-section"
41584162
><div class="collapsible-container collapsed"
4159-
><h2 class="title-container"
4163+
><h2 class="heading-element-for-level--OfRDW title-container"
41604164
><button
41614165
class="collapsible-control"
41624166
aria-expanded="false"
@@ -4705,7 +4709,7 @@
47054709
></div
47064710
><div class="result-section"
47074711
><div class="collapsible-container collapsed"
4708-
><h2 class="title-container"
4712+
><h2 class="heading-element-for-level--OfRDW title-container"
47094713
><button
47104714
class="collapsible-control"
47114715
aria-expanded="false"

‎packages/report-e2e-tests/src/examples/axe-results-without-issues.snap.html‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -791,6 +791,10 @@
791791
margin-bottom: unset;
792792
}</style
793793
><style>
794+
.heading-element-for-level--OfRDW {
795+
margin-block-start: unset;
796+
margin-block-end: unset;
797+
}
794798
.failed-instances-container--FqWV6 .collapsible-content {
795799
margin-left: 24px;
796800
}
@@ -1803,7 +1807,7 @@
18031807
><div
18041808
class="failed-instances-container--FqWV6 result-section--j6fYr"
18051809
data-automation-id="result-section"
1806-
><h2
1810+
><h2 class="heading-element-for-level--OfRDW"
18071811
><span class="result-section-title--qv3MK"
18081812
><span class="screen-reader-only">Failed instances 0</span
18091813
><span class="title--neMma" aria-hidden="true"
@@ -1837,7 +1841,7 @@
18371841
></div
18381842
><div class="result-section"
18391843
><div class="collapsible-container collapsed"
1840-
><h2 class="title-container"
1844+
><h2 class="heading-element-for-level--OfRDW title-container"
18411845
><button
18421846
class="collapsible-control"
18431847
aria-expanded="false"
@@ -3024,7 +3028,7 @@
30243028
></div
30253029
><div class="result-section"
30263030
><div class="collapsible-container collapsed"
3027-
><h2 class="title-container"
3031+
><h2 class="heading-element-for-level--OfRDW title-container"
30283032
><button
30293033
class="collapsible-control"
30303034
aria-expanded="false"

‎packages/report-e2e-tests/src/examples/combined-results-with-baseline-aware-issues.snap.html‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -791,6 +791,10 @@
791791
margin-bottom: unset;
792792
}</style
793793
><style>
794+
.heading-element-for-level--OfRDW {
795+
margin-block-start: unset;
796+
margin-block-end: unset;
797+
}
794798
.failed-instances-container--FqWV6 .collapsible-content {
795799
margin-left: 24px;
796800
}
@@ -1792,7 +1796,7 @@
17921796
><div class="results-heading--pyS7R"><h2>Rules</h2></div
17931797
><div class="result-section"
17941798
><div class="collapsible-container collapsed"
1795-
><h3 class="title-container"
1799+
><h3 class="heading-element-for-level--OfRDW title-container"
17961800
><button
17971801
class="collapsible-control"
17981802
aria-expanded="false"
@@ -1813,7 +1817,8 @@
18131817
data-automation-id="rule-details-group"
18141818
><div
18151819
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
1816-
><h4 class="title-container"
1820+
><h4
1821+
class="heading-element-for-level--OfRDW title-container"
18171822
><button
18181823
class="collapsible-control"
18191824
aria-expanded="false"
@@ -2171,7 +2176,8 @@
21712176
></div
21722177
><div
21732178
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
2174-
><h4 class="title-container"
2179+
><h4
2180+
class="heading-element-for-level--OfRDW title-container"
21752181
><button
21762182
class="collapsible-control"
21772183
aria-expanded="false"
@@ -2482,7 +2488,7 @@
24822488
></div
24832489
><div class="result-section"
24842490
><div class="collapsible-container collapsed"
2485-
><h3 class="title-container"
2491+
><h3 class="heading-element-for-level--OfRDW title-container"
24862492
><button
24872493
class="collapsible-control"
24882494
aria-expanded="false"
@@ -2641,7 +2647,7 @@
26412647
></div
26422648
><div class="result-section"
26432649
><div class="collapsible-container collapsed"
2644-
><h3 class="title-container"
2650+
><h3 class="heading-element-for-level--OfRDW title-container"
26452651
><button
26462652
class="collapsible-control"
26472653
aria-expanded="false"

‎packages/report-e2e-tests/src/examples/combined-results-with-issues.snap.html‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -791,6 +791,10 @@
791791
margin-bottom: unset;
792792
}</style
793793
><style>
794+
.heading-element-for-level--OfRDW {
795+
margin-block-start: unset;
796+
margin-block-end: unset;
797+
}
794798
.failed-instances-container--FqWV6 .collapsible-content {
795799
margin-left: 24px;
796800
}
@@ -1792,7 +1796,7 @@
17921796
><div class="results-heading--pyS7R"><h2>Rules</h2></div
17931797
><div class="result-section"
17941798
><div class="collapsible-container collapsed"
1795-
><h3 class="title-container"
1799+
><h3 class="heading-element-for-level--OfRDW title-container"
17961800
><button
17971801
class="collapsible-control"
17981802
aria-expanded="false"
@@ -1813,7 +1817,8 @@
18131817
data-automation-id="rule-details-group"
18141818
><div
18151819
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
1816-
><h4 class="title-container"
1820+
><h4
1821+
class="heading-element-for-level--OfRDW title-container"
18171822
><button
18181823
class="collapsible-control"
18191824
aria-expanded="false"
@@ -2165,7 +2170,8 @@
21652170
></div
21662171
><div
21672172
class="collapsible-container collapsible-rule-details-group--h0lvd collapsed"
2168-
><h4 class="title-container"
2173+
><h4
2174+
class="heading-element-for-level--OfRDW title-container"
21692175
><button
21702176
class="collapsible-control"
21712177
aria-expanded="false"
@@ -2470,7 +2476,7 @@
24702476
></div
24712477
><div class="result-section"
24722478
><div class="collapsible-container collapsed"
2473-
><h3 class="title-container"
2479+
><h3 class="heading-element-for-level--OfRDW title-container"
24742480
><button
24752481
class="collapsible-control"
24762482
aria-expanded="false"
@@ -2629,7 +2635,7 @@
26292635
></div
26302636
><div class="result-section"
26312637
><div class="collapsible-container collapsed"
2632-
><h3 class="title-container"
2638+
><h3 class="heading-element-for-level--OfRDW title-container"
26332639
><button
26342640
class="collapsible-control"
26352641
aria-expanded="false"

‎packages/report-e2e-tests/src/examples/combined-results-without-issues.snap.html‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -791,6 +791,10 @@
791791
margin-bottom: unset;
792792
}</style
793793
><style>
794+
.heading-element-for-level--OfRDW {
795+
margin-block-start: unset;
796+
margin-block-end: unset;
797+
}
794798
.failed-instances-container--FqWV6 .collapsible-content {
795799
margin-left: 24px;
796800
}
@@ -1792,7 +1796,7 @@
17921796
><div class="results-heading--pyS7R"><h2>Rules</h2></div
17931797
><div class="result-section"
17941798
><div class="collapsible-container collapsed"
1795-
><h3 class="title-container"
1799+
><h3 class="heading-element-for-level--OfRDW title-container"
17961800
><button
17971801
class="collapsible-control"
17981802
aria-expanded="false"
@@ -1811,7 +1815,7 @@
18111815
></div></div></div
18121816
><div class="result-section"
18131817
><div class="collapsible-container collapsed"
1814-
><h3 class="title-container"
1818+
><h3 class="heading-element-for-level--OfRDW title-container"
18151819
><button
18161820
class="collapsible-control"
18171821
aria-expanded="false"
@@ -1970,7 +1974,7 @@
19701974
></div
19711975
><div class="result-section"
19721976
><div class="collapsible-container collapsed"
1973-
><h3 class="title-container"
1977+
><h3 class="heading-element-for-level--OfRDW title-container"
19741978
><button
19751979
class="collapsible-control"
19761980
aria-expanded="false"

‎packages/report-e2e-tests/src/examples/summary-scan-with-issues.snap.html‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -791,6 +791,10 @@
791791
margin-bottom: unset;
792792
}</style
793793
><style>
794+
.heading-element-for-level--OfRDW {
795+
margin-block-start: unset;
796+
margin-block-end: unset;
797+
}
794798
.failed-instances-container--FqWV6 .collapsible-content {
795799
margin-left: 24px;
796800
}
@@ -1792,7 +1796,7 @@
17921796
><div class="results-heading--D3Qtr"><h2>Results by URL</h2></div
17931797
><div class="url-result-section--PmEoY"
17941798
><div class="collapsible-container collapsed"
1795-
><h3 class="title-container"
1799+
><h3 class="heading-element-for-level--OfRDW title-container"
17961800
><button
17971801
class="collapsible-control"
17981802
aria-expanded="false"
@@ -1911,7 +1915,7 @@
19111915
></div
19121916
><div class="url-result-section--PmEoY"
19131917
><div class="collapsible-container collapsed"
1914-
><h3 class="title-container"
1918+
><h3 class="heading-element-for-level--OfRDW title-container"
19151919
><button
19161920
class="collapsible-control"
19171921
aria-expanded="false"
@@ -2010,7 +2014,7 @@
20102014
></div
20112015
><div class="url-result-section--PmEoY"
20122016
><div class="collapsible-container collapsed"
2013-
><h3 class="title-container"
2017+
><h3 class="heading-element-for-level--OfRDW title-container"
20142018
><button
20152019
class="collapsible-control"
20162020
aria-expanded="false"

‎packages/report-e2e-tests/src/examples/summary-scan-without-issues.snap.html‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -791,6 +791,10 @@
791791
margin-bottom: unset;
792792
}</style
793793
><style>
794+
.heading-element-for-level--OfRDW {
795+
margin-block-start: unset;
796+
margin-block-end: unset;
797+
}
794798
.failed-instances-container--FqWV6 .collapsible-content {
795799
margin-left: 24px;
796800
}
@@ -1792,7 +1796,7 @@
17921796
><div class="results-heading--D3Qtr"><h2>Results by URL</h2></div
17931797
><div class="url-result-section--PmEoY"
17941798
><div class="collapsible-container collapsed"
1795-
><h3 class="title-container"
1799+
><h3 class="heading-element-for-level--OfRDW title-container"
17961800
><button
17971801
class="collapsible-control"
17981802
aria-expanded="false"
@@ -1856,7 +1860,7 @@
18561860
><tbody></tbody></table></div></div></div
18571861
><div class="url-result-section--PmEoY"
18581862
><div class="collapsible-container collapsed"
1859-
><h3 class="title-container"
1863+
><h3 class="heading-element-for-level--OfRDW title-container"
18601864
><button
18611865
class="collapsible-control"
18621866
aria-expanded="false"
@@ -1926,7 +1930,7 @@
19261930
><tbody></tbody></table></div></div></div
19271931
><div class="url-result-section--PmEoY"
19281932
><div class="collapsible-container collapsed"
1929-
><h3 class="title-container"
1933+
><h3 class="heading-element-for-level--OfRDW title-container"
19301934
><button
19311935
class="collapsible-control"
19321936
aria-expanded="false"

‎src/common/components/heading-element-for-level.scss‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
// Copyright (c) Microsoft Corporation. All rights reserved.
2+
// Licensed under the MIT License.
3+
4+
.heading-element-for-level {
5+
margin-block-start: unset;
6+
margin-block-end: unset;
7+
}

0 commit comments

Comments
 (0)