Skip to content

Commit 65fe977

Browse files
authored
fix: update links styles, match style on the report (#948)
- Updating default links style to: - have no underline normally - have underline when hover - Remove link style override on the automated checks report (so we pick up the default links style - Update font color and weight for the header target page text on the automated checks report and on the details view
1 parent 7d8c3b4 commit 65fe977

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

src/DetailsView/Styles/detailsview.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,15 +314,17 @@ div.insights-file-issue-details-dialog-container {
314314
align-items: center;
315315
background-color: $neutral-0;
316316
font-size: 14px;
317-
font-weight: 600;
317+
font-weight: normal;
318318
border-bottom: 1px solid $neutral-alpha-8;
319+
319320
.details-view-target-page {
320321
margin-left: 12px;
321322
padding: 13px 8px;
322323
display: inherit;
323324
white-space: nowrap;
324325
overflow: hidden;
325326
text-overflow: ellipsis;
327+
color: $primary-text;
326328
width: 50%;
327329
.ms-Link {
328330
color: $communication-primary;

src/DetailsView/reports/automated-checks-report.scss

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -103,14 +103,6 @@ $outcome-not-applicable-summary-color: $neutral-outcome;
103103

104104
.rule-details-id {
105105
padding: 12px 0;
106-
107-
a {
108-
text-decoration: none !important;
109-
}
110-
}
111-
112-
.guidance-links a {
113-
text-decoration: none !important;
114106
}
115107
}
116108
}

src/DetailsView/reports/components/report-sections/header-section.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,11 @@
2929
margin: 0px 0px 0px 16px;
3030
display: inherit;
3131

32-
color: $neutral-60;
32+
color: $primary-text;
3333
font-family: $fontFamily;
3434
font-size: 14px;
3535
line-height: 20px;
36+
font-weight: normal;
3637

3738
a {
3839
@include ellipsedText();

src/common/styles/common.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,11 @@ button::after {
7171
.insights-link {
7272
// marking important to override office fabric style
7373
color: $link !important;
74+
text-decoration: none;
75+
7476
&:hover {
7577
color: $link-hover !important;
78+
text-decoration: underline;
7679
}
7780
}
7881

0 commit comments

Comments
 (0)