added tests

Author: giles17

python/packages/core/agent_framework/azure/_shared.py

@@ -230,7 +230,9 @@ def __init__(
             if not v1_base_url:
                 raise ServiceInitializationError(
                     "Please provide an endpoint or a base_url. "
-                    "For standard Azure OpenAI endpoints, the v1 API path will be appended automatically."
+                    "For standard Azure OpenAI endpoints (*.openai.azure.com and *.services.ai.azure.com), "
+                    "the v1 API path will be appended automatically; for non-standard or private deployments, "
+                    "you must provide a base_url that already includes the desired API path."
                 )
 
             # Determine the effective api_key for AsyncOpenAI

python/packages/core/tests/azure/test_azure_chat_client.py

@@ -630,6 +630,56 @@ async def test_streaming_with_none_delta(
     assert any(msg.contents for msg in results)
 
 
+def test_client_uses_custom_base_url_when_provided() -> None:
+    """Test that a custom base_url is used directly when provided."""
+    custom_base_url = "https://custom.example.com/my/path/"
+
+    client = AzureOpenAIChatClient(
+        deployment_name="gpt-4o",
+        base_url=custom_base_url,
+        api_key="test-key",
+    )
+
+    assert client.client is not None
+    assert str(client.client.base_url) == custom_base_url
+
+
+def test_client_constructs_v1_url_for_openai_azure_com_endpoint() -> None:
+    """Test v1 URL construction for .openai.azure.com endpoints."""
+    client = AzureOpenAIChatClient(
+        deployment_name="gpt-4o",
+        endpoint="https://my-resource.openai.azure.com",
+        api_key="test-key",
+    )
+
+    assert client.client is not None
+    assert str(client.client.base_url) == "https://my-resource.openai.azure.com/openai/v1/"
+
+
+def test_client_constructs_v1_url_for_services_ai_azure_com_endpoint() -> None:
+    """Test v1 URL construction for .services.ai.azure.com endpoints."""
+    client = AzureOpenAIChatClient(
+        deployment_name="gpt-4o",
+        endpoint="https://my-resource.services.ai.azure.com",
+        api_key="test-key",
+    )
+
+    assert client.client is not None
+    assert str(client.client.base_url) == "https://my-resource.services.ai.azure.com/openai/v1/"
+
+
+def test_client_raises_error_for_non_standard_endpoint() -> None:
+    """Test that non-standard endpoints raise an error."""
+    with pytest.raises(ServiceInitializationError) as exc_info:
+        AzureOpenAIChatClient(
+            deployment_name="gpt-4o",
+            endpoint="https://api.openai.com",
+            api_key="test-key",
+        )
+
+    assert "Please provide an endpoint or a base_url" in str(exc_info.value)
+
+
 @ai_function
 def get_story_text() -> str:
     """Returns a story about Emily and David."""

python/packages/core/tests/azure/test_azure_responses_client.py

@@ -6,6 +6,7 @@
 
 import pytest
 from azure.identity import AzureCliCredential
+from openai import AsyncOpenAI
 from pydantic import BaseModel
 from pytest import param
 
@@ -156,6 +157,59 @@ def test_serialize(azure_openai_unit_test_env: dict[str, str]) -> None:
     assert "User-Agent" not in dumped_settings["default_headers"]
 
 
+def test_responses_client_uses_custom_base_url_when_provided() -> None:
+    """Test that a custom base_url is used directly when provided."""
+    custom_base_url = "https://custom.example.com/my/path/"
+
+    client = AzureOpenAIResponsesClient(
+        deployment_name="gpt-4o",
+        base_url=custom_base_url,
+        api_key="test-key",
+    )
+
+    assert client.client is not None
+    assert isinstance(client.client, AsyncOpenAI)
+    assert str(client.client.base_url) == custom_base_url
+
+
+def test_responses_client_constructs_v1_url_for_openai_azure_com_endpoint() -> None:
+    """Test v1 URL construction for .openai.azure.com endpoints."""
+    client = AzureOpenAIResponsesClient(
+        deployment_name="gpt-4o",
+        endpoint="https://my-resource.openai.azure.com",
+        api_key="test-key",
+    )
+
+    assert client.client is not None
+    assert isinstance(client.client, AsyncOpenAI)
+    assert str(client.client.base_url) == "https://my-resource.openai.azure.com/openai/v1/"
+
+
+def test_responses_client_constructs_v1_url_for_services_ai_azure_com_endpoint() -> None:
+    """Test v1 URL construction for .services.ai.azure.com endpoints."""
+    client = AzureOpenAIResponsesClient(
+        deployment_name="gpt-4o",
+        endpoint="https://my-resource.services.ai.azure.com",
+        api_key="test-key",
+    )
+
+    assert client.client is not None
+    assert isinstance(client.client, AsyncOpenAI)
+    assert str(client.client.base_url) == "https://my-resource.services.ai.azure.com/openai/v1/"
+
+
+def test_responses_client_raises_error_for_non_standard_endpoint() -> None:
+    """Test that non-standard endpoints raise an error."""
+    with pytest.raises(ServiceInitializationError) as exc_info:
+        AzureOpenAIResponsesClient(
+            deployment_name="gpt-4o",
+            endpoint="https://api.openai.com",
+            api_key="test-key",
+        )
+
+    assert "Please provide an endpoint or a base_url" in str(exc_info.value)
+
+
 # region Integration Tests