fix: resolve all CI pipeline failures (#191)

- Rename ambiguous variable l to lock in intent_locks.py (ruff E741)
- Fix nexus test imports: modules.nexus.* -> nexus.* (hatch source mapping)
- Add modules/ to conftest sys.path, remove tests/nexus/__init__.py shadow
- Add prometheus-client and websockets to agent-mesh dev deps
- Add pytest.importorskip for cross-package test deps (agentmesh, agent_sre)
- Fix SCAK test assertions to match actual handle_failure API
- Skip Windows-specific path test on Linux CI runners
- Set GIT_TERMINAL_PROMPT=0 in security job
- Remove -x from pytest for complete failure reporting

Author: imran-siddique

.github/workflows/ci.yml

@@ -52,7 +52,7 @@ jobs:
             2>/dev/null || pip install --no-cache-dir pytest==8.4.1 pytest-asyncio==1.1.0 2>/dev/null || true
       - name: Test ${{ matrix.package }}
         working-directory: packages/${{ matrix.package }}
-        run: pytest tests/ -x -q --tb=short
+        run: pytest tests/ -q --tb=short
 
   security:
     runs-on: ubuntu-latest
@@ -67,6 +67,8 @@ jobs:
             safety==3.2.1 --hash=sha256:9f53646717ba052e1bf631bd54fb3da0fafa58e85d578b20a8b9affdcf81889e \
             2>/dev/null || pip install --no-cache-dir safety==3.2.1
       - name: Check dependencies
+        env:
+          GIT_TERMINAL_PROMPT: "0"
         run: |
           for pkg in agent-os agent-mesh agent-hypervisor agent-sre agent-compliance; do
             echo "=== $pkg ==="

packages/agent-hypervisor/src/hypervisor/session/intent_locks.py

@@ -96,22 +96,22 @@ def release_session_locks(self, session_id: str) -> int:
 
     def get_agent_locks(self, agent_did: str, session_id: str) -> list[IntentLock]:
         return [
-            l for l in self._locks.values()
-            if l.agent_did == agent_did
-            and l.session_id == session_id
-            and l.is_active
+            lock for lock in self._locks.values()
+            if lock.agent_did == agent_did
+            and lock.session_id == session_id
+            and lock.is_active
         ]
 
     def get_resource_locks(self, resource_path: str) -> list[IntentLock]:
         return [
-            l for l in self._locks.values()
-            if l.resource_path == resource_path
-            and l.is_active
+            lock for lock in self._locks.values()
+            if lock.resource_path == resource_path
+            and lock.is_active
         ]
 
     @property
     def active_lock_count(self) -> int:
-        return sum(1 for l in self._locks.values() if l.is_active)
+        return sum(1 for lock in self._locks.values() if lock.is_active)
 
     @property
     def contention_points(self) -> list[str]:

packages/agent-mesh/pyproject.toml

@@ -64,6 +64,8 @@ dev = [
     "ruff>=0.1.0",
     "mypy>=1.8.0",
     "fakeredis>=2.21.0",
+    "prometheus-client>=0.19.0",
+    "websockets>=12.0",
 ]
 redis = [
     "redis>=4.0",

packages/agent-os/tests/conftest.py

@@ -25,5 +25,5 @@
 sys.path.insert(0, str(REPO_ROOT / "modules" / "mute-agent" / "src"))
 sys.path.insert(0, str(REPO_ROOT / "modules" / "mute-agent"))
 sys.path.insert(0, str(REPO_ROOT / "modules" / "observability"))
-sys.path.insert(0, str(REPO_ROOT / "modules" / "nexus"))
+sys.path.insert(0, str(REPO_ROOT / "modules"))
 sys.path.insert(0, str(REPO_ROOT / "modules" / "mcp-kernel-server"))

packages/agent-os/tests/nexus/__init__.py

@@ -7,10 +7,10 @@
 import pytest
 from datetime import datetime
 
-from modules.nexus.client import NexusClient
-from modules.nexus.schemas.manifest import AgentManifest, AgentIdentity, AgentCapabilities, AgentPrivacy
-from modules.nexus.dmz import DataHandlingPolicy
-from modules.nexus.exceptions import (
+from nexus.client import NexusClient
+from nexus.schemas.manifest import AgentManifest, AgentIdentity, AgentCapabilities, AgentPrivacy
+from nexus.dmz import DataHandlingPolicy
+from nexus.exceptions import (
     IATPUnverifiedPeerException,
     IATPInsufficientTrustException,
 )

packages/agent-os/tests/nexus/test_client.py

@@ -7,9 +7,9 @@
 import pytest
 from datetime import datetime
 
-from modules.nexus.escrow import EscrowManager, ProofOfOutcome
-from modules.nexus.schemas.escrow import EscrowRequest, EscrowStatus
-from modules.nexus.exceptions import (
+from nexus.escrow import EscrowManager, ProofOfOutcome
+from nexus.schemas.escrow import EscrowRequest, EscrowStatus
+from nexus.exceptions import (
     EscrowNotFoundError,
     EscrowAlreadyResolvedError,
     InsufficientCreditsError,
@@ -91,7 +91,7 @@ async def test_release_success(self):
         receipt = await manager.create_escrow(request, "sig")
         await manager.activate_escrow(receipt.escrow_id)
 
-        from modules.nexus.schemas.escrow import EscrowRelease
+        from nexus.schemas.escrow import EscrowRelease
         release = EscrowRelease(
             escrow_id=receipt.escrow_id,
             outcome="success",
@@ -120,7 +120,7 @@ async def test_release_failure(self):
         receipt = await manager.create_escrow(request, "sig")
         await manager.activate_escrow(receipt.escrow_id)
 
-        from modules.nexus.schemas.escrow import EscrowRelease
+        from nexus.schemas.escrow import EscrowRelease
         release = EscrowRelease(
             escrow_id=receipt.escrow_id,
             outcome="failure",

packages/agent-os/tests/nexus/test_escrow.py

@@ -7,9 +7,9 @@
 import pytest
 from datetime import datetime
 
-from modules.nexus.registry import AgentRegistry, RegistrationResult, PeerVerification
-from modules.nexus.schemas.manifest import AgentManifest, AgentIdentity, AgentCapabilities, AgentPrivacy
-from modules.nexus.exceptions import (
+from nexus.registry import AgentRegistry, RegistrationResult, PeerVerification
+from nexus.schemas.manifest import AgentManifest, AgentIdentity, AgentCapabilities, AgentPrivacy
+from nexus.exceptions import (
     AgentAlreadyRegisteredError,
     AgentNotFoundError,
     IATPUnverifiedPeerException,

packages/agent-os/tests/nexus/test_registry.py

@@ -7,7 +7,7 @@
 import pytest
 from datetime import datetime
 
-from modules.nexus.reputation import (
+from nexus.reputation import (
     ReputationEngine,
     ReputationHistory,
     TrustScore,

packages/agent-os/tests/nexus/test_reputation.py

@@ -27,6 +27,9 @@
 
 import pytest
 
+agentmesh = pytest.importorskip("agentmesh", reason="agentmesh not installed")
+agent_sre = pytest.importorskip("agent_sre", reason="agent_sre not installed")
+
 from agent_os.policies.schema import (
     PolicyAction,
     PolicyCondition,